Skip to content

[NoQA] Revert "feat: Reduce amount of items displayed per page of SelectionList"#65808

Merged
techievivek merged 1 commit into
mainfrom
revert-65636-feat/65634-reduce-amount-of-items-per-page-of-selection-list
Jul 10, 2025
Merged

[NoQA] Revert "feat: Reduce amount of items displayed per page of SelectionList"#65808
techievivek merged 1 commit into
mainfrom
revert-65636-feat/65634-reduce-amount-of-items-per-page-of-selection-list

Conversation

@mountiny

@mountiny mountiny commented Jul 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts #65636

Straight revert

@mountiny mountiny requested a review from a team as a code owner July 10, 2025 06:35
@mountiny

mountiny commented Jul 10, 2025

Copy link
Copy Markdown
Contributor Author

Fixes this crash #65636 (comment)

@melvin-bot melvin-bot Bot requested a review from srikarparsi July 10, 2025 06:35
@melvin-bot

melvin-bot Bot commented Jul 10, 2025

Copy link
Copy Markdown

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team July 10, 2025 06:35
@techievivek techievivek merged commit 4f1e182 into main Jul 10, 2025
19 of 22 checks passed
@techievivek techievivek deleted the revert-65636-feat/65634-reduce-amount-of-items-per-page-of-selection-list branch July 10, 2025 06:36
@melvin-bot melvin-bot Bot added the Emergency label Jul 10, 2025
@melvin-bot

melvin-bot Bot commented Jul 10, 2025

Copy link
Copy Markdown

@techievivek looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny mountiny changed the title Revert "feat: Reduce amount of items displayed per page of SelectionList" [NoQA] Revert "feat: Reduce amount of items displayed per page of SelectionList" Jul 10, 2025
@techievivek

techievivek commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

Straight revert, not an emergenyc merge.

@OSBotify

OSBotify commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jul 10, 2025
@techievivek @OSBotify
Merge pull request #65808 from Expensify/revert-65636-feat/65634-redu…
6aaa431 
…ce-amount-of-items-per-page-of-selection-list

Revert "feat: Reduce amount of items displayed per page of SelectionList"

(cherry picked from commit 4f1e182)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 10, 2025
@github-actions github-actions Bot mentioned this pull request Jul 10, 2025
Closed
77 tasks
@github-actions

github-actions Bot commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.79-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions

github-actions Bot commented Jul 11, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.79-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srikarparsi srikarparsi Awaiting requested review from srikarparsi
1 more reviewer
@techievivek techievivek techievivek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mountiny mountiny

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mountiny @techievivek @OSBotify