iPhoneX SafeArea regression fix#6559
Merged
Merged
Conversation
Contributor
Author
parasharrajat
approved these changes
Dec 2, 2021
parasharrajat
left a comment
parasharrajat
left a comment
Member
There was a problem hiding this comment.
LGTM.
All yours @deetergp
Julesssss
approved these changes
Dec 2, 2021
Contributor
|
@deetergp I'm merging this for #urgency as it's a regression. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
95 tasks
Contributor
|
🚀 Deployed to staging by @Julesssss in version: 1.1.17-8 🚀
|
This was referenced Dec 8, 2021
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed my regression on iPhoneX SafeArea
Fixed Issues
$ #6530
$ #5926
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android