Skip to content

Disable submit button if Paypal username is unchanged#6545

Merged
TomatoToaster merged 1 commit into
mainfrom
jasper-addPaypalDisableButton
Nov 30, 2021
Merged

Disable submit button if Paypal username is unchanged#6545
TomatoToaster merged 1 commit into
mainfrom
jasper-addPaypalDisableButton

Conversation

@jasperhuangg

@jasperhuangg jasperhuangg commented Nov 30, 2021

Copy link
Copy Markdown
Contributor

Fixed Issues

https://expensify.slack.com/archives/C01GTK53T8Q/p1638198130032000

Tests/QA

  1. Navigate to the payments page (Settings > Payments)
  2. Click your existing Paypal.me username, or click "Add payment method" and select Paypal.me
  3. If you haven't set one yet, set one first, then repeat [2].
  4. Verify that the button is disabled.
  5. Change the username. Verify it becomes reenabled.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mp4

Android

Screen_Recording_20211130-112119_New.Expensify.mp4

iOS

ios.mp4

Desktop

desktop.mp4

Mobile Web

Upload.from.GitHub.for.iOS.MOV

@jasperhuangg jasperhuangg self-assigned this Nov 30, 2021
@jasperhuangg jasperhuangg requested a review from a team November 30, 2021 19:26
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team November 30, 2021 19:26
@jasperhuangg jasperhuangg marked this pull request as ready for review November 30, 2021 19:29
@jasperhuangg jasperhuangg requested a review from a team as a code owner November 30, 2021 19:29
@MelvinBot MelvinBot requested review from sketchydroide and removed request for a team November 30, 2021 19:30
@TomatoToaster TomatoToaster merged commit 4718ec4 into main Nov 30, 2021
@TomatoToaster TomatoToaster deleted the jasper-addPaypalDisableButton branch November 30, 2021 22:07
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Dec 7, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @TomatoToaster in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Dec 8, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@sophiepintoraetz

Copy link
Copy Markdown
Contributor

Hey all! Just a heads up that this issue caused this bug here >> we should have added the check for empty case check too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants