Skip to content

Fix: scroll issue for workspace pages#6543

Merged
Gonals merged 1 commit into
Expensify:mainfrom
parasharrajat:fix-workspace-pages
Dec 1, 2021
Merged

Fix: scroll issue for workspace pages#6543
Gonals merged 1 commit into
Expensify:mainfrom
parasharrajat:fix-workspace-pages

Conversation

@parasharrajat

@parasharrajat parasharrajat commented Nov 30, 2021

Copy link
Copy Markdown
Member

Details

Fixed Issues

$ #6496

Tests | QA Steps

  1. Navigate to workspace settings
  2. Change the orientation to landscape
  3. Click on any of the options.
  4. Scroll the page.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

iOS

Android

output_file.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner November 30, 2021 19:08
@MelvinBot MelvinBot requested review from Gonals and removed request for a team November 30, 2021 19:08
@Gonals Gonals merged commit c2b96c1 into Expensify:main Dec 1, 2021
@OSBotify

OSBotify commented Dec 1, 2021

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@parasharrajat

Copy link
Copy Markdown
Member Author

@Gonals Unfortunately, I missed two pages. I am sending a follow-up PR.

@OSBotify

OSBotify commented Dec 7, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Gonals in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Dec 8, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants