[No QA] Rename Button and Text components to ExpensifyButton and ExpensifyText#6538
Merged
Conversation
roryabraham
changed the title
joelbettner
approved these changes
Dec 2, 2021
joelbettner
left a comment
joelbettner
left a comment
Contributor
There was a problem hiding this comment.
Woof. That was a lot of files to look through. Got 'er done.
marcaaron
approved these changes
Dec 3, 2021
marcaaron
left a comment
marcaaron
left a comment
Contributor
There was a problem hiding this comment.
Tested on web. Everything LGTM.
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
5 tasks
Collaborator
|
Can somebody review and merge this? It is breaking the Workspace landing page. #6576 |
Contributor
Author
|
Reviewed! Will merge once tests pass. Thanks for jumping on that. |
95 tasks
Contributor
|
🚀 Deployed to staging by @marcaaron in version: 1.1.17-8 🚀
|
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR renames our custom
TextandButtoncomponents toExpensifyTextandExpensifyButton. This is to more clearly differentiate between our custom components and the standard react-native componentsTextandButton.cc @roryabraham @marcaaron
Fixed Issues
$ #3133
Tests
There's no clear way to test this. Mainly just clicked around to various pages in the app to make sure text and buttons seemed to be getting rendered correctly.
QA Steps
No specific QA. Just click around to various pages in the app and make sure that text and buttons seem to be behaving normally.
Tested On
Screenshots
I'm including screenshots of some different pages on different platforms to show that things seem to be working normally.
Web
Mobile Web
Desktop
iOS
Android