Skip to content

[WIP]Feature: Copy Markdown/HTML support #6537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
parasharrajat wants to merge 3 commits into from
Closed

[WIP]Feature: Copy Markdown/HTML support #6537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9178e2
Replace usages of clipboard module from RN-web to Clipboard lib
parasharrajat Nov 30, 2021
f9e8a59
Copy Markdown support
parasharrajat Nov 30, 2021
6a28810
Merge branch 'main' of github.com:Expensify/Expensify.cash into copy-…
parasharrajat Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@onfido/react-native-sdk": "^1.3.3",
"@react-native-async-storage/async-storage": "^1.15.5",
"@react-native-community/cli": "4.13.1",
"@react-native-community/clipboard": "^1.5.1",
"@react-native-community/clipboard": "git+https://github.com/Expensify/clipboard.git#6ffc501ef8689cbdb566506e1cfe0b4fdb7b80c8",
"@react-native-community/datetimepicker": "^3.5.2",
"@react-native-community/netinfo": "^7.1.3",
"@react-native-community/progress-bar-android": "^1.0.4",
Expand Down
2 changes: 1 addition & 1 deletion src/components/CommunicationsLink.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import React from 'react';
import {View, Pressable, Linking} from 'react-native';
import PropTypes from 'prop-types';
import Clipboard from '@react-native-community/clipboard';
import styles from '../styles/styles';
import compose from '../libs/compose';
import * as Expensicons from './Icon/Expensicons';
import Clipboard from '../libs/Clipboard';
import ContextMenuItem from './ContextMenuItem';
import withLocalize, {withLocalizePropTypes} from './withLocalize';
import withWindowDimensions, {windowDimensionsPropTypes} from './withWindowDimensions';
Expand Down
2 changes: 1 addition & 1 deletion src/components/CopyTextToClipboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import React from 'react';
import PropTypes from 'prop-types';
import Clipboard from '@react-native-community/clipboard';
import ExpensifyText from './ExpensifyText';
import * as Expensicons from './Icon/Expensicons';
import Clipboard from '../libs/Clipboard';
import Icon from './Icon';
import styles from '../styles/styles';
import themeColors from '../styles/themes/default';
Expand Down
4 changes: 0 additions & 4 deletions src/libs/Clipboard/index.js
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/libs/Clipboard/index.native.js
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions src/pages/home/report/ContextMenu/ContextMenuActions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import _ from 'underscore';
import lodashGet from 'lodash/get';
import Str from 'expensify-common/lib/str';
import Clipboard from '@react-native-community/clipboard';
import * as Expensicons from '../../../../components/Icon/Expensicons';
import * as Report from '../../../../libs/actions/Report';
import Clipboard from '../../../../libs/Clipboard';
import * as ReportUtils from '../../../../libs/reportUtils';
import ReportActionComposeFocusManager from '../../../../libs/ReportActionComposeFocusManager';
import {hideContextMenu, showDeleteModal} from './ReportActionContextMenu';
Expand Down Expand Up @@ -54,9 +54,9 @@ export default [
? reportAction.isAttachment
: ReportUtils.isReportMessageAttachment(text);
if (!isAttachment) {
Clipboard.setString(text);
Clipboard.setHTML(html, text);
} else {
Clipboard.setString(html);
Clipboard.setString(text);
}
if (closePopover) {
hideContextMenu(true, ReportActionComposeFocusManager.focus);
Expand Down