Skip to content

Block Enter key bubbling to the composer, on selecting LHN row via Enter#6515

Merged
mountiny merged 1 commit into
Expensify:mainfrom
parasharrajat:event-bubble
Nov 29, 2021
Merged

Block Enter key bubbling to the composer, on selecting LHN row via Enter#6515
mountiny merged 1 commit into
Expensify:mainfrom
parasharrajat:event-bubble

Conversation

@parasharrajat

Copy link
Copy Markdown
Member

Details

Fixed Issues

$ #6386

Tests | QA Steps

  1. Click on the LHN on the top to not have anything selected
  2. Using the Tab key, select a chat
  3. Click Enter to open the page

Tested On

  • Web
  • Mobile Web (Not affected)
  • Desktop
  • iOS (Not affected)
  • Android (Not affected)

Screenshots

Web | Desktop

output_file.mp4

Mobile Web

iOS

Android

@parasharrajat parasharrajat requested a review from a team as a code owner November 29, 2021 20:12
@MelvinBot MelvinBot requested review from mountiny and removed request for a team November 29, 2021 20:12

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mountiny mountiny merged commit d471d34 into Expensify:main Nov 29, 2021
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Dec 7, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @mountiny in version: 1.1.17-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Dec 8, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the event-bubble branch November 20, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants