Fix/63635 onyx lift money request by Pujan92 · Pull Request #65023 · Expensify/App

Pujan92 · 2025-06-26T16:11:40Z

Explanation of Change

Part 1 - Improve ReportList performance by lifting Onyx connections from the below components to the list level.

MoneyRequestPreview: Component doesn't exist now
MoneyRequestReportPreview: removed usage of useOnyx for chatReport, iouReport, invoiceReceiverPolicy, invoiceReceiverPersonalDetail
EmptyMoneyRequestReportPreview.tsx: no onyx connection
MoneyRequestReportPreviewContent.tsx: I think we need onyx connection for reportActions here
TransactionPreview: removed usage of useOnyx for chatReport, sessionAccountID, personalDetailsList, walletTermsErrors
MoneyRequestAction.tsx: removed usage of useOnyx for chatReport, iouReport

Fixed Issues

$ #63635
PROPOSAL:

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Test 1:

Sign in to account A
Sign in to account B on another browser or incognito mode
Create an Expense either directly or in the workspace chat
Verify that the Money Request Report Preview looks correct
Update the details and verify that the updation is reflected correctly for both the user
Use other request options(for eg. Split Expense) and verify the Report Preview looks correct

Test 2:

Go to Reports Tab -> Chats
Verify the Money Request Report Preview of transactions looks correct

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

an2.webm

Android: mWeb Chrome

an1.webm

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-07-02.at.17.41.37.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-07-01.at.20.12.12.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-06-27.at.11.49.20.mov

MacOS: Desktop

Screen.Recording.2025-07-04.at.17.32.33.mov

melvin-bot · 2025-06-26T18:22:38Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2025-06-26T23:06:59Z

@Pujan92 do you mind sharing some perf measurement?

Pujan92 · 2025-06-27T06:42:07Z

Report with ~100 messages and 4 Transactions

=== 📁 Trace File Analysis ===

📄 File: profiling-data.27-06-2025.12-08-51(main).json
  • Commit count: 71
  • Total render duration: 923.600 ms
  • p50 / p95 / p99 (ms):
    • p50: 1.200 ms
    • p95: 37.300 ms
    • p99: 336.000 ms

📄 File: profiling-data.27-06-2025.12-10-20(PR).json
  • Commit count: 70
  • Total render duration: 943.500 ms
  • p50 / p95 / p99 (ms):
    • p50: 1.800 ms
    • p95: 33.000 ms
    • p99: 339.900 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ profiling-data.27-06-2025.12-10-20(PR).json
  🔴 Duration Diff: 19.900 ms
  🟢 Commit Count Diff: -1

hoangzinh · 2025-06-27T09:51:03Z

It doesn't seem to be improved

Pujan92 · 2025-06-27T13:59:11Z

@hoangzinh I added more transactions and below is the result now, I think it is clearer when we add more report previews and transactions.

=== 📁 Trace File Analysis ===

📄 File: profiling-data.27-06-2025.19-19-42(main).json
  • Commit count: 62
  • Total render duration: 907.600 ms
  • p50 / p95 / p99 (ms):
    • p50: 0.900 ms
    • p95: 29.600 ms
    • p99: 371.800 ms

📄 File: profiling-data.27-06-2025.19-26-51(PR).json
  • Commit count: 62
  • Total render duration: 878.100 ms
  • p50 / p95 / p99 (ms):
    • p50: 0.700 ms
    • p95: 29.000 ms
    • p99: 345.800 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ profiling-data.27-06-2025.19-26-51(PR).json
  🟢 Duration Diff: -29.500 ms
  ⚪️ Commit Count Diff: 0

Pujan92 · 2025-06-27T14:09:47Z

@adamgrzybowski @TMisiukiewicz PR is ready for review.

I haven't made a change for the transaction by passing all transactions as it will be handled in this issue

adamgrzybowski · 2025-06-27T14:35:02Z

@Pujan92 I am the right Adam here? Or maybe you wanted to ping the one from Callstack?

Pujan92 · 2025-06-27T14:50:49Z

Oops, sorry. It needs to be @adhorodyski

hoangzinh · 2025-06-30T22:01:53Z

Let me know your thoughts on my feedbacks @Pujan92

adhorodyski · 2025-07-03T12:17:38Z

@Pujan92 testing your changes now on a HT export from Jason 🤞🏻

adhorodyski · 2025-07-03T14:14:56Z

we're adding 2 extra rerenders
we're shaving off ~170/200ms of the rendering time

Run 1:

=== 📁 Trace File Analysis ===

📄 File: before2.json
  • Commit count: 14
  • Total render duration: 2089.201 ms
  • p50 / p95 / p99 (ms):
    • p50: 31.424 ms
    • p95: 741.366 ms
    • p99: 741.366 ms

📄 File: after.json
  • Commit count: 16
  • Total render duration: 1902.070 ms
  • p50 / p95 / p99 (ms):
    • p50: 21.337 ms
    • p95: 791.355 ms
    • p99: 791.355 ms

📄 File: after2.json
  • Commit count: 16
  • Total render duration: 1937.423 ms
  • p50 / p95 / p99 (ms):
    • p50: 22.671 ms
    • p95: 791.620 ms
    • p99: 791.620 ms

📄 File: after3.json
  • Commit count: 16
  • Total render duration: 1943.183 ms
  • p50 / p95 / p99 (ms):
    • p50: 21.774 ms
    • p95: 795.738 ms
    • p99: 795.738 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ after.json
  🟢 Duration Diff: -187.131 ms
  🔴 Commit Count Diff: 2

🔁 Comparing Baseline ↔️ after2.json
  🟢 Duration Diff: -151.778 ms
  🔴 Commit Count Diff: 2

🔁 Comparing Baseline ↔️ after3.json
  🟢 Duration Diff: -146.018 ms
  🔴 Commit Count Diff: 2

Run 2:

=== 📁 Trace File Analysis ===

📄 File: before3.json
• Commit count: 14
• Total render duration: 2134.101 ms
• p50 / p95 / p99 (ms):
  • p50: 26.954 ms
  • p95: 754.293 ms
  • p99: 754.293 ms

📄 File: after.json
• Commit count: 16
• Total render duration: 1902.070 ms
• p50 / p95 / p99 (ms):
  • p50: 21.337 ms
  • p95: 791.355 ms
  • p99: 791.355 ms

📄 File: after2.json
• Commit count: 16
• Total render duration: 1937.423 ms
• p50 / p95 / p99 (ms):
  • p50: 22.671 ms
  • p95: 791.620 ms
  • p99: 791.620 ms

📄 File: after3.json
• Commit count: 16
• Total render duration: 1943.183 ms
• p50 / p95 / p99 (ms):
  • p50: 21.774 ms
  • p95: 795.738 ms
  • p99: 795.738 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ after.json
🟢 Duration Diff: -232.031 ms
🔴 Commit Count Diff: 2

🔁 Comparing Baseline ↔️ after2.json
🟢 Duration Diff: -196.678 ms
🔴 Commit Count Diff: 2

🔁 Comparing Baseline ↔️ after3.json
🟢 Duration Diff: -190.918 ms
🔴 Commit Count Diff: 2

hoangzinh · 2025-07-03T14:38:58Z

@adhorodyski, do we have any concern about re-rendering? Or because rendering time is reduced, this PR is good to go?

adhorodyski · 2025-07-03T15:39:45Z

It's a net gain so I think we're good to go.

hoangzinh · 2025-07-03T21:10:41Z

Thanks @adhorodyski

hoangzinh · 2025-07-03T21:14:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-07-04.at.21.26.37.mov

Android: mWeb Chrome

Screen.Recording.2025-07-04.at.21.24.06.android.chrome.mov

iOS: HybridApp

Screen.Recording.2025-07-04.at.21.13.57.ios.mov

iOS: mWeb Safari

Screen.Recording.2025-07-04.at.21.10.10.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-04.at.21.04.37.web.mov

MacOS: Desktop

Screen.Recording.2025-07-04.at.21.16.00.desktop.mov

hoangzinh · 2025-07-03T21:36:29Z

@Pujan92 do you think we should preload ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS as we did for allPolicies and allReports to solve double useOnyx here?

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Lines 144 to 145 in c71d38e

    
           const isIouReportArchived = useReportIsArchived(iouReportID); 
        
           const isChatReportArchived = useReportIsArchived(chatReport?.reportID);

Pujan92 · 2025-07-04T06:00:44Z

@Pujan92 do you think we should preload ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS as we did for allPolicies and allReports to solve double useOnyx here?

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Lines 144 to 145 in c71d38e

const isIouReportArchived = useReportIsArchived(iouReportID);

const isChatReportArchived = useReportIsArchived(chatReport?.reportID);

Hmm, let me include that in part 2 PR if you are ok.

hoangzinh · 2025-07-04T09:03:05Z

That plan works to me. I will try to complete review checklist today

hoangzinh · 2025-07-04T10:14:37Z

@Pujan92 can you complete recording for desktop in meanwhile?

hoangzinh

LGTM

mjasikowski · 2025-07-07T10:10:40Z

@luacmartins over to you

Pujan92 · 2025-07-07T12:16:43Z

@mjasikowski Actually, @luacmartins has raised a concern as I have asked them to confirm but later in this comment I clarified that it doesn't seem to be the issue and it remains/behaves the same how it was earlier.
If you think above comment makes sense then can you plz merge this PR so I can continue on part 2.

mjasikowski · 2025-07-07T12:40:43Z

Let's wait for Carlos, I'll ping him directly on DM

luacmartins

LGTM

OSBotify · 2025-07-07T14:48:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-08T21:34:36Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.78-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-10T06:53:17Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.78-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Pujan92 added 10 commits June 26, 2025 12:16

remove useOnyx for chat and iou report in MoneyRequestReportPreview

c69d1f6

remove useOnyx for chatReport and iouReport in MoneyRequestAction

7788b4f

remove useOnyx for policy in MoneyRequestReportPreview

f323141

removed useOnyx from MoneyRequestReportPreview

2705fcb

used allReports for TransactionPreview

94384ca

used context for session and personalDetails in TransactionPreview

315651a

lint and prettier fix

7acae97

Merge branch 'main' into fix/63635-onyx-lift-money-request

d19d436

lint fix

a245ec3

lint fix

b9a307e

Pujan92 marked this pull request as ready for review June 26, 2025 18:22

Pujan92 requested a review from a team as a code owner June 26, 2025 18:22

melvin-bot Bot requested review from hoangzinh and removed request for a team June 26, 2025 18:22

Merge branch 'main' into fix/63635-onyx-lift-money-request

9191044

Merge branch 'main' into fix/63635-onyx-lift-money-request

70ad5b7

hoangzinh reviewed Jun 28, 2025

View reviewed changes

Pujan92 added 4 commits July 1, 2025 16:55

Merge branch 'main' into fix/63635-onyx-lift-money-request

7a53dd7

policies canBeMissing to true

13afc3e

prettier fix

5a5d15c

Merge branch 'main' into fix/63635-onyx-lift-money-request

d71e906

Pujan92 mentioned this pull request Jul 3, 2025

[Due for payment 2025-07-17] Improve Report display related list component performance #63637

Closed

Merge branch 'main' into fix/63635-onyx-lift-money-request

716e6cf

Merge branch 'main' into fix/63635-onyx-lift-money-request

32a7bbb

Merge branch 'main' into fix/63635-onyx-lift-money-request

ade11b1

hoangzinh approved these changes Jul 4, 2025

View reviewed changes

melvin-bot Bot requested a review from mjasikowski July 4, 2025 14:28

mjasikowski approved these changes Jul 7, 2025

View reviewed changes

luacmartins assigned Pujan92 Jul 7, 2025

luacmartins approved these changes Jul 7, 2025

View reviewed changes

luacmartins merged commit 7e09a70 into Expensify:main Jul 7, 2025
21 checks passed

github-actions Bot mentioned this pull request Jul 8, 2025

Deploy Checklist: New Expensify 2025-07-08 #65687

Closed

59 tasks

BlameGPT mentioned this pull request Jul 9, 2025

Android - Chat - Delete modal overlaps with navigation bar #65700

Closed

8 tasks

jponikarchuk mentioned this pull request Jul 9, 2025

mWeb - Split expense preview updates inconsistently for user B when edited #65737

Closed

8 tasks

melvin-bot Bot mentioned this pull request Jul 10, 2025

[Due for payment 2025-07-17] Money Request and Transaction list performance optimizations #63635

Closed

Uh oh!

Conversation

Pujan92 commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 26, 2025

Uh oh!

hoangzinh commented Jun 26, 2025

Uh oh!

Pujan92 commented Jun 27, 2025

Uh oh!

hoangzinh commented Jun 27, 2025

Uh oh!

Pujan92 commented Jun 27, 2025

Uh oh!

Pujan92 commented Jun 27, 2025

Uh oh!

adamgrzybowski commented Jun 27, 2025

Uh oh!

Pujan92 commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hoangzinh commented Jun 30, 2025

Uh oh!

adhorodyski commented Jul 3, 2025

Uh oh!

adhorodyski commented Jul 3, 2025

Uh oh!

hoangzinh commented Jul 3, 2025

Uh oh!

adhorodyski commented Jul 3, 2025

Uh oh!

hoangzinh commented Jul 3, 2025

Uh oh!

hoangzinh commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Jul 3, 2025

Uh oh!

Pujan92 commented Jul 4, 2025

Uh oh!

hoangzinh commented Jul 4, 2025

Uh oh!

hoangzinh commented Jul 4, 2025

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

mjasikowski commented Jul 7, 2025

Uh oh!

Pujan92 commented Jul 7, 2025

Uh oh!

mjasikowski commented Jul 7, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 7, 2025

Uh oh!

github-actions Bot commented Jul 8, 2025

Uh oh!

github-actions Bot commented Jul 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Pujan92 commented Jun 26, 2025 •

edited

Loading

hoangzinh commented Jul 3, 2025 •

edited

Loading