changed logic to use 2 decimals instead of 3#6499
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
LGTM feel free to merge when the E2E tests finish. @danieldoglas Could you also add the reproduction steps from the original issue to this one for the QA steps? I think it's fine to copy and paste it. |
|
@danieldoglas, Great job getting your first Expensify/App pull request over the finish line! 🎉 I know there's a lot of information in our contributing guidelines, so here are some points to take note of 📝:
So it might take a while before you're paid for your work, but we typically post multiple new jobs every day, so there's plenty of opportunity. I hope you've had a positive experience contributing to this repo! 😊 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @TomatoToaster in version: 1.1.17-8 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀
|
cc: @rushatgabhane
Details
We were allowing 3 decimal cases in the amount field on Send Money/Request money. Changed it to 2.
Fixed Issues
$ #6286
QA Steps: