Skip to content

[NoQA] Add useNewTransactions tests #64938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 4 commits into from
Jun 30, 2025
Merged

[NoQA] Add useNewTransactions tests #64938

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad2ed7a
add useNewTransactions tests
SzymczakJ Jun 25, 2025
b89a2d6
add explanatory comments
SzymczakJ Jun 26, 2025
83c9754
fix PR comments
SzymczakJ Jun 27, 2025
8ab5e1a
delete redundant delays
SzymczakJ Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
299 changes: 299 additions & 0 deletions tests/unit/useNewTransactionsTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,299 @@
import {renderHook} from '@testing-library/react-native';
import useNewTransactions from '@hooks/useNewTransactions';
import type {Transaction} from '@src/types/onyx';

// We need to mock requestAnimationFrame to mimic long Onyx merge overhead
jest.spyOn(global, 'requestAnimationFrame').mockImplementation((callback: FrameRequestCallback) => {
setTimeout(() => {
callback(performance.now());
}, 30);
return 0;
});

const delay = (ms: number) =>
new Promise((resolve) => {
setTimeout(resolve, ms);
});

describe('useNewTransactions with empty cache', () => {
const transactionsAlreadyInReport = [
{transactionID: '2', amount: 200, created: '2023-10-02', currency: 'USD', reportID: 'report1', merchant: ''},
{transactionID: '3', amount: 300, created: '2023-10-03', currency: 'USD', reportID: 'report1', merchant: ''},
];
const newTransaction = {transactionID: '1', amount: 100, created: '2023-10-01T00:00:00Z', currency: 'USD', reportID: 'report1', merchant: ''};

it("doesn't return new transactions when no transactions are added", () => {
// 1. Report and transactions data is not loaded yet
const {rerender, result} = renderHook<Transaction[], {transactions: Transaction[]; hasOnceLoadedReportActions: boolean}>(
(props) => useNewTransactions(props.hasOnceLoadedReportActions, props.transactions),
{
initialProps: {
hasOnceLoadedReportActions: false,
transactions: [],
},
},
);

// 2. Report is loaded and it has no transactions so there are no further rerenders
rerender({
hasOnceLoadedReportActions: true,
transactions: [],
});
expect(result.current).toEqual([]);
});

it('returns no new transactions when transactions come from initial Report load', () => {
// 1. Report and transactions data is not loaded yet
const {rerender, result} = renderHook<Transaction[], {transactions: Transaction[]; hasOnceLoadedReportActions: boolean}>(
(props) => useNewTransactions(props.hasOnceLoadedReportActions, props.transactions),
{
initialProps: {
hasOnceLoadedReportActions: false,
transactions: [],
},
},
);
expect(result.current).toEqual([]);

// 2. Report is loaded and transactions data is not loaded yet
rerender({
hasOnceLoadedReportActions: true,
transactions: [],
});
expect(result.current).toEqual([]);

// 3. Report is loaded and transactions data is loaded
rerender({
hasOnceLoadedReportActions: true,
transactions: transactionsAlreadyInReport,
});
// there is no new transactions, because the transactions that were already in the report are not considered new
expect(result.current).toEqual([]);
});

it('returns new transactions when transactions are added after initial load', () => {
// 1. Report and transactions data is not loaded yet
const {rerender, result} = renderHook<Transaction[], {transactions: Transaction[]; hasOnceLoadedReportActions: boolean}>(
(props) => useNewTransactions(props.hasOnceLoadedReportActions, props.transactions),
{
initialProps: {
hasOnceLoadedReportActions: false,
transactions: [],
},
},
);
expect(result.current).toEqual([]);

// 2. Report is loaded and transactions data is not loaded yet
rerender({
hasOnceLoadedReportActions: true,
transactions: [],
});
expect(result.current).toEqual([]);

// 3. Report is loaded and transactions data is loaded
rerender({
hasOnceLoadedReportActions: true,
transactions: transactionsAlreadyInReport,
});
expect(result.current).toEqual([]);

// 4. User added new transaction
rerender({
hasOnceLoadedReportActions: true,
transactions: [...transactionsAlreadyInReport, newTransaction],
});
expect(result.current).toEqual([newTransaction]);
});

it('returns new transactions when adding transactions to empty report', async () => {
// 1. Report and transactions data is not loaded yet
const {rerender, result} = renderHook<Transaction[], {transactions: Transaction[]; hasOnceLoadedReportActions: boolean}>(
(props) => useNewTransactions(props.hasOnceLoadedReportActions, props.transactions),
{
initialProps: {
hasOnceLoadedReportActions: false,
transactions: [],
},
},
);

// 2. Report is loaded and it has no transactions so there are no further rerenders
rerender({
hasOnceLoadedReportActions: true,
transactions: [],
});
await delay(1000); // We need to wait to ensure that the skipFirstTransactionsChange is set to false by the useEffect
expect(result.current).toEqual([]);

// 3. User added new transaction
rerender({
hasOnceLoadedReportActions: true,
transactions: [newTransaction],
});
expect(result.current).toEqual([newTransaction]);
});

it('returns no new transactions when transactions are removed', () => {
// 1. Report and transactions data is not loaded yet
const {rerender, result} = renderHook<Transaction[], {transactions: Transaction[]; hasOnceLoadedReportActions: boolean}>(
(props) => useNewTransactions(props.hasOnceLoadedReportActions, props.transactions),
{
initialProps: {
hasOnceLoadedReportActions: false,
transactions: [],
},
},
);
expect(result.current).toEqual([]);

// 2. Report is loaded and transactions data is not loaded yet
rerender({
hasOnceLoadedReportActions: true,
transactions: [],
});
expect(result.current).toEqual([]);

// 3. Report is loaded and transactions data is loaded
rerender({
hasOnceLoadedReportActions: true,
transactions: transactionsAlreadyInReport,
});
expect(result.current).toEqual([]);

// 4. User removes a transaction
rerender({
hasOnceLoadedReportActions: true,
transactions: transactionsAlreadyInReport.slice(1),
});
expect(result.current).toEqual([]);
});
});

describe('useNewTransactions with transactions in cache', () => {
Comment thread
SzymczakJ marked this conversation as resolved.
const transactionsAlreadyInReport = [
{transactionID: '2', amount: 200, created: '2023-10-02', currency: 'USD', reportID: 'report1', merchant: ''},
{transactionID: '3', amount: 300, created: '2023-10-03', currency: 'USD', reportID: 'report1', merchant: ''},
];
const newTransaction = {transactionID: '1', amount: 100, created: '2023-10-01T00:00:00Z', currency: 'USD', reportID: 'report1', merchant: ''};

it("doesn't return new transactions when no transactions are added", () => {
// 1. Report and transactions data is loaded from Onyx
const {rerender, result} = renderHook<Transaction[], {transactions: Transaction[]; hasOnceLoadedReportActions: boolean}>(
(props) => useNewTransactions(props.hasOnceLoadedReportActions, props.transactions),
{
initialProps: {
hasOnceLoadedReportActions: true,
transactions: [],
},
},
);

// 2. Report is loaded and transactions data is loaded, but there were no new transactions
rerender({
hasOnceLoadedReportActions: true,
transactions: [],
});
expect(result.current).toEqual([]);
});

it('returns new transactions when newly added transactions come from initial Report load', () => {
// 1. Report and transactions data is loaded from Onyx
const {rerender, result} = renderHook((props) => useNewTransactions(props.hasOnceLoadedReportActions, props.transactions), {
initialProps: {
hasOnceLoadedReportActions: true,
transactions: transactionsAlreadyInReport,
},
});
expect(result.current).toEqual([]);

// 2. New transaction comes in when report is loaded
rerender({
hasOnceLoadedReportActions: true,
transactions: [...transactionsAlreadyInReport, newTransaction],
});
expect(result.current).toEqual([newTransaction]);
});

it('returns new transactions when transactions are added after initial load', () => {
// 1. Report and transactions data is loaded from Onyx
const {rerender, result} = renderHook((props) => useNewTransactions(props.hasOnceLoadedReportActions, props.transactions), {
initialProps: {
hasOnceLoadedReportActions: true,
transactions: transactionsAlreadyInReport,
},
});
expect(result.current).toEqual([]);

// 2. Report is loaded and transactions data is loaded, but there were no new transactions
rerender({
hasOnceLoadedReportActions: true,
transactions: transactionsAlreadyInReport,
});
expect(result.current).toEqual([]);

// 3. User added new transaction
rerender({
hasOnceLoadedReportActions: true,
transactions: [...transactionsAlreadyInReport, newTransaction],
});
expect(result.current).toEqual([newTransaction]);
});

it('returns new transactions when adding transactions to empty report', async () => {
// 1. Report and transactions data is loaded from Onyx
const {rerender, result} = renderHook<Transaction[], {transactions: Transaction[]; hasOnceLoadedReportActions: boolean}>(
(props) => useNewTransactions(props.hasOnceLoadedReportActions, props.transactions),
{
initialProps: {
hasOnceLoadedReportActions: true,
transactions: [],
},
},
);

// 2. Report is loaded and it has no transactions, so there are no further rerenders
rerender({
hasOnceLoadedReportActions: true,
transactions: [],
});
await delay(1000);
expect(result.current).toEqual([]);

// 3. User added new transaction
rerender({
hasOnceLoadedReportActions: true,
transactions: [newTransaction],
});
expect(result.current).toEqual([newTransaction]);
});

it('returns no new transactions when transactions are removed', () => {
// 1. Report and transactions data is loaded from Onyx
const {rerender, result} = renderHook((props) => useNewTransactions(props.hasOnceLoadedReportActions, props.transactions), {
initialProps: {
hasOnceLoadedReportActions: true,
transactions: transactionsAlreadyInReport,
},
});
expect(result.current).toEqual([]);

// 2. Report is loaded and transactions data is loaded, but there were no new transactions
rerender({
hasOnceLoadedReportActions: true,
transactions: transactionsAlreadyInReport,
});
expect(result.current).toEqual([]);

// 3. User removes a transaction
rerender({
hasOnceLoadedReportActions: true,
transactions: transactionsAlreadyInReport.slice(1),
});
expect(result.current).toEqual([]);
});
});

afterAll(() => {
jest.restoreAllMocks();
});
Loading