Skip to content

[CP Staging] Revert "Use tripdata payload to get reservations setup"#64769

Merged
mountiny merged 1 commit into
mainfrom
revert-63853-parasharrajat/travel-update
Jun 24, 2025
Merged

[CP Staging] Revert "Use tripdata payload to get reservations setup"#64769
mountiny merged 1 commit into
mainfrom
revert-63853-parasharrajat/travel-update

Conversation

@rlinoz

@rlinoz rlinoz commented Jun 23, 2025

Copy link
Copy Markdown
Contributor

Reverts #63853

https://expensify.slack.com/archives/C05LX9D6E07/p1750715484832909

Fixes trip preview showing NaN in the amount if child report is not loaded.

@rlinoz rlinoz marked this pull request as ready for review June 23, 2025 22:58
@rlinoz rlinoz requested a review from a team as a code owner June 23, 2025 22:58
@melvin-bot melvin-bot Bot requested review from cristipaval and removed request for a team June 23, 2025 22:58
@melvin-bot

melvin-bot Bot commented Jun 23, 2025

Copy link
Copy Markdown

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #64769.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://64769.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@mountiny mountiny changed the title Revert "Use tripdata payload to get reservations setup" [CP Staging] Revert "Use tripdata payload to get reservations setup" Jun 24, 2025

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mountiny mountiny merged commit 0fa3b40 into main Jun 24, 2025
19 of 25 checks passed
@mountiny mountiny deleted the revert-63853-parasharrajat/travel-update branch June 24, 2025 00:13
@melvin-bot melvin-bot Bot added the Emergency label Jun 24, 2025
@melvin-bot

melvin-bot Bot commented Jun 24, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny

Copy link
Copy Markdown
Contributor

Straight revert

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Jun 24, 2025
…ravel-update

[CP Staging] Revert "Use tripdata payload to get reservations setup"

(cherry picked from commit 0fa3b40)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jun 24, 2025
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.70-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@rlinoz

rlinoz commented Jun 24, 2025

Copy link
Copy Markdown
Contributor Author

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

3 similar comments
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 failure ❌

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging Ready To Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants