Add splash screen related logs#6476
Merged
NikkiWines merged 4 commits intoDec 2, 2021
Merged
Conversation
NikkiWines
requested changes
Nov 29, 2021
NikkiWines
left a comment
NikkiWines
left a comment
Contributor
There was a problem hiding this comment.
Couple minor comments + suggestions. Looks good overall though
| BootSplash.getVisibilityStatus() | ||
| .then((status) => { | ||
| Log.info('[BootSplash] Splash screen status', false, {status}); | ||
|
|
Contributor
Author
|
Ready for another review |
NikkiWines
reviewed
Nov 30, 2021
Contributor
Author
|
Ready for another review |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
95 tasks
Contributor
|
🚀 Deployed to staging by @NikkiWines in version: 1.1.17-8 🚀
|
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #6358
Tests
Verify there are no regressions caused by the refactor
App launch logged out
App launch logged in
If you monitor app logs you should be able to see this message logged about 30 sec after start
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android