Added attachment download loading indicator#6455
Merged
Jag96 merged 12 commits intoNov 30, 2021
Merged
Conversation
…pinner in AttachmentView
…class with isDownloading handling
…class with isDownloading handling
…tachment-download-loading-indicator # Conflicts: # src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly/index.js # src/components/AnchorForCommentsOnly/BaseAnchorForCommentsOnly/index.native.js
Collaborator
Author
|
@Jag96 Any updates for me on this one? |
Jag96
suggested changes
Nov 29, 2021
Jag96
left a comment
Jag96
left a comment
Contributor
There was a problem hiding this comment.
One thing I noticed on web (chrome)d, if I click the download icon and then click the spinner a few times while the file is downloading, after the first download is done the browser will attempt to download the file additional times based on how many times I clicked the spinner. Can we add a check in processDownload that doesn't call fileDownload if we are already downloading?
…tachment-download-loading-indicator # Conflicts: # src/components/AttachmentView.js
…en file is being downloaded
…en file is being downloaded
…ithub.com/mananjadhav/App into fix/attachment-download-loading-indicator
Collaborator
Author
|
@Jag96 Fixed the multiple download issue. PR updated |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
95 tasks
Contributor
Contributor
|
🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #6253
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
ios-download-indicator.mov
Android