Skip to content

[No QA] Pass Custom unit rate name to the backend when creating a per diem request #64249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deetergp merged 5 commits into from
Jun 16, 2025
Merged

[No QA] Pass Custom unit rate name to the backend when creating a per diem request #64249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0953ba3
Add helper functions
Gonals Jun 16, 2025
f8faf8b
pass new param
Gonals Jun 16, 2025
b9e71dc
Add to type
Gonals Jun 16, 2025
16cc16c
prettier
Gonals Jun 16, 2025
e60a508
remove uneeded type
Gonals Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libs/API/parameters/CreatePerDiemRequestParams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ type CreatePerDiemRequestParams = {
policyID: string;
created: string;
customUnitID: string;
customUnitRate: string;
customUnitRateID: string;
subRates: string;
currency: string;
Expand Down
9 changes: 9 additions & 0 deletions src/libs/PolicyUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,14 @@ function getDistanceRateCustomUnitRate(policy: OnyxEntry<Policy>, customUnitRate
return distanceUnit?.rates[customUnitRateID];
}

/**
* Retrieves custom unit rate object from the given customUnitRateID
*/
function getPerDiemRateCustomUnitRate(policy: OnyxEntry<Policy>, customUnitRateID: string): Rate | undefined {
const perDiemUnit = getPerDiemCustomUnit(policy);
return perDiemUnit?.rates[customUnitRateID];
}

function getRateDisplayValue(value: number, toLocaleDigit: (arg: string) => string, withDecimals?: boolean): string {
const numValue = getNumericValue(value, toLocaleDigit);
if (Number.isNaN(numValue)) {
Expand Down Expand Up @@ -1508,6 +1516,7 @@ export {
getDistanceRateCustomUnit,
getPerDiemCustomUnit,
getDistanceRateCustomUnitRate,
getPerDiemRateCustomUnitRate,
sortWorkspacesBySelected,
removePendingFieldsFromCustomUnit,
goBackWhenEnableFeature,
Expand Down
9 changes: 9 additions & 0 deletions src/libs/actions/IOU.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ import {
getCorrectedAutoReportingFrequency,
getMemberAccountIDsForWorkspace,
getPerDiemCustomUnit,
getPerDiemRateCustomUnitRate,
getPersonalPolicy,
getPolicy,
getSubmitToAccountID,
Expand Down Expand Up @@ -5354,10 +5355,18 @@ function submitPerDiemExpense(submitPerDiemExpenseInformation: PerDiemExpenseInf
});
const activeReportID = isMoneyRequestReport ? report?.reportID : chatReport.reportID;

const customUnitRate = getPerDiemRateCustomUnitRate(policyParams.policy, customUnit.customUnitRateID);

const customUnitRateParam = {
id: customUnitRate?.customUnitRateID,
name: customUnitRate?.name,
};

const parameters: CreatePerDiemRequestParams = {
policyID: policyParams.policy.id,
customUnitID: customUnit.customUnitID,
customUnitRateID: customUnit.customUnitRateID,
customUnitRate: JSON.stringify(customUnitRateParam),
subRates: JSON.stringify(customUnit.subRates),
startDateTime: customUnit.attributes.dates.start,
endDateTime: customUnit.attributes.dates.end,
Expand Down
Loading