Add 'action:pay/export' filter#63753
Conversation
|
@Julesssss Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@JS00001 we have conflicts |
|
@luacmartins @getusha This is ready for review, the BE changes are in |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppHaving hard time trying to build for android Android: mWeb ChromeScreen.Recording.2025-07-01.at.2.49.03.in.the.afternoon.moviOS: HybridAppScreen.Recording.2025-07-01.at.3.02.34.in.the.afternoon.moviOS: mWeb SafariScreen.Recording.2025-07-01.at.2.59.48.in.the.afternoon.movMacOS: DesktopScreen.Recording.2025-07-01.at.2.45.59.in.the.afternoon.mov |
|
If you filter by Screen.Recording.2025-07-01.at.2.57.22.in.the.afternoon.mov |
|
@techievivek Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.74-2 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.74-10 🚀
|
| filterKey === CONST.SEARCH.SYNTAX_FILTER_KEYS.DESCRIPTION || | ||
| filterKey === CONST.SEARCH.SYNTAX_FILTER_KEYS.TITLE | ||
| filterKey === CONST.SEARCH.SYNTAX_FILTER_KEYS.TITLE || | ||
| filterKey === CONST.SEARCH.SYNTAX_FILTER_KEYS.ACTION |
There was a problem hiding this comment.
This change caused
We should sanitize action value with CONST.SEARCH.ACTION_FILTERS


Explanation of Change
Add support for
action:payas a helper filter. This PR also updates the default pay query totype:expense status:all group-by:reports action:pay reimbursable:yes payer:user@test.comFixed Issues
Part of https://github.com/Expensify/Expensify/issues/505933
$ #64688
Tests
NOTE: We do NOT support P2P payments in the pay query. The pay query is exclusively for payments that come from a workspace, not personal policies.
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: HybridApp
Screen.Recording.2025-06-16.at.10.37.25.at.night.mov
Android: mWeb Chrome
Screen.Recording.2025-06-16.at.9.16.25.at.night.mov
iOS: HybridApp
Screen.Recording.2025-06-16.at.9.55.23.at.night.mov
iOS: mWeb Safari
Screen.Recording.2025-06-16.at.9.20.27.at.night.mov
MacOS: Chrome / Safari
Screen.Recording.2025-06-16.at.9.04.26.at.night.mov
MacOS: Desktop
Screen.Recording.2025-06-16.at.9.53.05.at.night.mov