fix(perf): directly pass props to lhn items by adhorodyski · Pull Request #63362 · Expensify/App

adhorodyski · 2025-06-03T15:00:32Z

Explanation of Change

This PR moves useOnyx connections from within render items of LHN up the tree to the list level. This lets the CPU breathe more while maintaining the very same behaviour and data.

Fixed Issues

$ #63439
PROPOSAL: N/A

Tests

This is how I measured the below results:

Let LHN load
Focus on the first item (if on web)
Scroll down once

Offline tests

QA Steps

Create fresh account
Start chat with a random user and send a message
Go back to LHN and verify the chat is on the top of the list
Long press/Right click on Concierge chat and select "Pin"
Verify the Concierge chat went to the top of the list
Start another chat
Create a task and assign it to yourself
Verify that chat went to the 1st or 2nd position in the LHN (it would be sorted alphabetically together with Concierge)
Go to Account -> Preferences
Change the Priority Mode to Focus
Go back to LHN
Verify the only visible chats are Pinned chat and the one where you assigned the task with GBR
Go to task with GBR and resolve task
Go back to LHN and verify the chat is not visible anymore
Go to Account -> Preferences
Change the Priority Mode to Most Recent
Go back to LHN
Verify all three reports are visible

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

adhorodyski · 2025-06-03T15:01:46Z

=== 📁 Trace File Analysis ===

📄 File: before.json
  • Commit count: 90
  • Total render duration: 223.100 ms
  • p50 / p95 / p99 (ms):
    • p50: 1.300 ms
    • p95: 8.900 ms
    • p99: 12.100 ms

📄 File: after.json
  • Commit count: 68
  • Total render duration: 147.200 ms
  • p50 / p95 / p99 (ms):
    • p50: 1.100 ms
    • p95: 6.000 ms
    • p99: 6.700 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ after.json
  🟢 Duration Diff: -75.900 ms
  🟢 Commit Count Diff: -22

adhorodyski · 2025-06-03T15:05:29Z

melvin-bot · 2025-06-04T14:28:37Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

brunovjk · 2025-06-04T21:48:04Z

Do we need the C+ checklist here @adhorodyski? Thanks.

brunovjk · 2025-06-04T21:48:13Z

I tested it and didn't find much difference as in your results:

@adhorodyski after pressing record, we just select the first item and scroll down, right? Or am I doing something wrong? Thanks.

MacOS: Chrome - Recording profiler

Screen.Recording.2025-06-04.at.18.34.04.mov

mountiny · 2025-06-04T22:03:21Z

@brunovjk yes please we would like a checklist and testing on this one

adhorodyski · 2025-06-05T09:58:11Z

Ok I retested this 3x before and 3x after on a heavy account. From the timings we're both getting, it just looks like you're on a much smaller account - the % diffs are very similar, and we also have to take into account that there are lots of moving parts in the React tree that make it pretty hard to reproduce 1:1 (see that some of my runs are also different).
The render count still goes from ~9 down to ~7 so the gain is there and scales well with the size of the account (and amount of data to process on each render).

=== 📁 Trace File Analysis ===

📄 File: before.json
  • Commit count: 88
  • Total render duration: 202.200 ms
  • p50 / p95 / p99 (ms):
    • p50: 1.300 ms
    • p95: 8.000 ms
    • p99: 10.300 ms

📄 File: after.json
  • Commit count: 67
  • Total render duration: 194.300 ms
  • p50 / p95 / p99 (ms):
    • p50: 1.400 ms
    • p95: 8.200 ms
    • p99: 13.000 ms

📄 File: after2.json
  • Commit count: 59
  • Total render duration: 111.800 ms
  • p50 / p95 / p99 (ms):
    • p50: 1.100 ms
    • p95: 4.700 ms
    • p99: 7.000 ms

📄 File: after3.json
  • Commit count: 54
  • Total render duration: 153.200 ms
  • p50 / p95 / p99 (ms):
    • p50: 1.200 ms
    • p95: 17.200 ms
    • p99: 20.100 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ after.json
  🟢 Duration Diff: -7.900 ms
  🟢 Commit Count Diff: -21

🔁 Comparing Baseline ↔️ after2.json
  🟢 Duration Diff: -90.400 ms
  🟢 Commit Count Diff: -29

🔁 Comparing Baseline ↔️ after3.json
  🟢 Duration Diff: -49.000 ms
  🟢 Commit Count Diff: -34

mountiny · 2025-06-05T15:06:35Z

@brunovjk feel free to continue with this

brunovjk · 2025-06-05T18:37:08Z

@brunovjk feel free to continue with this

Sure :D I'm testing on others platforms

brunovjk · 2025-06-05T21:42:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

trace-report-2.txt

brunovjk

LGTM

mountiny

Nice, great! moving this ahead with the NABs, please address them elsewhere.

mountiny · 2025-06-05T22:06:54Z

+    /** Whether the fullscreen is visible */
+    isFullscreenVisible?: boolean;
+
+    isReportsSplitNavigatorLast: boolean;


missing comment

mountiny · 2025-06-05T22:07:01Z

+    /** Whether the fullscreen is visible */
+    isFullscreenVisible?: boolean;
+
+    isReportsSplitNavigatorLast: boolean;


missing comment

OSBotify · 2025-06-05T22:16:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-09T16:55:21Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.63-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2025-06-09T17:30:44Z

Hey, @adhorodyski . Do we have QA steps here?

adhorodyski · 2025-06-09T18:00:26Z

@IuliiaHerets hey, no more than the FE performance tests to conduct for each change. For functional testing this should change completely nothing.

IuliiaHerets · 2025-06-09T18:32:43Z

@adhorodyski Can you add QA steps?

techievivek · 2025-06-10T15:31:09Z

@adhorodyski Seems like this has caused a regression here #63811, we are gonna revert this change for now.

github-actions · 2025-06-10T22:41:37Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.63-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

This was referenced Jun 3, 2025

[HOLD][#quality improvement] Audit our code and output what we think are the arch patterns that prevent us from finding the root causes of bugs easily #59256

Closed

[$1,000] Improve lists performance by not calling useOnyx in list items #63439

Closed

adhorodyski added 5 commits June 4, 2025 16:17

chore: directly pass report to each lhn list item

171bc4c

chore: directly pass activePolicyID to each lhn list item

22774b0

chore: directly pass onboardingPurpose to each lhn list item

2e10367

chore: directly pass isFullscreenVisible to each lhn list item

88a855d

chore: directly pass isReportsSplitNavigatorLast to each lhn list item

520b714

adhorodyski force-pushed the fix/lhn-props branch from ad4997f to 520b714 Compare June 4, 2025 14:27

adhorodyski marked this pull request as ready for review June 4, 2025 14:28

adhorodyski requested a review from a team as a code owner June 4, 2025 14:28

melvin-bot Bot requested review from brunovjk and removed request for a team June 4, 2025 14:28

fix: run prettier

0deb4f3

adhorodyski changed the title ~~fix: directly pass props to lhn items~~ fix(perf): directly pass props to lhn items Jun 4, 2025

mountiny assigned adhorodyski Jun 4, 2025

adhorodyski added 2 commits June 5, 2025 12:10

Merge branch 'Expensify:main' into fix/lhn-props

7cc09b4

Merge branch 'Expensify:main' into fix/lhn-props

c87b1c7

brunovjk approved these changes Jun 5, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny June 5, 2025 21:42

mountiny approved these changes Jun 5, 2025

View reviewed changes

mountiny merged commit 4f5bde6 into Expensify:main Jun 5, 2025

adhorodyski deleted the fix/lhn-props branch June 6, 2025 13:19

github-actions Bot mentioned this pull request Jun 9, 2025

Deploy Checklist: New Expensify 2025-06-09 #63762

Closed

77 tasks

linhvovan29546 mentioned this pull request Jun 10, 2025

[$250] Sign Up - Tooltip in Concierge chat, is not shown until navigating to a different section. #63811

Closed

8 tasks

techievivek mentioned this pull request Jun 10, 2025

[CP staging]Revert "fix(perf): directly pass props to lhn items" #63864

Merged

adhorodyski mentioned this pull request Jun 12, 2025

fix(perf): move useOnyx call up the tree on LHN #64076

Merged

50 tasks

mjasikowski mentioned this pull request Jul 15, 2025

[Due for payment 2025-08-13] [Due for payment 2025-08-05] ReportActionItem list performance optimization #66149

Closed

Uh oh!

Conversation

adhorodyski commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

adhorodyski commented Jun 3, 2025

Uh oh!

adhorodyski commented Jun 3, 2025

Uh oh!

melvin-bot Bot commented Jun 4, 2025

Uh oh!

brunovjk commented Jun 4, 2025

Uh oh!

brunovjk commented Jun 4, 2025

Uh oh!

mountiny commented Jun 4, 2025

Uh oh!

adhorodyski commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Jun 5, 2025

Uh oh!

brunovjk commented Jun 5, 2025

Uh oh!

brunovjk commented Jun 5, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

brunovjk left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 5, 2025

Uh oh!

github-actions Bot commented Jun 9, 2025

Uh oh!

IuliiaHerets commented Jun 9, 2025

Uh oh!

adhorodyski commented Jun 9, 2025

Uh oh!

IuliiaHerets commented Jun 9, 2025

Uh oh!

techievivek commented Jun 10, 2025

Uh oh!

github-actions Bot commented Jun 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

adhorodyski commented Jun 3, 2025 •

edited

Loading

adhorodyski commented Jun 5, 2025 •

edited

Loading