[NO QA] Updating several articles in the Reports & Expenses category to optim… by maddylewis · Pull Request #63261 · Expensify/App

maddylewis · 2025-06-02T19:05:44Z

…ize and reflect navigation changes

https://github.com/Expensify/Expensify/issues/482861

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videosundefined

…ize and reflect navigation changes https://github.com/Expensify/Expensify/issues/482861

melvin-bot · 2025-06-02T19:06:20Z

melvin-bot · 2025-06-02T19:06:22Z

@neil-marcellini @alexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2025-06-02T19:09:07Z

A preview of your ExpensifyHelp changes have been deployed to https://60cf354b.helpdot.pages.dev ⚡️

neil-marcellini

So far I have reviewed these two:

docs/articles/new-expensify/reports-and-expenses/Adding-Attendees.md
docs/articles/new-expensify/reports-and-expenses/Approve-Expenses.md

I'll finish the rest tomorrow morning.

neil-marcellini

Thanks for the updates, I have now reviewed everything. I think there's some tweaks we should make to improve it even more. Thanks for working on this.

neil-marcellini · 2025-06-03T17:47:45Z

I don't think we should call this distance requests anymore because the term "request" is outdated. Let's say "expense" instead. We don't call manual or scan expenses requests anymore, so let's stay consistent with distance and call these distance expenses

Also, it seems like there should be information on this page about how the distance rate is defined and what options you have to change it.

updated request to expense! also does this article cover what you're thinking? this is more from a workspace admin's perspective - https://help.expensify.com/articles/new-expensify/workspaces/Set-distance-rates

Thanks for updating the naming there. No, unfortunately that article does not cover what I'm thinking about. I think we should add to the FAQ section some info about questions like, "How do I change the distance rate?", "How is the default distance rate determined?

I seem to remember that we used to have this kind of information on the help site. Maybe we removed it? People submitting expenses should also know about distance rates in addition to admins.

If you would rather do this in a follow-up that works too, let's create an issue in that case so it's tracked.

maddylewis · 2025-06-04T16:06:09Z

@neil-marcellini - ok i think i covered everything! i did a redirect for Distance Request - Distance Expense...ill let the tests run to see if anything fails. there might be an issue with the redirects file.

neil-marcellini

Looks pretty good overall and most of my remaining comments are very small, non-blockers. The spell checker is failing and so is the build, because there are cycles in redirects.csv

neil-marcellini · 2025-06-05T18:08:09Z

Thanks for updating the naming there. No, unfortunately that article does not cover what I'm thinking about. I think we should add to the FAQ section some info about questions like, "How do I change the distance rate?", "How is the default distance rate determined?

I seem to remember that we used to have this kind of information on the help site. Maybe we removed it? People submitting expenses should also know about distance rates in addition to admins.

neil-marcellini · 2025-06-05T18:24:45Z

If you would rather do this in a follow-up that works too, let's create an issue in that case so it's tracked.

neil-marcellini · 2025-06-05T18:26:11Z

@@ -26,7 +26,7 @@ To submit a mileage-based expense:
   - (Optional) Add a **description**, **category**, or **tag**


Maybe list "Rate" below distance as something that you should review and confirm?

sorry im not totally understanding the request here -- if you think some additional info needs to be added to the site that's not in this PR, i would encourage you to request a resource update via this method https://stackoverflowteams.com/c/expensify/questions/19901

maddylewis · 2025-06-06T19:11:16Z

resolved conflicts

maddylewis · 2025-06-06T19:17:21Z

@neil-marcellini - for your comment here #63261, i would request a resource update to get what you're looking for added. that particular request is out of scope for what my assignment is -- i am updating all the resources to reflect the updated newdot navigation.

here are the steps to request a resource update! https://stackoverflowteams.com/c/expensify/questions/19901

maddylewis · 2025-06-06T19:34:30Z

@neil-marcellini - i didn't address a couple of comments bc they were slightly beyond the scope of this particular update. but all checks are now passing so hopefully we are good to merge 👍

neil-marcellini

Finally good to go

github-actions · 2025-06-09T16:55:03Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.1.63-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-10T22:41:19Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.63-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Updating several articles in the Reports & Expenses category to optim…

701becc

…ize and reflect navigation changes https://github.com/Expensify/Expensify/issues/482861

maddylewis self-assigned this Jun 2, 2025

maddylewis requested a review from a team as a code owner June 2, 2025 19:05

maddylewis added this to [#whatsnext] #convert Jun 2, 2025

melvin-bot Bot requested review from alexpensify and neil-marcellini June 2, 2025 19:06

melvin-bot Bot removed the request for review from a team June 2, 2025 19:06

maddylewis removed the request for review from alexpensify June 2, 2025 19:07

maddylewis added 11 commits June 2, 2025 15:30

Update Adding-Attendees.md

fd8e339

Update Approve-expenses.md

93a6d4f

Update and rename Create-Per-Diem-expenses.md to Per-Diem-Expenses.md

8109822

Update and rename Create-an-expense.md to Create-an-Expense.md

23099ef

Update Create-an-Expense.md

b1724d3

Update Delete-Expenses.md

8abe60e

Update Distance-Requests.md

32af170

Update and rename Duplicate-detection.md to Duplicate-Detection.md

8edff8f

Update Getting-Started-with-the-Reports-Page.md

a774c52

Update redirects.csv

dad7c5b

Rename Approve-expenses.md to Approve-Expenses.md

f12dcaa

maddylewis changed the title ~~[HOLD] [NO QA] Updating several articles in the Reports & Expenses category to optim…~~ [NO QA] Updating several articles in the Reports & Expenses category to optim… Jun 2, 2025

neil-marcellini reviewed Jun 2, 2025

View reviewed changes

Comment thread docs/articles/new-expensify/reports-and-expenses/Approve-Expenses.md Outdated

Update Approve-Expenses.md

fd690c3

This comment was marked as resolved.

Sign in to view

Merge branch 'main' into maddylewis-patch-3

b78d57c

maddylewis mentioned this pull request Jun 3, 2025

[NO QA] Updating several resources in the Expensify Card category of the help… #63359

Merged

58 tasks

neil-marcellini requested changes Jun 3, 2025

View reviewed changes

Update Create-an-Expense.md

a31ab46

maddylewis added 8 commits June 4, 2025 11:29

Update Delete-Expenses.md

8998a2b

Update Duplicate-Detection.md

867bea6

Update Getting-Started-with-the-Reports-Page.md

9c9cb1d

Update Getting-Started-with-the-Reports-Page.md

f2504fe

Update Getting-Started-with-the-Reports-Page.md

7119463

Update and rename Distance-Requests.md to Distance-Expenses.md

db84947

Update Per-Diem-Expenses.md

42f72b4

Update redirects.csv

efde333

maddylewis requested a review from neil-marcellini June 5, 2025 01:21

neil-marcellini requested changes Jun 5, 2025

View reviewed changes

maddylewis added 4 commits June 5, 2025 14:48

Update redirects.csv

ad6e783

Update Create-an-Expense.md

7655db9

Update Distance-Expenses.md

2538f7b

Merge branch 'main' into maddylewis-patch-3

91f10d6

Update redirects.csv

26d57cd

maddylewis added 2 commits June 6, 2025 15:20

Update Approve-Expenses.md

1b66079

Update Approve-Expenses.md

cab3dd7

neil-marcellini approved these changes Jun 6, 2025

View reviewed changes

neil-marcellini merged commit 49e07cc into main Jun 6, 2025
13 of 15 checks passed

neil-marcellini deleted the maddylewis-patch-3 branch June 6, 2025 20:04

github-project-automation Bot moved this to Done in [#whatsnext] #convert Jun 6, 2025

github-actions Bot mentioned this pull request Jun 9, 2025

Deploy Checklist: New Expensify 2025-06-09 #63762

Closed

77 tasks

		@@ -26,7 +26,7 @@ To submit a mileage-based expense:
		- (Optional) Add a description, category, or tag

Uh oh!

Conversation

maddylewis commented Jun 2, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videosundefined

Uh oh!

melvin-bot Bot commented Jun 2, 2025 • edited by maddylewis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Concierge reviewer checklist:

Uh oh!

melvin-bot Bot commented Jun 2, 2025

Uh oh!

OSBotify commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as resolved.

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

neil-marcellini Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maddylewis commented Jun 4, 2025

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

maddylewis commented Jun 6, 2025

Uh oh!

maddylewis commented Jun 6, 2025

Uh oh!

maddylewis commented Jun 6, 2025

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 9, 2025

Uh oh!

github-actions Bot commented Jun 10, 2025

Uh oh!

maddylewis commented Jun 2, 2025 •

edited by github-actions Bot

Loading

melvin-bot Bot commented Jun 2, 2025 •

edited by maddylewis

Loading

OSBotify commented Jun 2, 2025 •

edited

Loading

neil-marcellini Jun 3, 2025 •

edited

Loading