Skip to content

Do not open Test Drive modal for accessible policy joiners #63199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blimpich merged 3 commits into from
Jun 2, 2025
Merged

Do not open Test Drive modal for accessible policy joiners #63199

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b14e91
Do not open Test Drive modal for accessible policy joiners
marcaaron May 30, 2025
0d69f30
Merge branch 'main' into marcaaron-preventTestDriveModalForAccessible…
marcaaron May 30, 2025
5a7a426
Merge branch 'main' into marcaaron-preventTestDriveModalForAccessible…
marcaaron May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/libs/navigateAfterOnboarding.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ const navigateAfterOnboarding = (
Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(reportID));
}

// In this case, we have joined an accessible policy. We would have an onboarding policy, but not an admins chat report.
// We should skip the Test Drive modal in this case since we already have a policy to join.
if (onboardingPolicyID && !onboardingAdminsChatReportID) {
return;
}

// We're using Navigation.isNavigationReady here because without it, on iOS,
// Navigation.dismissModal runs after Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route)
// And dismisses the modal before it even shows
Expand Down