Improve HybridApp initialProps by war-in · Pull Request #61912 · Expensify/App

war-in · 2025-05-13T14:15:01Z

Explanation of Change

This PR moves the HybridApp sign-in logic from InitialURLContextProvider to a separate component.
We also no longer send url updates (deeplinks, shortcuts) in the App initial properties but use React Native Linking module to do so. That way, we can simplify an OD patch and split the logic

Fixed Issues

$ #62857
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13568

Tests

Open app and sign-in
Switch between experiences
Check if shortcuts work fine

Offline tests

QA Steps

Open app and sign-in
Switch between experiences
Check if shortcuts work fine

PR Author Checklist

Screenshots/Videos

Android: Native

init.prosp.-.android.mov

Android: mWeb Chrome

init.props.-.android.web.mov

iOS: Native

ios.native.mov

iOS: mWeb Safari

ios.web.mov

MacOS: Chrome / Safari

init.props.-.web.mov

MacOS: Desktop

init.props.-.desktop.mov

289Adam289

Very nice changes

mateuuszzzzz · 2025-05-21T11:12:26Z

+        return null;
+    }
+
+    signInAfterTransitionFromOldDot(hybridAppSettings).then(() => {


Hmmm this could be kept in useEffect as well

I'm not so sure because I remember that sometimes url so as hybridAppSettings were undefined (early in the app initialization) and it's safer to make this code rerunable

mateuuszzzzz · 2025-05-21T11:16:33Z

+    });
+}
+
+function HybridAppSignIn({url, hybridAppSettings}: AppProps) {


What about different name? It also has a listener that triggers on every url event.

What about HybridAppUrlHandler or HybridAppRouter?

Btw maybe we should perform an early-return in useEffect to make sure that we don't use it on Standalone NewDot

We won't use it on standalone ND because we keep it behind CONFIG.IS_HYBRID_APP in App.tsx

melvin-bot · 2025-05-27T14:36:30Z

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2025-05-27T16:48:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Uploading Screen Recording 2025-05-29 at 12.20.47 PM.mov…

Android: mWeb Chrome

Screen.Recording.2025-05-29.at.12.20.12.PM.mov

iOS: HybridApp

Screen.Recording.2025-05-29.at.12.16.07.PM.mov

Screen.Recording.2025-05-29.at.12.18.07.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-05-29.at.12.19.36.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-29.at.12.10.12.PM.mov

MacOS: Desktop

Screen.Recording.2025-05-29.at.12.10.55.PM.mov

allgandalf · 2025-05-27T17:38:02Z

@war-in this is my first time working on PR which refers to mobile-expensify repo as well!,

Are the testing steps different for this PR?

do i need to checkout to https://github.com/Expensify/Mobile-Expensify/pull/13568 in the mobile-expensify sub-folder and checkout to this PR in the App repo?

A brief overview for testing would also help 😄

mjasikowski

Other than the displayName oopsie that @allgandalf has found, it looks great!

war-in · 2025-05-28T08:45:27Z

do i need to checkout to https://github.com/Expensify/Mobile-Expensify/pull/13568 in the mobile-expensify sub-folder and checkout to this PR in the App repo?

@allgandalf Yes! You should checkout the submodule too and then just follow the testing steps

Open app and sign-in

Switch between experiences

Check if shortcuts work fine

when I wrote Switch between experiences I meant clicking on Try New Expensify in OD and Switch to Expensify Classic in ND buttons.
Also to test shortcuts just long-press on the app icon (please see videos in the PR description 🙏 )

OSBotify · 2025-05-29T12:11:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-29T16:42:14Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.1.54-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-02T19:29:19Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.54-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

war-in added 2 commits May 13, 2025 16:14

don't update initialProps, use Linking

46b0721

fix lint

c17400a

289Adam289 reviewed May 13, 2025

View reviewed changes

Comment thread src/HybridAppSignIn.tsx

289Adam289 approved these changes May 13, 2025

View reviewed changes

war-in added 4 commits May 20, 2025 11:21

Merge branch 'refs/heads/main' into war-in/improve-initial-params

72d9ede

remove url listener when component unmounts

15c20d7

Merge branch 'refs/heads/main' into war-in/improve-initial-params

a73b027

fix prettier

c6e4ade

mateuuszzzzz reviewed May 21, 2025

View reviewed changes

mateuuszzzzz reviewed May 22, 2025

View reviewed changes

Comment thread src/Expensify.tsx

apply review suggestions

d23625d

mountiny requested a review from allgandalf May 27, 2025 14:19

mountiny assigned war-in May 27, 2025

war-in added 2 commits May 27, 2025 16:22

Merge branch 'refs/heads/main' into war-in/improve-initial-params

89b02ea

fix lint & prettier

c80a4a2

war-in marked this pull request as ready for review May 27, 2025 14:36

war-in requested a review from a team as a code owner May 27, 2025 14:36

melvin-bot Bot requested review from mjasikowski and removed request for a team May 27, 2025 14:36

allgandalf suggested changes May 27, 2025

View reviewed changes

Comment thread src/HybridAppHandler.tsx Outdated

mjasikowski previously approved these changes May 28, 2025

View reviewed changes

fix displayName

66576f7

war-in dismissed mjasikowski’s stale review via 66576f7 May 28, 2025 08:55

mjasikowski approved these changes May 28, 2025

View reviewed changes

allgandalf approved these changes May 29, 2025

View reviewed changes

melvin-bot Bot requested a review from mjasikowski May 29, 2025 06:51

mjasikowski approved these changes May 29, 2025

View reviewed changes

mjasikowski merged commit e04a010 into Expensify:main May 29, 2025
17 of 19 checks passed

github-actions Bot mentioned this pull request May 29, 2025

Deploy Checklist: New Expensify 2025-05-29 #63061

Closed

89 tasks

jponikarchuk mentioned this pull request May 30, 2025

[Due for payment 2025-06-11] [Due for payment 2025-06-09] Shortcut - Inbox opens instead of Create expense flow when launching app via shortcut #63141

Closed

8 tasks

war-in mentioned this pull request May 30, 2025

[CP staging] Revert "Improve HybridApp initialProps" #63166

Merged

49 tasks

melvin-bot Bot mentioned this pull request Jun 2, 2025

[Due for payment 2025-07-10] [Due for payment 2025-06-18] [Due for payment 2025-06-09] [$250] Improve the initialProps implementation #62857

Closed

Uh oh!

Conversation

war-in commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

289Adam289 left a comment

Choose a reason for hiding this comment

Uh oh!

mateuuszzzzz May 21, 2025

Choose a reason for hiding this comment

Uh oh!

war-in May 22, 2025

Choose a reason for hiding this comment

Uh oh!

mateuuszzzzz May 21, 2025

Choose a reason for hiding this comment

Uh oh!

war-in May 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot Bot commented May 27, 2025

Uh oh!

allgandalf commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

allgandalf commented May 27, 2025

Uh oh!

mjasikowski left a comment

Choose a reason for hiding this comment

Uh oh!

war-in commented May 28, 2025

Uh oh!

Uh oh!

OSBotify commented May 29, 2025

Uh oh!

github-actions Bot commented May 29, 2025

Uh oh!

github-actions Bot commented Jun 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

war-in commented May 13, 2025 •

edited

Loading

allgandalf commented May 27, 2025 •

edited

Loading