Skip to content

Fix: Misaligned Arrow Icons in Trip Summary #61901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rafecolton merged 9 commits into from
Jun 10, 2025
Merged

Fix: Misaligned Arrow Icons in Trip Summary #61901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fccc405
update style of preview
twilight2294 May 13, 2025
87784d4
include new style for travel preview
twilight2294 May 13, 2025
2c72d8d
use tripReservationRow
twilight2294 May 14, 2025
9304d89
update style to increase startName and arrow width to 50%
twilight2294 May 14, 2025
2d6458a
Update src/styles/index.ts
twilight2294 May 15, 2025
953924b
Merge branch 'Expensify:main' into patch-37
twilight2294 May 22, 2025
4aaeb85
Merge branch 'Expensify:main' into patch-37
twilight2294 Jun 10, 2025
846ebcb
Fix mobile view for trip preview
twilight2294 Jun 10, 2025
d02325e
remove extra styles
twilight2294 Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 29 additions & 9 deletions src/components/ReportActionItem/TripRoomPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,35 @@ function ReservationView({reservation, onPress}: ReservationViewProps) {
const endName = reservation.type === CONST.RESERVATION_TYPE.FLIGHT ? reservation.end.shortName : reservation.end.longName;

titleComponent = (
<View style={[styles.flexRow, styles.alignItemsCenter, styles.gap2]}>
<Text style={[styles.labelStrong, styles.flexShrink1]}>{startName}</Text>
<Icon
src={Expensicons.ArrowRightLong}
width={variables.iconSizeSmall}
height={variables.iconSizeSmall}
fill={theme.icon}
/>
<Text style={[styles.labelStrong, styles.flexShrink1]}>{endName}</Text>
<View style={[styles.flexRow, styles.alignItemsStart]}>
<View style={styles.tripReservationRow}>
<View style={styles.flexShrink1}>
<Text
numberOfLines={2}
style={[styles.labelStrong, styles.mr2]}
ellipsizeMode="tail"
>
{startName}
</Text>
</View>
<View style={styles.iconWrapper}>
<Icon
src={Expensicons.ArrowRightLong}
width={variables.iconSizeSmall}
height={variables.iconSizeSmall}
fill={theme.icon}
/>
</View>
</View>
<View style={[styles.flex1, styles.ml2]}>
<Text
numberOfLines={2}
style={[styles.labelStrong]}
ellipsizeMode="tail"
>
{endName}
</Text>
</View>
</View>
);
}
Expand Down
14 changes: 14 additions & 0 deletions src/styles/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5624,6 +5624,20 @@ const styles = (theme: ThemeColors) =>
justifyContent: 'center',
},

tripReservationRow: {
flexDirection: 'row',
alignItems: 'center',
maxWidth: '50%',
flexShrink: 1,
},

iconWrapper: {
justifyContent: 'center',
alignItems: 'center',
alignSelf: 'flex-start', // Keeps icon from dropping below
paddingTop: 2, // Adjust slightly for vertical centering
},

textLineThrough: {
textDecorationLine: 'line-through',
},
Expand Down