Skip to content

Fix: remove extra header gap on Reports page for Desktop #59700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikarparsi merged 1 commit into from
Apr 11, 2025
Merged

Fix: remove extra header gap on Reports page for Desktop #59700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/pages/Search/SearchMoneyRequestReportPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import {View} from 'react-native';
import {useOnyx} from 'react-native-onyx';
import FullPageNotFoundView from '@components/BlockingViews/FullPageNotFoundView';
import DragAndDropProvider from '@components/DragAndDrop/Provider';
import HeaderGap from '@components/HeaderGap';
import MoneyRequestReportView from '@components/MoneyRequestReportView/MoneyRequestReportView';
import BottomTabBar from '@components/Navigation/BottomTabBar';
import BOTTOM_TABS from '@components/Navigation/BottomTabBar/BOTTOM_TABS';
Expand All @@ -22,8 +21,8 @@ import {isValidReportIDFromPath} from '@libs/ReportUtils';
import Navigation from '@navigation/Navigation';
import {openReport} from '@userActions/Report';
import ONYXKEYS from '@src/ONYXKEYS';
import {ActionListContext, ReactionListContext} from '@src/pages/home/ReportScreenContext';
import type {ActionListContextType, ReactionListRef, ScrollPosition} from '@src/pages/home/ReportScreenContext';
import {ActionListContext, ReactionListContext} from '@src/pages/home/ReportScreenContext';
import type SCREENS from '@src/SCREENS';
import SearchTypeMenu from './SearchTypeMenu';

Expand Down Expand Up @@ -123,7 +122,6 @@ function SearchMoneyRequestReportPage({route}: SearchMoneyRequestPageProps) {
<View style={styles.searchSplitContainer}>
<View style={styles.searchSidebar}>
<View style={styles.flex1}>
<HeaderGap />
<TopBar
breadcrumbLabel={translate('common.reports')}
shouldDisplaySearch={false}
Expand Down
4 changes: 1 addition & 3 deletions src/pages/Search/SearchPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import FullPageNotFoundView from '@components/BlockingViews/FullPageNotFoundView
import type {DropdownOption} from '@components/ButtonWithDropdownMenu/types';
import ConfirmModal from '@components/ConfirmModal';
import DecisionModal from '@components/DecisionModal';
import HeaderGap from '@components/HeaderGap';
import HeaderWithBackButton from '@components/HeaderWithBackButton';
import * as Expensicons from '@components/Icon/Expensicons';
import BottomTabBar from '@components/Navigation/BottomTabBar';
Expand All @@ -14,8 +13,8 @@ import TopBar from '@components/Navigation/TopBar';
import ScreenWrapper from '@components/ScreenWrapper';
import Search from '@components/Search';
import {useSearchContext} from '@components/Search/SearchContext';
import SearchPageHeader from '@components/Search/SearchPageHeader/SearchPageHeader';
import type {SearchHeaderOptionValue} from '@components/Search/SearchPageHeader/SearchPageHeader';
import SearchPageHeader from '@components/Search/SearchPageHeader/SearchPageHeader';
import SearchStatusBar from '@components/Search/SearchPageHeader/SearchStatusBar';
import type {PaymentData} from '@components/Search/types';
import useActiveWorkspace from '@hooks/useActiveWorkspace';
Expand Down Expand Up @@ -399,7 +398,6 @@ function SearchPage({route}: SearchPageProps) {
<View style={styles.searchSidebar}>
{queryJSON ? (
<View style={styles.flex1}>
<HeaderGap />
<TopBar
activeWorkspaceID={policyID}
breadcrumbLabel={translate('common.reports')}
Expand Down