Skip to content

[No QA] Only leave comment if it's not already there #59634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewGable merged 2 commits into from
Apr 8, 2025
Merged

[No QA] Only leave comment if it's not already there #59634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
706b0e8
Only leave comment if it's not already there
roryabraham Apr 3, 2025
ccbb8da
Make more readable with an intermediary variable
roryabraham Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions .github/workflows/verifyHybridApp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,25 @@ jobs:
steps:
- name: Comment on forks
run: |
gh pr comment ${{github.event.pull_request.html_url }} --body \
":warning: This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. :warning:"
PR_URL="${{ github.event.pull_request.html_url }}"
COMMENT=":warning: This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. \
Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. \
Ask Contributor Plus for help if you are not sure how to handle this. :warning:"

# Fetch existing comments from author github-actions
EXISTING_COMMENTS="$(\
gh pr view "$PR_URL" \
--comments \
--json comments \
--jq '.comments[] | select(.author = "github-actions") | .body' \
)"

# Leave the comment only if it's not already present
if grep -q "$COMMENT" <(echo "$EXISTING_COMMENTS"); then
echo "Comment already exists, not posting again."
else
gh pr comment "$PR_URL" --body "$COMMENT"
fi
env:
GITHUB_TOKEN: ${{ github.token }}
verify_android:
Expand Down