[Manager McTest] Tooltip Centered Incorrectly - Fix by JKobrynski · Pull Request #59609 · Expensify/App

JKobrynski · 2025-04-03T18:18:22Z

Explanation of Change

Tooltip position on small screen was wrong because the calculation was wrong. To make sure the tooltip position is right after resize I created a useIsResizing hook to track when user is resizing the window. I used this hook to hide the tooltip when user starts resizing the window, and rerender it when the resize is finished.

Fixed Issues

$ #58657
PROPOSAL: N/A

Tests

Log into the app using a fresh account (to see the onboarding tooltips)
Click on the FAB and select 'Create expense'
You should see a tooltip saying "Want to see how Scan works? Try a test Receipt!"
Resize the browser window
Verify the tooltip disappears as soon as you start resizing and reappears in a right place when you finish resizing the window
Resize to a narrow window, so the small screen wariant renders and make sure the tooltip position is right and it doesn't overlap the text

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests section above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

web-compressed.mov

melvin-bot · 2025-04-03T18:18:35Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JKobrynski · 2025-04-07T08:42:33Z

@DylanDylann have you had a change to take a look at this? 🙏

DylanDylann · 2025-04-07T11:24:59Z

I will complete my reviewing on the early Tuesday

DylanDylann · 2025-04-08T08:03:14Z

-                            setElementTop(isSmallScreenWidth ? e.nativeEvent.layout.height + 10 : e.nativeEvent.layout.height - (variables.tabSelectorButtonHeight - 8));
+                            setElementTop(
+                                isSmallScreenWidth
+                                    ? e.nativeEvent.layout.height - (variables.tabSelectorButtonHeight - 10)


@JKobrynski Why do we need to change this line?

Because the tooltip was overlapping the text on small screens, this places is right below the buttons, exactly like on big screens 😄 you can check out the recording!

DylanDylann · 2025-04-08T08:08:34Z

Tooltip position on small screen was wrong because the calculation was wrong. To make sure the tooltip position is right after resize I created a useIsResizing hook to track when user is resizing the window. I used this hook to hide the tooltip when user starts resizing the window, and rerender it when the resize is finished.

It is a good idea. Appreciate it

Sign in to view

+        const handleResize = () => {
+            if (!isResizing) {
+                setIsResizing(true);
+            }
+            debouncedSetIsResizing();
+        };


DylanDylann · 2025-04-08T08:17:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-04-08.at.15.18.28.mov

MacOS: Desktop

Screen.Recording.2025-04-08.at.15.19.38.mov

grgia

Thank you for the speedy fixes!!

OSBotify · 2025-04-08T13:55:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-09T04:40:43Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.1.25-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-10T00:56:31Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.25-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

fix position on small screen, rerender tooltip on resize

1619eb5

JKobrynski marked this pull request as ready for review April 3, 2025 18:18

JKobrynski requested a review from a team as a code owner April 3, 2025 18:18

melvin-bot Bot requested a review from DylanDylann April 3, 2025 18:18

melvin-bot Bot removed the request for review from a team April 3, 2025 18:18

JKobrynski mentioned this pull request Apr 3, 2025

[Due for payment 2025-04-28] [Due for payment 2025-04-17] [Manager McTest] Tooltip Centered Incorrectly #58657

Closed

DylanDylann reviewed Apr 8, 2025

View reviewed changes

Comment thread src/hooks/useIsResizing/index.ts

Comment on lines +26 to +31

const handleResize = () => {

if (!isResizing) {

setIsResizing(true);

}

debouncedSetIsResizing();

};

This comment was marked as off-topic.

Sign in to view

DylanDylann approved these changes Apr 8, 2025

View reviewed changes

melvin-bot Bot requested a review from grgia April 8, 2025 08:22

grgia approved these changes Apr 8, 2025

View reviewed changes

grgia merged commit 9eb3655 into Expensify:main Apr 8, 2025

This was referenced Apr 8, 2025

[Due for payment 2025-04-23] Investigate workflow job failing on main: e2ePerformanceTests / Build apk from baseline / Build Android app #59830

Closed

Deploy Checklist: New Expensify 2025-04-09 #59866

Closed

utkershrajvenshi mentioned this pull request Apr 9, 2025

mweb - Tooltip - There is some spacing between Scan tab and scan tooltip #59881

Closed

8 tasks

bernhardoj mentioned this pull request Apr 11, 2025

Adjust tooltip yoffset when the screen is resized #59720

Closed

50 tasks

ZhenjaHorbach mentioned this pull request Apr 11, 2025

[$250] Tooptip loses position when screen is resized #55397

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Manager McTest] Tooltip Centered Incorrectly - Fix#59609

[Manager McTest] Tooltip Centered Incorrectly - Fix#59609
grgia merged 1 commit into
Expensify:mainfrom
callstack-internal:JKobrynski/fix/58657-tooltip-not-centered-correctly

JKobrynski commented Apr 3, 2025

Uh oh!

melvin-bot Bot commented Apr 3, 2025

Uh oh!

JKobrynski commented Apr 7, 2025

Uh oh!

DylanDylann commented Apr 7, 2025

Uh oh!

DylanDylann Apr 8, 2025

Uh oh!

JKobrynski Apr 8, 2025

Uh oh!

DylanDylann commented Apr 8, 2025

Uh oh!

This comment was marked as off-topic.

Uh oh!

DylanDylann commented Apr 8, 2025 •

edited

Loading

Uh oh!

grgia left a comment

Uh oh!

OSBotify commented Apr 8, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

github-actions Bot commented Apr 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

JKobrynski commented Apr 3, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 3, 2025

Uh oh!

JKobrynski commented Apr 7, 2025

Uh oh!

DylanDylann commented Apr 7, 2025

Uh oh!

DylanDylann Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

JKobrynski Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Apr 8, 2025

Uh oh!

This comment was marked as off-topic.

Uh oh!

DylanDylann commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 8, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

github-actions Bot commented Apr 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DylanDylann commented Apr 8, 2025 •

edited

Loading