Skip to content

Revert "Update settlement button condition"#55916

Merged
roryabraham merged 1 commit into
mainfrom
revert-55383-update-settlement-button-condition
Jan 29, 2025
Merged

Revert "Update settlement button condition"#55916
roryabraham merged 1 commit into
mainfrom
revert-55383-update-settlement-button-condition

Conversation

@yuwenmemon

@yuwenmemon yuwenmemon commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

Reverts #55383

No checklist needed, straight revert

@yuwenmemon
yuwenmemon requested a review from a team as a code owner January 29, 2025 01:49
@melvin-bot
melvin-bot Bot requested review from johnmlee101 and removed request for a team January 29, 2025 01:50
@melvin-bot

melvin-bot Bot commented Jan 29, 2025

Copy link
Copy Markdown

@johnmlee101 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@roryabraham
roryabraham merged commit f87d0de into main Jan 29, 2025
@roryabraham
roryabraham deleted the revert-55383-update-settlement-button-condition branch January 29, 2025 05:10
@melvin-bot

melvin-bot Bot commented Jan 29, 2025

Copy link
Copy Markdown

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Jan 29, 2025
@roryabraham

roryabraham commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

ignoring checklists for straight revert

OSBotify pushed a commit that referenced this pull request Jan 29, 2025
@roryabraham @OSBotify
Merge pull request #55916 from Expensify/revert-55383-update-settleme…
a63de3a 
…nt-button-condition

Revert "Update settlement button condition"

(cherry picked from commit f87d0de)

(CP triggered by yuwenmemon)
@github-actions github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Jan 29, 2025
This was referenced Jan 29, 2025
Closed
Closed
Closed
@OSBotify

OSBotify commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.0.90-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions

github-actions Bot commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@yuwenmemon yuwenmemon mentioned this pull request Jan 29, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roryabraham roryabraham roryabraham approved these changes
@johnmlee101 johnmlee101 Awaiting requested review from johnmlee101

Assignees

No one assigned

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuwenmemon @roryabraham @OSBotify