Remove default values from WorkspaceInitialPage by fabioh8010 · Pull Request #55475 · Expensify/App

fabioh8010 · 2025-01-20T12:12:19Z

Explanation of Change

This PR reworks WorkspaceInitialPage.tsx to remove this bypass (const policyID = ${policy?.id ?? CONST.DEFAULT_NUMBER_ID};) made to avoid ESLint errors with default values, now refactored to the correct way.

Fixed Issues

$ #55750
PROPOSAL:

Tests

Go to Settings -> Workspaces and create a new one.
Click the Workspace chat button, assert you are navigated to the Workspace chat.
Go back to the Workspace settings -> More features and enable all features available (upgrade your workspace if necessary).
For each tab in the Workspace settings page, click it and assert you are navigated to the appropriate page.

Verify that no errors appear in the JS console

Offline tests

Same as Tests, but you won't be able to upgrade the Workspace.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-22.at.17.31.23-compressed.mov

Android: mWeb Chrome

Screen.Recording.2025-01-22.at.17.36.47-compressed.mov

iOS: Native

Screen.Recording.2025-01-22.at.17.49.50-compressed.mov

iOS: mWeb Safari

Screen.Recording.2025-01-22.at.17.52.07-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-22.at.17.55.39-compressed.mov

Screen.Recording.2025-01-22.at.17.58.08-compressed.mov

MacOS: Desktop

Screen.Recording.2025-01-22.at.18.02.27-compressed.mov

…-WorkspaceInitialPage

melvin-bot · 2025-01-22T18:46:29Z

@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

paultsimura · 2025-01-22T19:52:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android.webm

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-22.at.21.12.39.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-22.at.21.19.50.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-01-22.at.20.38.56.mov

MacOS: Desktop

Screen.Recording.2025-01-22.at.20.43.58.mov

fabioh8010 · 2025-01-24T10:20:54Z

@paultsimura Ready to review again!

paultsimura

LGTM ✔️

neil-marcellini

Overall looks great. One small request

neil-marcellini · 2025-01-24T19:25:57Z

+import CONST from '@src/CONST';
+import type {ReimbursementAccountStep} from '@src/types/onyx/ReimbursementAccount';
+
+type ReimbursementAccountStepToOpen = ValueOf<typeof REIMBURSEMENT_ACCOUNT_ROUTE_NAMES> | '';


NAB: Can this be "or undefined" instead of "or empty string"?

I'm not sure if it's feasible as we specifically check of empty string in some places in ReimbursementAccountPage.tsx and we also can pass it to READ_COMMANDS.OPEN_REIMBURSEMENT_ACCOUNT_PAGE API in BankAccounts.openReimbursementAccountPage() function

…-WorkspaceInitialPage

OSBotify · 2025-01-27T17:38:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-28T02:16:19Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.90-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-29T06:24:08Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.90-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

fabioh8010 added 5 commits January 20, 2025 09:18

Fix default values in WorkspaceInitialPage

40f79b5

Extract utilities from ReimbursementAccountPage

feee807

Fix imports

a70f57f

Fix more default values

da48aa8

Unit tests for ReimbursementAccountUtils

f1e2362

VickyStash approved these changes Jan 20, 2025

View reviewed changes

kubabutkiewicz reviewed Jan 20, 2025

View reviewed changes

Comment thread src/ROUTES.ts

kubabutkiewicz approved these changes Jan 20, 2025

View reviewed changes

fabioh8010 added 4 commits January 21, 2025 08:40

Merge branch 'main' into bugfix/default-values-WorkspaceInitialPage

d1dd86d

Fix prettier

1270503

Merge remote-tracking branch 'origin/main' into bugfix/default-values…

4a93371

…-WorkspaceInitialPage

Merge remote-tracking branch 'origin/main' into bugfix/default-values…

0205934

…-WorkspaceInitialPage

fabioh8010 marked this pull request as ready for review January 22, 2025 18:46

fabioh8010 requested a review from a team as a code owner January 22, 2025 18:46

melvin-bot Bot requested a review from paultsimura January 22, 2025 18:46

melvin-bot Bot removed the request for review from a team January 22, 2025 18:46

fabioh8010 changed the title ~~[WIP] Remove default values from WorkspaceInitialPage~~ Remove default values from WorkspaceInitialPage Jan 22, 2025

paultsimura reviewed Jan 22, 2025

View reviewed changes

Comment thread src/pages/ReimbursementAccount/ConnectBankAccount/components/Enable2FACard.tsx Outdated

fabioh8010 added 2 commits January 24, 2025 10:07

Merge branch 'main' into bugfix/default-values-WorkspaceInitialPage

1ec9d1b

Remove default '' from some routes

8006ada

paultsimura approved these changes Jan 24, 2025

View reviewed changes

melvin-bot Bot requested a review from neil-marcellini January 24, 2025 12:58

Merge branch 'main' into bugfix/default-values-WorkspaceInitialPage

890b309

neil-marcellini requested changes Jan 24, 2025

View reviewed changes

fabioh8010 added 2 commits January 27, 2025 09:40

Merge branch 'main' into bugfix/default-values-WorkspaceInitialPage

2f9c8d7

Use REIMBURSEMENT_ACCOUNT_ROUTE_NAMES.NEW in places

4d8ae9d

fabioh8010 requested a review from neil-marcellini January 27, 2025 12:11

neil-marcellini previously approved these changes Jan 27, 2025

View reviewed changes

Merge remote-tracking branch 'origin/main' into bugfix/default-values…

37b3b93

…-WorkspaceInitialPage

fabioh8010 dismissed neil-marcellini’s stale review via 37b3b93 January 27, 2025 17:11

neil-marcellini approved these changes Jan 27, 2025

View reviewed changes

neil-marcellini merged commit 3507c7e into Expensify:main Jan 27, 2025

github-actions Bot mentioned this pull request Jan 28, 2025

Deploy Checklist: New Expensify 2025-01-28 #55824

Closed

82 tasks

melvin-bot Bot mentioned this pull request Jan 29, 2025

[$250] [HOLD for payment 2025-02-05] Remove default values from WorkspaceInitialPage #55750

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove default values from WorkspaceInitialPage#55475

Remove default values from WorkspaceInitialPage#55475
neil-marcellini merged 15 commits into
Expensify:mainfrom
callstack-internal:bugfix/default-values-WorkspaceInitialPage

fabioh8010 commented Jan 20, 2025 •

edited by neil-marcellini

Loading

Uh oh!

Uh oh!

melvin-bot Bot commented Jan 22, 2025

Uh oh!

Uh oh!

paultsimura commented Jan 22, 2025 •

edited

Loading

Uh oh!

fabioh8010 commented Jan 24, 2025

Uh oh!

paultsimura left a comment

Uh oh!

neil-marcellini left a comment

Uh oh!

neil-marcellini Jan 24, 2025

Uh oh!

fabioh8010 Jan 27, 2025

Uh oh!

Uh oh!

OSBotify commented Jan 27, 2025

Uh oh!

github-actions Bot commented Jan 28, 2025

Uh oh!

github-actions Bot commented Jan 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

fabioh8010 commented Jan 20, 2025 • edited by neil-marcellini Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

melvin-bot Bot commented Jan 22, 2025

Uh oh!

Uh oh!

paultsimura commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

fabioh8010 commented Jan 24, 2025

Uh oh!

paultsimura left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Jan 24, 2025

Choose a reason for hiding this comment

Uh oh!

fabioh8010 Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 27, 2025

Uh oh!

github-actions Bot commented Jan 28, 2025

Uh oh!

github-actions Bot commented Jan 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fabioh8010 commented Jan 20, 2025 •

edited by neil-marcellini

Loading

paultsimura commented Jan 22, 2025 •

edited

Loading