Add view transactions cta to Expensify card and company cards page by parasharrajat · Pull Request #55095 · Expensify/App

parasharrajat · 2025-01-10T22:11:58Z

Explanation of Change

Fixed Issues

$ #54800
PROPOSAL: #54800 (comment)

Tests

Prerequisite:

Login in NewDot with an account which has a workspace.
Enable Expensify Card and Company Card from the Settings > workspaces > [Your workspace] > Workflows.
You have some assigned cards to your account from different workspaces and a assigned company card.

Expensify Card

Go to Expensify card in workspace menu on LHN.
Issue a new Expensify Card if not already.
Click on the card to view details.
Notice the View transactions button.
Click to navigate to the search page with transactions filtered to that card.

Company Card

Go to Company card in workspace menu on LHN.
Add a new Company Card if not already.
Click on the card to view details.
Notice the View transactions button.
Click to navigate to the search page with transactions filtered to that card.

Assigned Cards

Go to Settings > Wallet page.
Click on any assigned cards(Physical or virtual).
Check that it has a View Transactions button.
Click to navigate to the search page with transactions filtered to that card.
Click on any Assigned Company card.
Note that a popup opens with the view transactions button.
Click to navigate to the search page with transactions filtered to that card.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

15.01.2025_14.13.10_REC.mp4

Android: mWeb Chrome

15.01.2025_14.19.33_REC.mp4

iOS: Native

15.01.2025_14.57.38_REC.mp4

22.01.2025_02.39.11_REC.mp4

iOS: mWeb Safari

15.01.2025_14.16.48_REC.mp4

MacOS: Chrome / Safari

15.01.2025_14.11.28_REC.mp4

22.01.2025_02.31.45_REC.mp4

MacOS: Desktop

15.01.2025_14.12.33_REC.mp4

shawnborton · 2025-01-13T07:28:47Z

+                            <MenuItem
+                                icon={Expensicons.MoneySearch}
+                                title={translate('workspace.common.viewTransactions')}
+                                style={styles.mv1}


All of these menu items should not have a gap in between them, so I think we need to remove the vertical margin here. Can you make sure all of the menu items are 64px tall with no gaps between? Screenshots would be great, thanks! cc @Expensify/design for viz

Doesn't quite look right. We want a gap of 12px below the last push row and above the block of optionRows. They should appear like two distinct sections. It's just that we want all of the option rows in the same block to not have any vertical margin.

For the option rows on your second screenshot, why do some have a green icon and others a gray icon? I think we want them all to be gray.

I just noticed that the color of icons is different for update card cta. Normally these links will be green on hovering(active state). What should the color be here on default state?

Default state would be gray, but then they are green on hover:

Lovely, thanks!

melvin-bot · 2025-01-15T09:29:30Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2025-01-15T09:31:23Z

            planType: 'Tipo de plan',
            submitExpense: 'Envíe los gastos utilizando el chat de su espacio de trabajo:',
            defaultCategory: 'Categoría predeterminada',
+            viewTransactions: 'Ver transacciones',


Did we confirm this translation ?

allgandalf · 2025-01-15T09:31:51Z

-    const queryString = policyID
-        ? `type:${type} status:${Array.isArray(status) ? status.join(',') : status} policyID:${policyID}`
-        : `type:${type} status:${Array.isArray(status) ? status.join(',') : status}`;
+    let queryString = `type:${type} status:${Array.isArray(status) ? status.join(',') : status}`;


did you try to mock some transaction data and see if we get the search results ?

This is the same as before. I haven't tested this part. Did you notice any issues?

allgandalf · 2025-01-15T09:33:08Z

Also please fix failing tests

…ewtransactions

mountiny · 2025-01-15T10:19:22Z

Seems like there is still some feedback to address here

shawnborton · 2025-01-15T10:20:30Z

I think the design feedback has been taken care of, so we're good there. We can also run a test build when we are close to merge to make sure it's looking good.

parasharrajat · 2025-01-15T10:26:54Z

I have made all requested changes and retested.

github-actions · 2025-01-15T12:20:47Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

allgandalf · 2025-01-15T16:34:50Z

almost done with testing, gonna mock some onyx data for card transactions and then approve this one

shawnborton · 2025-01-15T17:14:33Z

I wonder if this should also be added to Settings > Wallet > Card details?

That would make sense to me but I don't feel strongly.

parasharrajat · 2025-01-15T17:23:42Z

One thing worth mentioning is that the card filter does not work for the cards that are owned by someone else. Even though I can see the card in my list when I the admin of a workspace but the search page does not show card filters for it.

dannymcclain · 2025-01-15T17:29:24Z

I wonder if this should also be added to Settings > Wallet > Card details?
That would make sense to me but I don't feel strongly.

I don't feel strongly either but agree it would make sense. Can't think of a reason not to add it here other than it's more work.

mountiny · 2025-01-15T17:37:59Z

I wonder if this should also be added to Settings > Wallet > Card details?

Yes I think we should

parasharrajat · 2025-01-20T18:42:06Z

Changes done. Its ready.

shawnborton · 2025-01-20T19:26:20Z

Nice, let us know when we have updated screenshots/videos to review as well. We need them from Workspace Editor as well as Wallet > Cards

parasharrajat · 2025-01-21T09:50:13Z

@allgandalf This is ready for testing.

parasharrajat · 2025-01-21T18:58:40Z

I will share screenshots shortly. @allgandalf Can you please start testing this in the meantime?

parasharrajat · 2025-01-21T18:59:17Z

Closed mistakenly...

github-actions · 2025-01-21T20:36:12Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2025-01-21T21:00:40Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55095/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/55095/NewExpensify.dmg	https://55095.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

parasharrajat · 2025-01-21T21:10:58Z

Vids for web and native for wallet page. Others are attached to OP. cc: @shawnborton

22.01.2025_02.39.11_REC.mp4

22.01.2025_02.31.45_REC.mp4

…ewtransactions

mountiny · 2025-01-21T22:40:17Z

Seems to test well for me!

Screen.Recording.2025-01-21.at.23.38.29.mp4

mountiny · 2025-01-21T22:40:31Z

@allgandalf how is it looking?

shawnborton · 2025-01-22T05:52:04Z

Looks great!

allgandalf · 2025-01-22T06:24:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-22.at.12.40.12.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-01-22.at.12.42.16.PM.mov

iOS: Native

Screen.Recording.2025-01-22.at.12.31.27.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-01-22.at.12.33.03.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-22.at.12.19.57.PM.mov

MacOS: Desktop

Screen.Recording.2025-01-22.at.12.24.07.PM.mov

allgandalf

Code LGTM and tests well

mountiny · 2025-01-22T17:53:50Z

@parasharrajat can you please resolve the conflicts

…ewtransactions

parasharrajat · 2025-01-22T18:04:01Z

@mountiny Done,.

mountiny

Thanks @parasharrajat

OSBotify · 2025-01-22T19:35:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-23T18:27:44Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-28T01:51:08Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

ZhenjaHorbach · 2025-03-13T22:38:09Z

                        description: getDescriptionForPolicyDomainCard(card.domainName),
-                        shouldShowRightIcon: false,
-                        interactive: false,
+                        interactive: true,


Came from this issue
Interaction should be disabled when we delete a card in offline mode

alitoshmatov · 2025-04-02T15:02:01Z

+                        }}
+                        anchorRef={paymentMethodButtonRef as RefObject<View>}
+                    >
+                        <View style={[styles.mv5, !shouldUseNarrowLayout ? styles.sidebarPopover : {}]}>


Styles are little bit off, showing to much space at the bottom. #57774

Add view transactions cta to Expnesify card and company cards page

cc64293

parasharrajat mentioned this pull request Jan 10, 2025

[HOLD for payment 2025-02-04] [$250] Improvement: Add Deep Link to Search for Transactions from Card Details Page #54800

Closed

8 tasks

parasharrajat changed the title ~~Add view transactions cta to Expnesify card and company cards page~~ Add view transactions cta to Expensify card and company cards page Jan 12, 2025

Use default

e474137

shawnborton reviewed Jan 13, 2025

View reviewed changes

mountiny self-requested a review January 13, 2025 13:47

mountiny assigned parasharrajat Jan 13, 2025

Update margins on rows

936ddc7

parasharrajat marked this pull request as ready for review January 15, 2025 09:29

parasharrajat requested a review from a team as a code owner January 15, 2025 09:29

melvin-bot Bot requested review from allgandalf and removed request for a team January 15, 2025 09:29

allgandalf reviewed Jan 15, 2025

View reviewed changes

parasharrajat added 3 commits January 15, 2025 15:12

Merge branch 'main' of github.com:Expensify/App into parasharrajat/vi…

4bda948

…ewtransactions

Fix Linting

0f925fb

spacing fix

2b5511c

mountiny added the Ready To Build label Jan 15, 2025

This comment has been minimized.

Sign in to view

parasharrajat requested a review from allgandalf January 20, 2025 18:41

parasharrajat closed this Jan 21, 2025

parasharrajat reopened this Jan 21, 2025

Merge branch 'main' of github.com:Expensify/App into parasharrajat/vi…

bbb8385

…ewtransactions

shawnborton previously approved these changes Jan 22, 2025

View reviewed changes

allgandalf approved these changes Jan 22, 2025

View reviewed changes

Merge branch 'main' of github.com:Expensify/App into parasharrajat/vi…

3238b9b

…ewtransactions

parasharrajat dismissed shawnborton’s stale review via 3238b9b January 22, 2025 18:01

mountiny approved these changes Jan 22, 2025

View reviewed changes

mountiny merged commit 4dc7c7a into Expensify:main Jan 22, 2025

github-actions Bot mentioned this pull request Jan 23, 2025

Deploy Checklist: New Expensify 2025-01-23 #55657

Closed

ZhenjaHorbach reviewed Mar 13, 2025

View reviewed changes

alitoshmatov reviewed Apr 2, 2025

View reviewed changes

Uh oh!

Conversation

parasharrajat commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Expensify Card

Company Card

Assigned Cards

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jan 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allgandalf commented Jan 15, 2025

Uh oh!

mountiny commented Jan 15, 2025

Uh oh!

shawnborton commented Jan 15, 2025

Uh oh!

parasharrajat commented Jan 15, 2025

Uh oh!

github-actions Bot commented Jan 15, 2025

Uh oh!

This comment has been minimized.

allgandalf commented Jan 15, 2025

Uh oh!

shawnborton commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Jan 15, 2025

Uh oh!

dannymcclain commented Jan 15, 2025

Uh oh!

mountiny commented Jan 15, 2025

Uh oh!

parasharrajat commented Jan 20, 2025

Uh oh!

shawnborton commented Jan 20, 2025

Uh oh!

parasharrajat commented Jan 21, 2025

Uh oh!

parasharrajat commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Jan 21, 2025

Uh oh!

github-actions Bot commented Jan 21, 2025

Uh oh!

parasharrajat commented Jan 10, 2025 •

edited

Loading

parasharrajat Jan 15, 2025 •

edited

Loading

parasharrajat Jan 15, 2025 •

edited

Loading

shawnborton commented Jan 15, 2025 •

edited

Loading

parasharrajat commented Jan 21, 2025 •

edited

Loading

parasharrajat commented Jan 21, 2025 •

edited

Loading

allgandalf commented Jan 22, 2025 •

edited

Loading

ZhenjaHorbach Mar 13, 2025 •

edited

Loading