Fix - Update the Group Creation flow by FitseTLT · Pull Request #55030 · Expensify/App

FitseTLT · 2025-01-09T20:33:51Z

Details

Fixed Issues

$ #54460
PROPOSAL: #54460 (comment)

Tests

Tap on the global FAB
Press start chat
Add a user to the group by pressing add to group button
Verify that on pressing on a user item outside the add to group button it will add/remove the user to/from the group instead of creating a chat with that user as long as there is a user selected.
After deselecting all users and verify pressing on the user will create/open a chat with the user

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

a.mp4

Android: mWeb Chrome

aw.mp4

iOS: Native

i.mp4

iOS: mWeb Safari

iw.mp4

MacOS: Chrome / Safari

w.mp4

MacOS: Desktop

2025-01-09.23-31-32.mp4

melvin-bot · 2025-01-09T20:33:56Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193

All good. I left 2 small comments.

hungvu193 · 2025-01-10T13:34:52Z

LGTM so far. I'll take more tests before approving

hungvu193 · 2025-01-11T16:49:59Z

@FitseTLT We have conflicts, please resolve it 😄

hungvu193 · 2025-01-13T10:00:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-13.at.16.59.45.mov

Android: mWeb Chrome

Screen.Recording.2025-01-12.at.00.09.08.mov

iOS: Native

Screen.Recording.2025-01-12.at.00.02.15.mov

iOS: mWeb Safari

Screen.Recording.2025-01-11.at.23.47.32.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-11.at.23.29.36.mov

MacOS: Desktop

Screen.Recording.2025-01-11.at.23.30.51.mov

hungvu193 · 2025-01-14T07:24:20Z

little bump @FitseTLT

FitseTLT · 2025-01-14T12:36:46Z

Conflict resolved. @hungvu193 @mountiny I have implemented filtering out self dm if there is a participant already selected please confirm that it is an expected behaviour.

hungvu193 · 2025-01-15T02:56:46Z

Conflict resolved. @hungvu193 @mountiny I have implemented filtering out self dm if there is a participant already selected please confirm that it is an expected behaviour.

I think that makes sense to me. But curious what's your thought? @mountiny

hungvu193 · 2025-01-17T07:00:23Z

little bump @mountiny

mountiny

@FitseTLT Thanks, small changes requested - sorry for the delay

hungvu193 · 2025-01-20T08:23:38Z

Can you address these comments above today? @FitseTLT

FitseTLT · 2025-01-20T11:50:12Z

Can you address these comments above today? @FitseTLT

Yep Updated @mountiny

mountiny

Thanks!

OSBotify · 2025-01-21T23:09:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-23T18:27:41Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

hungvu193 · 2025-01-27T14:42:47Z

+            if (isOptionInList) {
+                newSelectedOptions = reject(selectedOptions, (selectedOption) => selectedOption.login === option.login);
+            } else {
+                newSelectedOptions = [...selectedOptions, {...option, isSelected: true, selected: true, reportID: option.reportID ?? `${CONST.DEFAULT_NUMBER_ID}`}];


@FitseTLT Please note that we shouldn't use ${CONST.DEFAULT_NUMBER_ID} to by pass the lint, it still violates the the lint rule.

https://expensify.slack.com/archives/C01GTK53T8Q/p1737913879440099

BTW I did not make that change I only moved the function.

That's weird. I saw it came from this commit: ef09dba

Do you know which added that? We should remind them.

github-actions · 2025-01-28T01:51:05Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

FitseTLT added 3 commits January 8, 2025 19:11

update group chat creation

9bf59e7

filter out self dm on group creation flow

75d700d

Merge branch 'main' into fix-enhance-group-creation-flow

9e68afc

FitseTLT requested a review from a team as a code owner January 9, 2025 20:33

melvin-bot Bot requested a review from hungvu193 January 9, 2025 20:33

melvin-bot Bot removed the request for review from a team January 9, 2025 20:33

fix lint

79b0534

hungvu193 reviewed Jan 10, 2025

View reviewed changes

Comment thread src/libs/ReportUtils.ts Outdated

Comment thread src/pages/NewChatPage.tsx Outdated

FitseTLT added 3 commits January 10, 2025 15:52

Merge branch 'main' into fix-enhance-group-creation-flow

25e1d32

change to useCallback

6df9e9b

fix ts error

ef09dba

FitseTLT requested a review from hungvu193 January 10, 2025 13:05

FitseTLT added 2 commits January 14, 2025 15:16

Merge branch 'main' into fix-enhance-group-creation-flow

ceecfc6

fix lint

e5de3ad

hungvu193 approved these changes Jan 15, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny January 15, 2025 02:57

mountiny requested changes Jan 17, 2025

View reviewed changes

Comment thread src/pages/NewChatPage.tsx

Comment thread src/pages/NewChatPage.tsx Outdated

Comment thread src/pages/NewChatPage.tsx Outdated

mountiny assigned FitseTLT Jan 17, 2025

minor update

444384d

mountiny approved these changes Jan 21, 2025

View reviewed changes

mountiny merged commit f953361 into Expensify:main Jan 21, 2025

github-actions Bot mentioned this pull request Jan 23, 2025

Deploy Checklist: New Expensify 2025-01-23 #55657

Closed

hungvu193 reviewed Jan 27, 2025

View reviewed changes

melvin-bot Bot mentioned this pull request Jan 28, 2025

[HOLD for payment 2025-02-04] [$250] Update the Group Creation flow #54460

Closed

Uh oh!

Conversation

FitseTLT commented Jan 9, 2025

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 9, 2025

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hungvu193 commented Jan 10, 2025

Uh oh!

hungvu193 commented Jan 11, 2025

Uh oh!

hungvu193 commented Jan 13, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 commented Jan 14, 2025

Uh oh!

FitseTLT commented Jan 14, 2025

Uh oh!

hungvu193 commented Jan 15, 2025

Uh oh!

hungvu193 commented Jan 17, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hungvu193 commented Jan 20, 2025

Uh oh!

FitseTLT commented Jan 20, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 21, 2025

Uh oh!

github-actions Bot commented Jan 23, 2025

Uh oh!

hungvu193 Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

FitseTLT Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

hungvu193 Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants