Fix the start group button moves up by nkdengineer · Pull Request #55020 · Expensify/App

nkdengineer · 2025-01-09T17:27:10Z

Explanation of Change

Fix the start group button moves up

Fixed Issues

$ #54975
PROPOSAL: #54975 (comment)

Tests

Go to FAB > Start chat
Add some users to the group
While the keyboard is opened, click on the Next button
Verify that the start group button doesn't move up

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Go to FAB > Start chat
Add some users to the group
While the keyboard is opened, click on the Next button
Verify that the start group button doesn't move up

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-10.at.00.14.32.mov

Android: mWeb Chrome

Screen.Recording.2025-01-10.at.00.16.56.mov

iOS: Native

Screen.Recording.2025-01-10.at.00.15.06.mov

iOS: mWeb Safari

Screen.Recording.2025-01-10.at.00.16.02.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-10.at.00.17.48.mov

MacOS: Desktop

Screen.Recording.2025-01-10.at.00.20.03.mov

melvin-bot · 2025-01-09T17:28:25Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2025-01-09T17:36:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

s77rt · 2025-01-09T17:38:49Z

Failing lint is unrelated

tgolen

Even though the Lint errors are unrelated, can you please fix them in this PR? Thanks!

nkdengineer · 2025-01-09T18:07:54Z

@tgolen Fixed now.

tgolen · 2025-01-09T18:19:51Z

                    newSelectedOptions = reject(selectedOptions, (selectedOption) => selectedOption.login === option.login);
                } else {
-                    newSelectedOptions = [...selectedOptions, {...option, isSelected: true, selected: true, reportID: option.reportID ?? '-1'}];
+                    newSelectedOptions = [...selectedOptions, {...option, isSelected: true, selected: true, reportID: option.reportID ?? CONST.EMPTY_STRING}];


I think this one needs to be CONST.DEFAULT_NUMBER_ID as well? I think going from -1 to an empty string would have some unintended consequences.

@tgolen I updated.

Fix the start group button moves up (cherry picked from commit 5f4df80) (CP triggered by tgolen)

OSBotify · 2025-01-09T20:49:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-09T21:17:19Z

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.82-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-01-10T03:39:51Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.82-12 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

shubham1206agra · 2025-03-07T10:56:53Z

                    newSelectedOptions = reject(selectedOptions, (selectedOption) => selectedOption.login === option.login);
                } else {
-                    newSelectedOptions = [...selectedOptions, {...option, isSelected: true, selected: true, reportID: option.reportID ?? '-1'}];
+                    newSelectedOptions = [...selectedOptions, {...option, isSelected: true, selected: true, reportID: option.reportID ?? `${CONST.DEFAULT_NUMBER_ID}`}];


This still violates the lint rule. Please check https://expensify.slack.com/archives/C01GTK53T8Q/p1737913879440099

@nkdengineer Please fix the lint.

Fix the start group button moves up

006b965

nkdengineer marked this pull request as ready for review January 9, 2025 17:28

nkdengineer requested a review from a team as a code owner January 9, 2025 17:28

melvin-bot Bot requested review from s77rt and removed request for a team January 9, 2025 17:28

s77rt approved these changes Jan 9, 2025

View reviewed changes

melvin-bot Bot requested a review from tgolen January 9, 2025 17:38

tgolen requested changes Jan 9, 2025

View reviewed changes

nkdengineer added 2 commits January 10, 2025 01:01

Merge branch 'main' into fix/54975

cf3ebef

fix lint error

7850ce0

tgolen requested changes Jan 9, 2025

View reviewed changes

change to default number id

7f60aed

tgolen approved these changes Jan 9, 2025

View reviewed changes

tgolen merged commit 5f4df80 into Expensify:main Jan 9, 2025

OSBotify pushed a commit that referenced this pull request Jan 9, 2025

Merge pull request #55020 from nkdengineer/fix/54975

94c68dc

Fix the start group button moves up (cherry picked from commit 5f4df80) (CP triggered by tgolen)

github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Jan 9, 2025

github-actions Bot mentioned this pull request Jan 9, 2025

Deploy Checklist: New Expensify 2025-01-08 #54928

Closed

60 tasks

melvin-bot Bot mentioned this pull request Jan 10, 2025

[HOLD for payment 2025-01-18] [HOLD for payment 2025-01-17] [$250] Android - Group - Start Group button moves up and space is created below on confirmation tab #54975

Closed

8 tasks

shubham1206agra reviewed Mar 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix the start group button moves up#55020

Fix the start group button moves up#55020
tgolen merged 4 commits into
Expensify:mainfrom
nkdengineer:fix/54975

nkdengineer commented Jan 9, 2025

Uh oh!

melvin-bot Bot commented Jan 9, 2025

Uh oh!

s77rt commented Jan 9, 2025

Uh oh!

s77rt commented Jan 9, 2025

Uh oh!

tgolen left a comment

Uh oh!

nkdengineer commented Jan 9, 2025

Uh oh!

tgolen Jan 9, 2025

Uh oh!

nkdengineer Jan 9, 2025

Uh oh!

OSBotify commented Jan 9, 2025

Uh oh!

github-actions Bot commented Jan 9, 2025

Uh oh!

github-actions Bot commented Jan 10, 2025

Uh oh!

shubham1206agra Mar 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

nkdengineer commented Jan 9, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 9, 2025

Uh oh!

s77rt commented Jan 9, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

s77rt commented Jan 9, 2025

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

nkdengineer commented Jan 9, 2025

Uh oh!

tgolen Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

nkdengineer Jan 9, 2025

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 9, 2025

Uh oh!

github-actions Bot commented Jan 9, 2025

Uh oh!

github-actions Bot commented Jan 10, 2025

Uh oh!

shubham1206agra Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants