Skip to content

Get nudgeMigration timestamp from OldDot transition url #54972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
puneetlath merged 4 commits into from
Jan 8, 2025
Merged

Get nudgeMigration timestamp from OldDot transition url #54972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5aae117
Remove workaround
rayane-d Jan 8, 2025
8e7c943
get nudgeMigration timestamp from transition url
rayane-d Jan 8, 2025
9985ea9
Handle nudgeMigrationTimestamp when undefined
rayane-d Jan 8, 2025
174a511
Merge branch 'Expensify:main' into add-nudgeMigration-timestamp-to-tr…
rayane-d Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/components/ExplanationModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,11 @@
import React from 'react';
import {useOnyx} from 'react-native-onyx';
import useLocalize from '@hooks/useLocalize';
import * as Welcome from '@userActions/Welcome';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import FeatureTrainingModal from './FeatureTrainingModal';

function ExplanationModal() {
const {translate} = useLocalize();
const [tryNewDot] = useOnyx(ONYXKEYS.NVP_TRYNEWDOT);
const hasBeenAddedToNudgeMigration = !!tryNewDot?.nudgeMigration?.timestamp;

if (hasBeenAddedToNudgeMigration) {
return null;
}

return (
<FeatureTrainingModal
Expand Down
6 changes: 5 additions & 1 deletion src/libs/actions/Session/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,7 @@ function signInAfterTransitionFromOldDot(transitionURL: string) {
autoGeneratedPassword,
clearOnyxOnStart,
completedHybridAppOnboarding,
nudgeMigrationTimestamp,
isSingleNewDotEntry,
primaryLogin,
shouldRemoveDelegatedAccess,
Expand Down Expand Up @@ -554,7 +555,10 @@ function signInAfterTransitionFromOldDot(transitionURL: string) {
[ONYXKEYS.ACCOUNT]: {primaryLogin},
[ONYXKEYS.CREDENTIALS]: {autoGeneratedLogin, autoGeneratedPassword},
[ONYXKEYS.IS_SINGLE_NEW_DOT_ENTRY]: isSingleNewDotEntry === 'true',
[ONYXKEYS.NVP_TRYNEWDOT]: {classicRedirect: {completedHybridAppOnboarding: completedHybridAppOnboarding === 'true'}},
[ONYXKEYS.NVP_TRYNEWDOT]: {
classicRedirect: {completedHybridAppOnboarding: completedHybridAppOnboarding === 'true'},
nudgeMigration: nudgeMigrationTimestamp ? {timestamp: new Date(nudgeMigrationTimestamp)} : undefined,
},
}),
)
.then(() => {
Expand Down