Skip to content

Add HybridApp setup step to prevent build issues#54882

Merged
Julesssss merged 1 commit into
mainfrom
jules-addHybridAppBuildStep
Jan 7, 2025
Merged

Add HybridApp setup step to prevent build issues#54882
Julesssss merged 1 commit into
mainfrom
jules-addHybridAppBuildStep

Conversation

@Julesssss

Copy link
Copy Markdown
Contributor

Explanation of Change

Simply adds a hidden build step that will cause problems for all new HybridApp repo clones. This is a short-term fix for #54877, which will automate this step.

Fixed Issues

$ #54877

N/A

@Julesssss Julesssss self-assigned this Jan 7, 2025
@Julesssss Julesssss marked this pull request as ready for review January 7, 2025 16:23
@Julesssss Julesssss requested a review from a team as a code owner January 7, 2025 16:23
@melvin-bot melvin-bot Bot requested a review from rushatgabhane January 7, 2025 16:23
@melvin-bot

melvin-bot Bot commented Jan 7, 2025

Copy link
Copy Markdown

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team January 7, 2025 16:23
@Julesssss Julesssss removed the request for review from rushatgabhane January 7, 2025 16:23
@Julesssss

Copy link
Copy Markdown
Contributor Author

No C+ review required here.

@NikkiWines NikkiWines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$approved$

@Julesssss

Copy link
Copy Markdown
Contributor Author

Merging without full checklist

@Julesssss Julesssss merged commit cd43345 into main Jan 7, 2025
@Julesssss Julesssss deleted the jules-addHybridAppBuildStep branch January 7, 2025 16:26
@melvin-bot

melvin-bot Bot commented Jan 7, 2025

Copy link
Copy Markdown

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Jan 7, 2025
@Julesssss

Copy link
Copy Markdown
Contributor Author

Merging without full checklist

^^^

@OSBotify

OSBotify commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.82-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

1 similar comment
@github-actions

github-actions Bot commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.0.82-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.82-12 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants