refactor shareTrackedExpense function by ChavdaSachin · Pull Request #54650 · Expensify/App

ChavdaSachin · 2024-12-29T22:34:46Z

Explanation of Change

Fixed Issues

#54466
PROPOSAL: #54466 (comment)

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Prerequisite : have a tracked expense.

go to self-dm.
Select Share it with my accountant from actionable whisper.
Select a workspace.
Verify tracked expense is successfully shared with the workspace.

steps to track an expense.
option 1.

go to self-dm.
click + button from composer.
create an expense.

option 2.

click FAB
enter amount/receipt/way points.
select Just Track it(don't submit it) option from contact selector.
fill out other fields if needed.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-30.at.3.32.00.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-12-30.at.3.35.31.AM.mov

iOS: Native

Screen.Recording.2024-12-30.at.3.44.41.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-12-30.at.3.42.27.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-30.at.3.25.35.AM.mov

MacOS: Desktop

Screen.Recording.2024-12-30.at.3.54.19.AM.mov

melvin-bot · 2024-12-29T22:35:22Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ChavdaSachin · 2025-01-03T17:02:50Z

@eVoloshchak could you review this PR.. or maybe provide an expected day id you are running busy.
Thank you.

ps. I will be OOO on 5-6 Jan.

eVoloshchak · 2025-01-06T10:26:34Z

@ChavdaSachin, I'm also OOO on the 6th (today), will be able to review this tomorrow if that works

ChavdaSachin · 2025-01-06T10:36:43Z

Works....

ChavdaSachin · 2025-01-08T05:52:44Z

@eVoloshchak let me know if you need any help here..

eVoloshchak · 2025-01-08T10:24:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-08.at.14.57.24.mov

Android: mWeb Chrome

Screen.Recording.2025-01-08.at.15.00.31.mov

iOS: Native

Screen.Recording.2025-01-08.at.14.48.07.mov

iOS: mWeb Safari

Screen.Recording.2025-01-08.at.14.50.22.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-08.at.14.05.26.mov

MacOS: Desktop

Screen.Recording.2025-01-08.at.15.05.13.mov

eVoloshchak · 2025-01-08T14:08:58Z

There is a bug that happens during testing this: invite new members page is opened after you share an expense. Confirmed it happens on main too, it wasn't caused by this PR

eVoloshchak

LGTM!

neil-marcellini

One request. Also there are merge conflicts.

neil-marcellini · 2025-01-13T22:25:54Z

+            const transactionParams = {
+                transactionID: transaction?.transactionID ?? '-1',
                amount,
                currency,
                comment,
                merchant,
                created,
+                taxCode: taxCode ?? '',
+                taxAmount: taxAmount ?? 0,


Can we please remove the default IDs and follow the TS guidelines regarding defaulting IDs? Or does that create way too many unrelated changes. If so, let's make sure we have an issue tracking that.

I would remove those default IDs and then verify the BE response.
Would go through the GH convo when these IDs were added.

Ok, I assume you're saying that you will do those things? Here are the guidelines to follow. I don't think you really need to look at the BE response.

oh, I was unaware this new guidelines. I sort of miss interpreted your suggestion here.
But now it is super clear, Thank you.

When trying to implement those default IDs, one thing leads to another and it keeps going and those will be too many changes unrelated to this PR. So I think it's better to have separate GH for implementing those default IDs throughout the file - might take a few PRs.

Merge conflict is resolved, Ready for merge.

…' into refactor/IOU.shareTrackedExpense

OSBotify · 2025-01-21T18:45:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-23T18:27:20Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-28T01:50:44Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

refactor shareTrackedExpense function

0573785

ChavdaSachin marked this pull request as ready for review December 29, 2024 22:35

ChavdaSachin requested a review from a team as a code owner December 29, 2024 22:35

melvin-bot Bot requested review from eVoloshchak and removed request for a team December 29, 2024 22:35

ChavdaSachin added 4 commits December 30, 2024 04:18

Delete accidentally added file

3888e81

Delete accidentally added file

c7f830a

Delete accidentally added file

df6460e

Delete accidentally added file

ad9034a

eVoloshchak approved these changes Jan 8, 2025

View reviewed changes

melvin-bot Bot requested a review from neil-marcellini January 8, 2025 14:09

neil-marcellini requested changes Jan 13, 2025

View reviewed changes

ChavdaSachin added 2 commits January 18, 2025 01:27

Merge Main

bf6cdd4

Merge remote-tracking branch 'origin/refactor/IOU.shareTrackedExpense…

e9de5d8

…' into refactor/IOU.shareTrackedExpense

neil-marcellini approved these changes Jan 21, 2025

View reviewed changes

neil-marcellini merged commit 059368f into Expensify:main Jan 21, 2025

neil-marcellini mentioned this pull request Jan 21, 2025

[$250] Refactor shareTrackedExpense to use a parameter object #54466

Closed

github-actions Bot mentioned this pull request Jan 23, 2025

Deploy Checklist: New Expensify 2025-01-23 #55657

Closed

ChavdaSachin deleted the refactor/IOU.shareTrackedExpense branch July 28, 2025 12:28

Uh oh!

Conversation

ChavdaSachin commented Dec 29, 2024 • edited by neil-marcellini Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Dec 29, 2024

Uh oh!

ChavdaSachin commented Jan 3, 2025

Uh oh!

eVoloshchak commented Jan 6, 2025

Uh oh!

ChavdaSachin commented Jan 6, 2025

Uh oh!

ChavdaSachin commented Jan 8, 2025

Uh oh!

eVoloshchak commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak commented Jan 8, 2025

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

ChavdaSachin Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

ChavdaSachin Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

ChavdaSachin Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 21, 2025

Uh oh!

github-actions Bot commented Jan 23, 2025

Uh oh!

github-actions Bot commented Jan 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ChavdaSachin commented Dec 29, 2024 •

edited by neil-marcellini

Loading

eVoloshchak commented Jan 8, 2025 •

edited

Loading