Check response title for setPassword validate code failure#5406
Merged
Conversation
5 tasks
marcaaron
approved these changes
Sep 21, 2021
marcaaron
left a comment
marcaaron
left a comment
Contributor
There was a problem hiding this comment.
Nice one. Sorry I didn't test what would happen if we actually had a bad validate code :ohnothing:
Contributor
Author
|
No worries, I should've added it to the list of tests as well 🚀 |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
17 tasks
Contributor
|
🚀 Deployed to staging by @marcaaron in version: 1.1.0-3 🚀
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @marcaaron
Details
This PR is a follow up to fix https://github.com/Expensify/App/pull/5398/files#diff-283c48b7349b0bf7aba66da8891bc8a9f9df70664bd06e7a875f56b19c6c02f9R275. We were checking the message instead of the title, so if the user clicks an expired or invalid validation link the error message won't be shown.
Tests/QA
Tested On
Screenshots