Show search action buttons v2 by luacmartins · Pull Request #52441 · Expensify/App

luacmartins · 2024-11-13T00:56:00Z

Details

This PR adds new actions, Approve and Pay to the Search results page.

Fixed Issues

$ #51898
$ #52360
$ #52364
$ #52365
$ #52366
$ #52367
$ #52368
$ #52369
$ #52371
$ #52375
$ #52377
$ #52404
$ #52411
$ #52418

Tests

Pre-requisites:

Make sure you have a report that can be approved, i.e. create a workspace, invite a member, turn on approvals and reimbursement (workflows), as the member submit a few expenses

Tests steps:

Open the browser console
Navigate to the Search page
Verify that the response from Search includes data for transactions, reports and policy
Verify that you see the Approve button next to the expense/report that can be approved
Verify that pressing the button calls ApproveMoneyRequestOnSearch
Verify that the expense/report is approved and the button updates to Pay
Press Pay
Verify that the first time, you're navigated to the report in the RHP
Select a payment method from the settlement button in the report header
Pay the report
Repeat 7, but this time the report should automatically be paid using the same payment method from step 9-10
Verify that the button changes to the Paid badge

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2024-11-08.at.1.16.58.PM.mov

Screen.Recording.2024-11-08.at.1.20.02.PM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-11-18T17:28:29Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2024-11-18T17:29:21Z

@alitoshmatov this is the second attempt on this issue, since the first PR got reverted. We're still waiting on some backend changes to be deployed, which should happen today.

luacmartins · 2024-11-19T16:49:44Z

All backend changes are deployed. @alitoshmatov please prioritize reviewing this PR.

alitoshmatov · 2024-11-19T16:50:28Z

Working on it right now

alitoshmatov · 2024-11-19T17:00:03Z

@luacmartins When approving from search actions it is ignoring held expenses and approving all unlike approving in chat which asks which part to approve. Is this expected behavior

alitoshmatov · 2024-11-19T17:07:54Z

Also if expense group is approved in outstanding tab, it shows Pay button, but if you switch to different tab and come back that expense group disappears. Now each expense visible in All section but you can only View them, there is no Pay button.

Now user cannot pay these expenses from search page. Is it expected behavior?

Screen.Recording.2024-11-19.at.10.03.39.PM.mov

luacmartins · 2024-11-19T17:12:44Z

@luacmartins When approving from search actions it is ignoring held expenses and approving all unlike approving in chat which asks which part to approve. Is this expected behavior

In Search, we just pay the non-held expenses. The held ones should be automatically moved to a new report. Do you see that behavior?

luacmartins · 2024-11-19T17:13:29Z

Also if expense group is approved in outstanding tab, it shows Pay button, but if you switch to different tab and come back that expense group disappears. Now each expense visible in All section but you can only View them, there is no Pay button.
Now user cannot pay these expenses from search page. Is it expected behavior?

Yea, that's expected. You'd be able to see the expense in the Approved tab and should see a Pay button there.

alitoshmatov · 2024-11-19T17:29:25Z

In Search, we just pay the non-held expenses. The held ones should be automatically moved to a new report. Do you see that behavior?

No approving report is just approving all expenses and the held ones are getting unheld

luacmartins · 2024-11-19T18:26:18Z

I'll check on that behavior. Please continue reviewing the PR though

alitoshmatov · 2024-11-20T10:41:31Z

All the regressions are solved, feature is working as expected. Reviewing the code

luacmartins · 2024-11-20T16:12:56Z

@alitoshmatov I just checked with the product team and we should show the modal if we have held expenses. I'll work on those changes now

alitoshmatov · 2024-11-21T23:58:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

search-action-android.mov

Android: mWeb Chrome

search-action-mweb.mov

iOS: Native

search-action-ios.mp4

iOS: mWeb Safari

search-action-safari.mp4

MacOS: Chrome / Safari

search-action-web.mov

MacOS: Desktop

search-action-desktop.mov

alitoshmatov

I think everything looks good and we can proceed

melvin-bot · 2024-11-21T23:59:43Z

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2024-11-22T11:06:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-22T20:31:27Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.0.66-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-26T16:12:52Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.66-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

jjcoffee · 2024-12-16T11:47:36Z

Coming from #53009, we missed adding the sound for the Pay button.

jjcoffee · 2024-12-30T09:36:37Z

+        return CONST.SEARCH.ACTION_TYPES.PAY;
+    }
+
+    if (IOU.canApproveIOU(report, policy) && ReportUtils.isAllowedToApproveExpenseReport(report, undefined, policy)) {


Coming from #53101, we're missing that we shouldn't be able to approve pending card transactions.

Revert "[CP Staging] Revert "Show search action buttons""

c40fae8

luacmartins self-assigned this Nov 13, 2024

luacmartins mentioned this pull request Nov 13, 2024

Show search action buttons #51445

Merged

50 tasks

luacmartins added 3 commits November 13, 2024 13:25

Merge branch 'main' into revert-52434-revert-PR-51445

4aa8c6f

fix paid invoice label

1a9aa94

fix self-approval

b1086a2

luacmartins mentioned this pull request Nov 14, 2024

Fix condition for approval button #52421

Closed

48 tasks

luacmartins added 5 commits November 15, 2024 11:47

resolve conflicts

63b164a

check vbba

2805d3b

hide pay button

9178bd2

update pay button condition

e12c200

Merge branch 'main' into revert-52434-revert-PR-51445

1dbec4d

luacmartins marked this pull request as ready for review November 18, 2024 17:28

luacmartins requested a review from a team as a code owner November 18, 2024 17:28

melvin-bot Bot requested review from alitoshmatov and removed request for a team November 18, 2024 17:28

Merge branch 'main' into revert-52434-revert-PR-51445

200a650

resolve conflicts

dbdada7

alitoshmatov approved these changes Nov 21, 2024

View reviewed changes

melvin-bot Bot requested a review from mjasikowski November 21, 2024 23:59

mjasikowski approved these changes Nov 22, 2024

View reviewed changes

mjasikowski merged commit 4c47abe into main Nov 22, 2024

mjasikowski deleted the revert-52434-revert-PR-51445 branch November 22, 2024 10:55

github-actions Bot mentioned this pull request Nov 22, 2024

Deploy Checklist: New Expensify 2024-11-22 #52978

Closed

75 tasks

lanitochka17 mentioned this pull request Nov 23, 2024

[Search v1.2] - No approve button on the transaction in search page #53018

Closed

8 tasks

ishpaul777 mentioned this pull request Nov 25, 2024

[HOLD for payment 2024-12-16] Search - No sound when paying expense in Search #53009

Closed

8 tasks

luacmartins mentioned this pull request Nov 25, 2024

[HOLD for payment 2024-12-19] [Search v1.2] - Different approval behavior when approving one held expense vs multiple held expenses #53012

Closed

8 tasks

jjcoffee reviewed Dec 30, 2024

View reviewed changes

Uh oh!

Conversation

luacmartins commented Nov 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 18, 2024

Uh oh!

luacmartins commented Nov 18, 2024

Uh oh!

luacmartins commented Nov 19, 2024

Uh oh!

alitoshmatov commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alitoshmatov commented Nov 19, 2024

Uh oh!

alitoshmatov commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luacmartins commented Nov 19, 2024

Uh oh!

luacmartins commented Nov 19, 2024

Uh oh!

alitoshmatov commented Nov 19, 2024

Uh oh!

luacmartins commented Nov 19, 2024

Uh oh!

alitoshmatov commented Nov 20, 2024

Uh oh!

luacmartins commented Nov 20, 2024

Uh oh!

alitoshmatov commented Nov 21, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

alitoshmatov left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Nov 21, 2024

Uh oh!

OSBotify commented Nov 22, 2024

Uh oh!

github-actions Bot commented Nov 22, 2024

Uh oh!

github-actions Bot commented Nov 26, 2024

Uh oh!

jjcoffee commented Dec 16, 2024

Uh oh!

jjcoffee Dec 30, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

luacmartins commented Nov 13, 2024 •

edited

Loading

alitoshmatov commented Nov 19, 2024 •

edited

Loading

alitoshmatov commented Nov 19, 2024 •

edited

Loading