Fix bundle install on macOS 15.1 by rafecolton · Pull Request #52227 · Expensify/App

rafecolton · 2024-11-07T23:02:57Z

Explanation of Change

Trying to install ffi version 1.15.5 fails on macOS 15.1 but there's a newer version that works just fine. Discovered while trying to test the documentation website locally. Updating that enabled bundle install to finish, but then I got a jekyll error trying to load the site:

error and trace

jekyll 3.9.3 | Error:  undefined method `[]' for nil
/Users/rafe/.rbenv/versions/3.3.4/lib/ruby/3.3.0/logger.rb:384:in `level': undefined method `[]' for nil (NoMethodError)

    @level_override[Fiber.current] || @level
                   ^^^^^^^^^^^^^^^
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/jekyll-3.9.3/lib/jekyll/log_adapter.rb:43:in `adjust_verbosity'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/jekyll-3.9.3/lib/jekyll/configuration.rb:157:in `config_files'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/jekyll-3.9.3/lib/jekyll.rb:113:in `configuration'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/jekyll-3.9.3/lib/jekyll/command.rb:43:in `configuration_from_options'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/jekyll-3.9.3/lib/jekyll/commands/serve.rb:89:in `start'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/jekyll-3.9.3/lib/jekyll/commands/serve.rb:75:in `block (2 levels) in init_with_program'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `block in execute'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `each'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `execute'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/mercenary-0.3.6/lib/mercenary/program.rb:42:in `go'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/mercenary-0.3.6/lib/mercenary.rb:19:in `program'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/jekyll-3.9.3/exe/jekyll:15:in `<top (required)>'
        from /Users/rafe/.rbenv/versions/3.3.4/bin/jekyll:25:in `load'
        from /Users/rafe/.rbenv/versions/3.3.4/bin/jekyll:25:in `<top (required)>'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/bundler-2.4.19/lib/bundler/cli/exec.rb:58:in `load'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/bundler-2.4.19/lib/bundler/cli/exec.rb:58:in `kernel_load'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/bundler-2.4.19/lib/bundler/cli/exec.rb:23:in `run'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/bundler-2.4.19/lib/bundler/cli.rb:492:in `exec'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/bundler-2.4.19/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/bundler-2.4.19/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/bundler-2.4.19/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/bundler-2.4.19/lib/bundler/cli.rb:34:in `dispatch'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/bundler-2.4.19/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/bundler-2.4.19/lib/bundler/cli.rb:28:in `start'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/bundler-2.4.19/exe/bundle:37:in `block in <top (required)>'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/bundler-2.4.19/lib/bundler/friendly_errors.rb:117:in `with_friendly_errors'
        from /Users/rafe/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/bundler-2.4.19/exe/bundle:29:in `<top (required)>'
        from /Users/rafe/.rbenv/versions/3.3.4/bin/bundle:25:in `load'
        from /Users/rafe/.rbenv/versions/3.3.4/bin/bundle:25:in `<main>'

Doing a full bundle update fixed it and I was able to load the site locally

Fixed Issues

N/A, discovered while testing #52010
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Follow README instructions in docs/ to set up the doc site locally
Confirm it works

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Trying to install ffi version 1.15.5 fails on macOS 15.1 but there's a newer version that works just fine

melvin-bot · 2024-11-07T23:03:26Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2024-11-07T23:05:34Z

A preview of your ExpensifyHelp changes have been deployed to https://345ca3b6.helpdot.pages.dev ⚡️

cristipaval · 2024-11-08T11:30:40Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2024-11-11T18:41:26Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.0.60-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

kavimuru · 2024-11-11T18:47:44Z

@rafecolton Could you provide more details about QA steps?

rafecolton · 2024-11-11T19:08:34Z

Not really sure what additional detail I can provide - follow the instructions in the README to set up the documentation site locally, confirm you are able to view the site. I'm not sure if that's within your scope though, so if not, you can disregard.

kavimuru · 2024-11-12T13:33:30Z

@rafecolton seems help.expensify.com is also a production site. Can I check it off the list? It doesn't seem to be in scope.

rafecolton · 2024-11-13T00:17:23Z

This change is about running the development locally, not the production one. But yeah it's fine, I think you can check it off. If it blows up, somebody will complain and I'll fix it - it shouldn't affect production or staging.

github-actions · 2024-11-13T00:44:55Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.60-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

rafecolton added 2 commits November 7, 2024 14:52

Fix bundle install on macOS 15.1 by updating ffi version

74608d2

Trying to install ffi version 1.15.5 fails on macOS 15.1 but there's a newer version that works just fine

Run full bundle update

d4c7006

rafecolton self-assigned this Nov 7, 2024

rafecolton requested a review from a team as a code owner November 7, 2024 23:02

melvin-bot Bot requested a review from cristipaval November 7, 2024 23:03

melvin-bot Bot removed the request for review from a team November 7, 2024 23:03

cristipaval approved these changes Nov 8, 2024

View reviewed changes

cristipaval merged commit b7acfbf into main Nov 8, 2024

cristipaval deleted the rafe-fix-bundle-install branch November 8, 2024 11:33

github-actions Bot mentioned this pull request Nov 11, 2024

[HOLD for payment 2024-11-21] Deploy Checklist: New Expensify 2024-11-11 #52320

Closed

95 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix bundle install on macOS 15.1#52227

Fix bundle install on macOS 15.1#52227
cristipaval merged 2 commits into
mainfrom
rafe-fix-bundle-install

rafecolton commented Nov 7, 2024

Uh oh!

melvin-bot Bot commented Nov 7, 2024

Uh oh!

OSBotify commented Nov 7, 2024

Uh oh!

cristipaval commented Nov 8, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Nov 11, 2024

Uh oh!

kavimuru commented Nov 11, 2024

Uh oh!

rafecolton commented Nov 11, 2024

Uh oh!

kavimuru commented Nov 12, 2024

Uh oh!

rafecolton commented Nov 13, 2024

Uh oh!

github-actions Bot commented Nov 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

rafecolton commented Nov 7, 2024

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 7, 2024

Uh oh!

OSBotify commented Nov 7, 2024

Uh oh!

cristipaval commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Nov 11, 2024

Uh oh!

kavimuru commented Nov 11, 2024

Uh oh!

rafecolton commented Nov 11, 2024

Uh oh!

kavimuru commented Nov 12, 2024

Uh oh!

rafecolton commented Nov 13, 2024

Uh oh!

github-actions Bot commented Nov 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cristipaval commented Nov 8, 2024 •

edited

Loading