[CP Staging] Fix some text inputs are unaligned if there are prefix characters by tsa321 · Pull Request #50795 · Expensify/App

tsa321 · 2024-10-15T12:38:30Z

Details

Fixed Issues

$ #48281
$ #50777
$ #50778
PROPOSAL: #48281 (comment)

Tests

Open any chat.
Tap on the "+" icon.
Tap on "Submit Expense"
Enter any amount.
Verify the amount added is aligned with the currency.
Click/Tap fab -> start chat -> room
Verify that the cursor and hashtag must be aligned in same line

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open any chat.
Tap on the "+" icon.
Tap on "Submit Expense"
Enter any amount.
Verify the amount added is aligned with the currency.
Click/Tap fab -> start chat -> room
Verify that the cursor and hashtag must be aligned in same line

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native-d.mp4

Android: mWeb Chrome

android-mweb_d.mp4

iOS: Native

ios-native_d.mp4

iOS: mWeb Safari

ios-msfari_d.mp4

MacOS: Chrome / Safari

macos-web-d.mp4

MacOS: Desktop

macos-desktop_d.mp4

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

melvin-bot · 2024-10-15T12:38:35Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2024-10-15T12:38:36Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

alitoshmatov · 2024-10-15T13:59:12Z

@tsa321 Can you explain what went wrong and what is our solution here

tsa321 · 2024-10-15T14:24:46Z

@alitoshmatov, based on the expected result to add padding between the bottom line of the text input and the text in the auto-grow markdown text input, we need to add paddingBottom: 8 to the container of the text input. However, adding it directly to textInputContainer caused issues in Android mWeb. I checked other platforms, but I may have missed it in Android mWeb. Therefore, I will limit the addition of paddingBottom only when the text input isAutoGrowHeightMarkdown.

Actually, the issue with adding padding is distinct from the original issue regarding the visibility of the last line in the markdown text input. Therefore, I think it falls outside the scope of the original problem.

alitoshmatov · 2024-10-15T14:50:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

fix-android.mov

Android: mWeb Chrome

fix-mweb.mov

iOS: Native

fix-ios.mp4

iOS: mWeb Safari

fix-safari.mp4

MacOS: Chrome / Safari

fix-web.mov

MacOS: Desktop

fix-desktop.mov

alitoshmatov

LGTM!

shawnborton · 2024-10-15T15:29:41Z

            borderColor: theme.border,
+        },
+
+        autoGrowMarkdwonTextInputPaddingBottom: {


Rather than write a new style for this, why not just use pb2 - it's a utility class that already exists.

youssef-lr · 2024-10-15T20:41:56Z

Given this fixes some deploy blockers, for urgency I create another PR here #50836.

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 · 2024-10-15T22:14:33Z

@youssef-lr I have updated the code to use the pb2

youssef-lr · 2024-10-15T22:15:32Z

            overflow: 'hidden',
            borderBottomWidth: 2,
            borderColor: theme.border,
-            paddingBottom: 8,


Is this intentional?

@youssef-lr , Yes, this is what I added from my previous PR that caused the regressions.

OSBotify · 2024-10-15T22:43:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Fix some text inputs are unaligned if there are prefix characters (cherry picked from commit 137c6d6) (CP triggered by marcaaron)

github-actions · 2024-10-15T23:39:53Z

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.0.49-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2024-10-16T21:41:53Z

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.0.49-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

mvtglobally · 2024-10-16T23:53:44Z

We are unable to verify this on Desktop as Build did not release yet. Rest platforms are pass

youssef-lr · 2024-10-16T23:54:44Z

@mvtglobally it should work fine on desktop too.

github-actions · 2024-10-17T01:47:27Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.49-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix some text inputs are unaligned if there are prefix characters

303c6ac

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 requested review from a team as code owners October 15, 2024 12:38

melvin-bot Bot requested a review from alitoshmatov October 15, 2024 12:38

melvin-bot Bot removed the request for review from a team October 15, 2024 12:38

tsa321 mentioned this pull request Oct 15, 2024

[HOLD for payment 2024-10-25] [HOLD for payment 2024-10-24] mWeb - Expense - The amount is not aligned with the currency during expense creation flow #50778

Closed

6 tasks

alitoshmatov approved these changes Oct 15, 2024

View reviewed changes

melvin-bot Bot requested a review from youssef-lr October 15, 2024 14:51

shawnborton reviewed Oct 15, 2024

View reviewed changes

youssef-lr mentioned this pull request Oct 15, 2024

Fix some text inputs are unaligned if there are prefix characters #50836

Closed

48 tasks

Using pb2 instead of creating new class

38c5b3b

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

youssef-lr reviewed Oct 15, 2024

View reviewed changes

youssef-lr approved these changes Oct 15, 2024

View reviewed changes

youssef-lr merged commit 137c6d6 into Expensify:main Oct 15, 2024

youssef-lr changed the title ~~Fix some text inputs are unaligned if there are prefix characters~~ [CP Staging] Fix some text inputs are unaligned if there are prefix characters Oct 15, 2024

OSBotify pushed a commit that referenced this pull request Oct 15, 2024

Merge pull request #50795 from tsa321/fixPaddingBottomTextInput

37e362e

Fix some text inputs are unaligned if there are prefix characters (cherry picked from commit 137c6d6) (CP triggered by marcaaron)

github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Oct 15, 2024

github-actions Bot mentioned this pull request Oct 15, 2024

Deploy Checklist: New Expensify 2024-10-15 #50764

Closed

71 tasks

melvin-bot Bot mentioned this pull request Oct 17, 2024

[HOLD for payment 2024-10-25] [HOLD for payment 2024-10-24] [$250] Android - Room -On entering multiline text with header markdown, 2nd line is not visible #48281

Closed

6 tasks

melvin-bot Bot mentioned this pull request Oct 17, 2024

[HOLD for payment 2024-10-25] [HOLD for payment 2024-10-24] [$250] mWeb - Room - Cursor and hashtag are not aligned in same line #50777

Closed

6 tasks

Uh oh!

Conversation

tsa321 commented Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 15, 2024

Uh oh!

melvin-bot Bot commented Oct 15, 2024

Uh oh!

alitoshmatov commented Oct 15, 2024

Uh oh!

tsa321 commented Oct 15, 2024

Uh oh!

alitoshmatov commented Oct 15, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

alitoshmatov left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

youssef-lr Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

youssef-lr commented Oct 15, 2024

Uh oh!

tsa321 commented Oct 15, 2024

Uh oh!

youssef-lr Oct 15, 2024

Choose a reason for hiding this comment

Uh oh!

tsa321 Oct 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 15, 2024

Uh oh!

github-actions Bot commented Oct 15, 2024

Uh oh!

github-actions Bot commented Oct 16, 2024

Uh oh!

mvtglobally commented Oct 16, 2024

Uh oh!

youssef-lr commented Oct 16, 2024

Uh oh!

github-actions Bot commented Oct 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tsa321 commented Oct 15, 2024 •

edited

Loading

tsa321 Oct 15, 2024 •

edited

Loading