[No QA] Feat: Adding Direct Card Feed: Selecting bank step by waterim · Pull Request #50521 · Expensify/App

waterim · 2024-10-09T21:48:16Z

Details

Fixed Issues

$ #50446
PROPOSAL: N/A

Tests

Open any workspace
Enable Company Cards
Click "Add company card"
Observe a correct screen with bank selection

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

None

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-10-09T21:48:44Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

waterim · 2024-10-09T22:09:51Z

I see the issues, will update tomorrow morning

allgandalf

few comments, we're on good track, can you fix the GH actions ? Lets try to get it merged today 🚀

waterim · 2024-10-10T19:29:01Z

@allgandalf Sorry, was OOO first half of the day, working right now!

waterim · 2024-10-10T19:40:05Z

@allgandalf updated everything!

allgandalf · 2024-10-11T10:02:27Z

This should be marked as No QA right ?\

allgandalf · 2024-10-11T10:28:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

allgandalf · 2024-10-11T11:02:45Z

BUG: Image for bank of america and other is zoomed on ios native:

allgandalf · 2024-10-11T12:15:15Z

@dannymcclain we would want the following correct dimension image for other banks:

dannymcclain · 2024-10-11T13:17:44Z

I think @dubielzyk-expensify got all these exported and added. Looking through the files, I think you may just be referencing the wrong images for those two.

For Bank of America, we need to be using this image: App/assets/images/companyCards/card-bofa.svg and NOT "assets/images/companyCards/card-bank_of_america.svg"

For the other/generic one, we need to be using this image: App/assets/images/companyCards/card=-generic.svg and NOT "App/assets/images/companyCards/card-other.svg"

We should probably clean those up honestly. If you want to rename the correct files to the current reference (and ditch the out-dated images) that'd probably be best.

waterim · 2024-10-11T14:49:49Z

@allgandalf updated the icon

allgandalf

Looks neat, lets merge

mountiny

Great, thanks team!

OSBotify · 2024-10-11T18:38:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-15T03:31:05Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-17T01:46:00Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.49-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rayane-d · 2025-03-07T16:05:14Z

+    return (
+        <ScreenWrapper
+            testID={SelectBankStep.displayName}
+            includeSafeAreaPaddingBottom={false}


FYI, This caused issue #57412

waterim added 8 commits October 9, 2024 23:42

add new constants

c889d98

add new illustrations

468622c

update translations

4ef5fc9

create new util function to get a correct image

debeb29

add new type for a step

c398d72

add new step

038131a

update handleBackButton in cardTypeStep

32a84be

added new SelectBankStep

a8b7a58

waterim marked this pull request as ready for review October 9, 2024 21:48

waterim requested a review from a team as a code owner October 9, 2024 21:48

melvin-bot Bot requested review from allgandalf and removed request for a team October 9, 2024 21:48

mountiny assigned waterim Oct 9, 2024

mountiny self-requested a review October 9, 2024 21:53

mountiny requested changes Oct 9, 2024

View reviewed changes

Comment thread src/pages/workspace/companyCards/addNew/AddNewCardPage.tsx Outdated

Comment thread src/CONST.ts Outdated

allgandalf reviewed Oct 10, 2024

View reviewed changes

Comment thread src/languages/en.ts Outdated

Comment thread src/languages/es.ts Outdated

Comment thread src/languages/es.ts

Comment thread src/pages/workspace/companyCards/addNew/SelectBankStep.tsx

waterim added 3 commits October 10, 2024 20:57

fix unsefe return

d7c50b4

remove empty spaces

adabff4

update citibank name

2316aa2

waterim added 2 commits October 10, 2024 21:29

Merge remote-tracking branch 'upstream/main' into feat-50446

bc18697

add direct feeds under beta

bfee0c1

allgandalf reviewed Oct 11, 2024

View reviewed changes

Comment thread src/pages/workspace/companyCards/addNew/SelectBankStep.tsx

update isError to hasError

9f71b5d

waterim changed the title ~~Feat: Adding Direct Card Feed: Selecting bank step~~ [No QA]Feat: Adding Direct Card Feed: Selecting bank step Oct 11, 2024

waterim changed the title ~~[No QA]Feat: Adding Direct Card Feed: Selecting bank step~~ [No QA] Feat: Adding Direct Card Feed: Selecting bank step Oct 11, 2024

waterim added 2 commits October 11, 2024 14:01

update boa card image

f0f4ca1

remove wrong image

34d02bc

waterim requested a review from a team as a code owner October 11, 2024 12:03

allgandalf reviewed Oct 11, 2024

View reviewed changes

Comment thread src/components/Icon/Illustrations.ts Outdated

update other card

19e08d8

allgandalf approved these changes Oct 11, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny October 11, 2024 14:58

mountiny approved these changes Oct 11, 2024

View reviewed changes

mountiny merged commit 9490328 into Expensify:main Oct 11, 2024

github-actions Bot mentioned this pull request Oct 15, 2024

Deploy Checklist: New Expensify 2024-10-15 #50764

Closed

71 tasks

melvin-bot Bot mentioned this pull request Oct 17, 2024

[HOLD for payment 2024-10-24] [Direct Feeds] [App] Adding Direct Card Feed: Selecting bank step #50446

Closed

rayane-d reviewed Mar 7, 2025

View reviewed changes

Uh oh!

Conversation

waterim commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 9, 2024

Uh oh!

Uh oh!

Uh oh!

waterim commented Oct 9, 2024

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waterim commented Oct 10, 2024

Uh oh!

waterim commented Oct 10, 2024

Uh oh!

allgandalf commented Oct 11, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

allgandalf commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf commented Oct 11, 2024

Uh oh!

allgandalf commented Oct 11, 2024

Uh oh!

dannymcclain commented Oct 11, 2024

Uh oh!

Uh oh!

waterim commented Oct 11, 2024

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 11, 2024

Uh oh!

github-actions Bot commented Oct 15, 2024

Uh oh!

github-actions Bot commented Oct 17, 2024

Uh oh!

rayane-d Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

waterim commented Oct 9, 2024 •

edited

Loading

allgandalf commented Oct 11, 2024 •

edited

Loading