Fix infinitely loading Of Attachment from qa.guide when opened in Search by shahinyan11 · Pull Request #50427 · Expensify/App

shahinyan11 · 2024-10-08T14:55:18Z

Details

Fixed Issues

$ #50006
PROPOSAL: #50006 (comment)

Tests

Go to staging.new.expensify.com
Go to DM
Send the following message. (The message is from qa.guide@team.expensify.com in #admins)
!(https://d2k5nsl2zxldvw.cloudfront.net/images/animations/animation_setupguide.gif)
Go to Search > Chat
Click on the message sent in Step 3
Make sure the attachment model does not have an infinite load.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as in the Tests section.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-08.at.16.18.32.mov

Android: mWeb Chrome

Screen.Recording.2024-10-08.at.15.38.46.mov

iOS: Native

Untitled.mov

iOS: mWeb Safari

Screen.Recording.2024-10-08.at.15.49.20.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-08.at.15.25.23.mov

MacOS: Desktop

Screen.Recording.2024-10-08.at.15.52.45.mov

melvin-bot · 2024-10-08T14:55:23Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

suneox · 2024-10-08T15:32:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-08.at.23.22.10.mp4

Android: mWeb Chrome

Screen.Recording.2024-10-08.at.23.20.47.mp4

iOS: Native

Screen.Recording.2024-10-08.at.23.24.13.mp4

iOS: mWeb Safari

Screen.Recording.2024-10-08.at.23.29.01.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-10-08.at.23.17.21.mp4

MacOS: Desktop

Screen.Recording.2024-10-08.at.23.19.24.mp4

Console Warning: Function components cannot be given refs has raised on slack
Console Warning: TRenderEngineProvider: Support for defaultProps has raised on slack

suneox · 2024-10-08T15:36:26Z

@shahinyan11 Please fix the ESLint check

shahinyan11 · 2024-10-08T15:41:43Z

@shahinyan11 Please fix the ESLint check

@suneox ESLint error related to using useOnyx instead of withOnyx. Shouldn't this be done as a separate task?

suneox · 2024-10-08T16:04:50Z

@suneox ESLint error related to using useOnyx instead of withOnyx. Shouldn't this be done as a separate task?

Ah, this error is not related to the scope change of this issue, we can skip this one.

shahinyan11 · 2024-10-08T16:24:08Z

@suneox Is there anything else I need to do?

suneox · 2024-10-08T16:45:56Z

@suneox Is there anything else I need to do?

@shahinyan11 Nope, another refactor will handle ESLint for this one.

suneox

The pipeline fails due to the changed files, and the scope of this issue is not related to withOnyx, so we can handle replace withOnyx in another task

cead22 · 2024-10-08T17:15:19Z

Reminder from the updated contributing guidelines

Open a pull request. It is required to complete every step and check every box in the PR Author Checklist. If a box has been checked without the action being taken, it will be a violation of Rule #2 and could lead to a warning being issued.

This item is checked and there's a warning on videos in both the PR author and reviewer checklists. Can you please report it or open an issue for it and link it here?

I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

suneox · 2024-10-08T17:48:17Z

@shahinyan11 could you please verify the author checklist item I verified there are no console errors? Last time, I only saw a pipeline error due to the Changed files ESLint check 🤔. Did we have any issue for this item?

cead22 · 2024-10-08T18:04:31Z

Let me know if there are more recent guidelines for updating withOnyx with useOnyx, but from this post, I think we should include those updates in this PR

cead22 · 2024-10-08T18:05:18Z

@shahinyan11 could you please verify the author checklist item I verified there are no console errors? Last time, I only saw a pipeline error due to the Changed files ESLint check 🤔. Did we have any issue for this item?

I unchecked this in both checklists because I saw console errors, and didn't see where those were fixed or reported

suneox · 2024-10-08T18:20:27Z

Let me know if there are more recent guidelines for updating withOnyx with useOnyx, but from this post, I think we should include those updates in this PR

@cead22 I got it, thank you for pointing this out!

@shahinyan11 We will handle pipeline in this PR

shahinyan11 · 2024-10-08T19:13:35Z

@suneox What console error are you talking about? Do you mean TRenderEngineProvider: Support for defaultProps ?
And about migration to useOnex I have a doubts. We have a logic in memo which depends on props.user. is it worth deleting withOnyx in this case ?

cead22 · 2024-10-08T21:52:42Z

@suneox What console error are you talking about? Do you mean TRenderEngineProvider: Support for defaultProps ?

Yes, that one on the Android Native video on the submitter checklist and the iOS native on the reviewer checklist. And Function components cannot be given ref... on the iOS native video of the reviewer checklist

And about migration to useOnex I have a doubts. We have a logic in memo which depends on props.user. is it worth deleting withOnyx in this case ?

I'm not sure actually, can you ask in #expensify-open-source please?

shahinyan11 · 2024-10-09T10:46:04Z

@suneox @cead22 I have added discussion in Slack about ESLint error, but I do not know whose answer should I follow

shahinyan11 · 2024-10-09T11:14:32Z

Yes, that one on the Android Native video on the submitter checklist and the iOS native on the reviewer checklist. And Function components cannot be given ref... on the iOS native video of the reviewer checklist
ure actually, can you ask in #expensify-open-source please?

@cead22 That warning exists in the main branch and does not appear from my changes. What should I do in this case

suneox · 2024-10-09T13:31:18Z

@cead22 That warning exists in the main branch and does not appear from my changes. What should I do in this case

Regarding the console errors that were raised previously, and we have other issues being addressed in #49062 and #49035

suneox · 2024-10-09T13:36:03Z

@suneox @cead22 I have added discussion in Slack about ESLint error, but I do not know whose answer should I follow

@shahinyan11 I’ve provided a solution in your thread, and I’m also waiting for confirmation in the C+ thread

shahinyan11 · 2024-10-09T13:49:32Z

@shahinyan11 I’ve provided a solution in your thread, and I’m also waiting for confirmation in the C+ thread

Should I implement your solution now or wait for confirmation?

suneox · 2024-10-09T16:08:10Z

Should I implement your solution now or wait for confirmation?

I’m still waiting for feedback, let’s wait for a confirmation.

shahinyan11 · 2024-10-09T19:19:24Z

@cead22 Could I set this point as checked without any additional comments

I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

since @suneox reported it in this comment

cead22 · 2024-10-09T22:07:56Z

Yup, that's great. The process works :)

cead22 · 2024-10-10T16:30:27Z

@suneox can you give this another review please, since a few things changed? Thanks

suneox · 2024-10-10T16:37:22Z

@suneox can you give this another review please, since a few things changed? Thanks

Sure, I’ll start the review and retest in about an hour

suneox · 2024-10-10T16:44:26Z

@shahinyan11 Could you please sync with the latest main? I’d like to verify the re-render after migrate to useOnyx. Thanks!

suneox · 2024-10-10T16:51:48Z

We don’t need to create a new file, we should just keep it in the ImageRenderer component as this pattern doesn’t exist in the code base

suneox

I have verified that migrating to useOnyx keeps the render times the same for ImageRenderer component

suneox · 2024-10-11T06:07:42Z

I have verified that migrating to useOnyx keeps the render times the same for ImageRenderer component

@cead22 the new change has been reviewed

OSBotify · 2024-10-11T16:06:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-15T03:30:53Z

🚀 Deployed to staging by https://github.com/cead22 in version: 9.0.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-17T01:45:48Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.49-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix infinity loading

a65c00d

melvin-bot Bot requested review from suneox and removed request for a team October 8, 2024 14:55

suneox reviewed Oct 8, 2024

View reviewed changes

Comment thread ios/NewExpensify.xcodeproj/project.pbxproj Outdated

Revert extra changes

4fa044f

suneox reviewed Oct 8, 2024

View reviewed changes

Comment thread src/ROUTES.ts Outdated

Comment Addressed

02f48cb

suneox approved these changes Oct 8, 2024

View reviewed changes

melvin-bot Bot requested a review from cead22 October 8, 2024 16:51

cead22 requested changes Oct 8, 2024

View reviewed changes

Comment thread src/ROUTES.ts Outdated

Comment Addressed

0caf525

shahinyan11 added 3 commits October 10, 2024 17:39

Migrate withOnyx to useOnyx

5b2a258

Run prettier

de94b8a

Fix ESLint errors

0197cba

suneox reviewed Oct 10, 2024

View reviewed changes

Comment thread src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.tsx Outdated

shahinyan11 added 2 commits October 10, 2024 21:50

Transver ImageRenderWrapper in ImageRander.ts file

2568541

Fix ESLint errors

bf05ded

suneox reviewed Oct 10, 2024

View reviewed changes

Comment thread src/components/HTMLEngineProvider/HTMLRenderers/ImageRenderer.tsx Outdated

shahinyan11 added 2 commits October 10, 2024 22:18

Pull main

7df5346

run prettier

3da847b

suneox approved these changes Oct 11, 2024

View reviewed changes

cead22 approved these changes Oct 11, 2024

View reviewed changes

cead22 merged commit 45a3a13 into Expensify:main Oct 11, 2024

github-actions Bot mentioned this pull request Oct 15, 2024

Deploy Checklist: New Expensify 2024-10-15 #50764

Closed

71 tasks

izarutskaya mentioned this pull request Oct 16, 2024

[$250] Android-Chat-App becomes unresponsive after pasting specific content. #50861

Closed

6 tasks

melvin-bot Bot mentioned this pull request Oct 17, 2024

[HOLD for payment 2024-10-24] [$250] Search - Attachment from qa.guide loads infinitely when opened in Search #50006

Closed

6 tasks

Uh oh!

Conversation

shahinyan11 commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 8, 2024

Uh oh!

Uh oh!

Uh oh!

suneox commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

suneox commented Oct 8, 2024

Uh oh!

shahinyan11 commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suneox commented Oct 8, 2024

Uh oh!

shahinyan11 commented Oct 8, 2024

Uh oh!

suneox commented Oct 8, 2024

Uh oh!

suneox left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cead22 commented Oct 8, 2024

Uh oh!

suneox commented Oct 8, 2024

Uh oh!

cead22 commented Oct 8, 2024

Uh oh!

cead22 commented Oct 8, 2024

Uh oh!

suneox commented Oct 8, 2024

Uh oh!

shahinyan11 commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cead22 commented Oct 8, 2024

Uh oh!

shahinyan11 commented Oct 9, 2024

Uh oh!

shahinyan11 commented Oct 9, 2024

Uh oh!

suneox commented Oct 9, 2024

Uh oh!

suneox commented Oct 9, 2024

Uh oh!

shahinyan11 commented Oct 9, 2024

Uh oh!

suneox commented Oct 9, 2024

Uh oh!

shahinyan11 commented Oct 9, 2024

Uh oh!

cead22 commented Oct 9, 2024

Uh oh!

cead22 commented Oct 10, 2024

Uh oh!

suneox commented Oct 10, 2024

Uh oh!

suneox commented Oct 10, 2024

Uh oh!

suneox Oct 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

suneox left a comment

Choose a reason for hiding this comment

shahinyan11 commented Oct 8, 2024 •

edited

Loading

suneox commented Oct 8, 2024 •

edited

Loading

shahinyan11 commented Oct 8, 2024 •

edited

Loading

shahinyan11 commented Oct 8, 2024 •

edited

Loading