[QBD] [Export] Preferred exporter page by ZhenjaHorbach · Pull Request #50297 · Expensify/App

ZhenjaHorbach · 2024-10-05T17:42:20Z

Details

[QBD] [Export] Preferred exporter page

Fixed Issues

$ #49708
PROPOSAL:

Tests

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Connect your workspace to QBD in OldDot. (Help doc)
Set multiple admins for the current workspace

Sign in on an account above
Go to any Workspace -> Accounting
Click on "Export" menu under QuickBooks Desktop connection
Click on Preferred exporter
Verify that there is a list of admins on the screen and after selecting one of them, it becomes the current exporter

Verify that no errors appear in the JS console

Offline tests

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Connect your workspace to QBD in OldDot. (Help doc)
Set multiple admins for the current workspace

Sign in on an account above
Go to any Workspace -> Accounting
Click on "Export" menu under QuickBooks Desktop connection
Click on Preferred exporter
Verify that there is a list of admins on the screen and after selecting one of them, it becomes the current exporter

QA Steps

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Connect your workspace to QBD in OldDot. (Help doc)
Set multiple admins for the current workspace

Sign in on an account above
Go to any Workspace -> Accounting
Click on "Export" menu under QuickBooks Desktop connection
Click on Preferred exporter
Verify that there is a list of admins on the screen and after selecting one of them, it becomes the current exporter

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…ther Api

melvin-bot · 2024-10-09T19:09:49Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-10-09T19:10:38Z

@Pujan92
Sorry for assignment
But we already have reviewers for this project !

ZhenjaHorbach · 2024-10-09T19:13:40Z

@hoangzinh
@lakchote

The PR will be completely ready when this PR is merged !

lakchote · 2024-10-11T14:47:31Z

@ZhenjaHorbach #50234 has been merged

ZhenjaHorbach · 2024-10-11T14:48:37Z

@ZhenjaHorbach #50234 has been merged

Thanks !
This PR will be completely ready soon!

ZhenjaHorbach · 2024-10-11T15:50:43Z

@hoangzinh
@lakchote

PR is ready !

hoangzinh · 2024-10-12T02:29:46Z

-            title: qbdConfig?.export?.exporter ?? policyOwner,
-            subscribedSettings: [CONST.QUICKBOOKS_CONFIG.EXPORT],
+            onPress: () => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_PREFERRED_EXPORTER.getRoute(policyID)),
+            title: qbdConfig?.export.exporter ?? policyOwner,


Suggested change

title: qbdConfig?.export.exporter ?? policyOwner,

title: qbdConfig?.export?.exporter ?? policyOwner,

Do we miss a safe operator here?

hoangzinh · 2024-10-14T09:40:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-14.at.16.53.16.android.mov

Android: mWeb Chrome

Screen.Recording.2024-10-14.at.16.56.21.android.chrome.mov

iOS: Native

Screen.Recording.2024-10-14.at.16.56.51.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-10-14.at.16.58.01.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-14.at.16.49.13.web.mov

MacOS: Desktop

Screen.Recording.2024-10-14.at.16.50.19.desktop.mov

hoangzinh · 2024-10-14T10:28:27Z

Auto-assignment is not working. @lakchote all yours

OSBotify · 2024-10-14T14:16:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-15T03:30:44Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2024-10-16T23:36:36Z

Team is struggling to connect here

Guided by https://help.expensify.com/articles/expensify-classic/connections/quickbooks-desktop/Connect-To-QuickBooks-Desktop, we downloaded WebConnector and QBO Desktop on the machine. Now we have to activate QBO Desktop.

github-actions · 2024-10-17T01:45:39Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.49-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

s77rt · 2025-03-08T21:08:05Z

+            if (row.value !== currentExporter) {
+                QuickbooksDesktop.updateQuickbooksDesktopPreferredExporter(policyID, row.value, currentExporter);
+            }
+            Navigation.goBack(ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_DESKTOP_PREFERRED_EXPORTER.getRoute(policyID));


We should return to the export page not the same page.

ZhenjaHorbach added 11 commits October 5, 2024 19:41

create draft screens for QuickbooksDesktopPreferredExporterConfiguration

9654dd0

fix conflicts

f14e5a4

remove some TODO

ce07ab7

fix conflicts

c7ec555

remove quickbooksDesktop file

711176e

return quickbooksDesktop file

ebd413e

refactor code

ebba8f7

update QuickbooksDesktopPreferredExporterConfigurationPage to use ano…

8c7352a

…ther Api

revert some changes

3479824

update subscribedExportSettings

6287fc2

add onExportPagePress for QBD

5767d0a

ZhenjaHorbach marked this pull request as ready for review October 9, 2024 19:09

ZhenjaHorbach requested a review from a team as a code owner October 9, 2024 19:09

melvin-bot Bot requested review from Pujan92 and removed request for a team October 9, 2024 19:09

lakchote requested review from hoangzinh and lakchote and removed request for Pujan92 October 10, 2024 08:18

ZhenjaHorbach added 5 commits October 11, 2024 17:16

fix conflicts

c281a9c

fix conflicts x2

336d3e9

update API command

8419962

refactor some code

91694be

refactor code x2

1ec6fcf

hoangzinh reviewed Oct 12, 2024

View reviewed changes

add safe operator for exporter

3b4145f

hoangzinh approved these changes Oct 14, 2024

View reviewed changes

lakchote approved these changes Oct 14, 2024

View reviewed changes

lakchote merged commit 0bb5806 into Expensify:main Oct 14, 2024

github-actions Bot mentioned this pull request Oct 15, 2024

Deploy Checklist: New Expensify 2024-10-15 #50764

Closed

71 tasks

melvin-bot Bot mentioned this pull request Oct 17, 2024

[HOLD for payment 2024-10-24] [Wave Control] [QBD] [Export] Preferred exporter page #49708

Closed

lakchote mentioned this pull request Nov 11, 2024

[HOLD for payment 2024-11-21] QBD - Admin is not selected as default Preferred exporter after connecting to QBD #52134

Closed

8 tasks

s77rt reviewed Mar 8, 2025

View reviewed changes

s77rt mentioned this pull request Mar 8, 2025

[Due for payment 2025-03-10] [$125] QBD - User is not returned to Export tab after export date/preferred exporter selected #56974

Closed

8 tasks

	title: qbdConfig?.export.exporter ?? policyOwner,
	title: qbdConfig?.export?.exporter ?? policyOwner,

Uh oh!

Conversation

ZhenjaHorbach commented Oct 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 9, 2024

Uh oh!

ZhenjaHorbach commented Oct 9, 2024

Uh oh!

ZhenjaHorbach commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lakchote commented Oct 11, 2024

Uh oh!

ZhenjaHorbach commented Oct 11, 2024

Uh oh!

ZhenjaHorbach commented Oct 11, 2024

Uh oh!

hoangzinh Oct 12, 2024

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh commented Oct 14, 2024

Uh oh!

OSBotify commented Oct 14, 2024

Uh oh!

github-actions Bot commented Oct 15, 2024

Uh oh!

mvtglobally commented Oct 16, 2024

Uh oh!

github-actions Bot commented Oct 17, 2024

Uh oh!

s77rt Mar 8, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ZhenjaHorbach commented Oct 5, 2024 •

edited

Loading

ZhenjaHorbach commented Oct 9, 2024 •

edited

Loading

hoangzinh commented Oct 14, 2024 •

edited

Loading