Remove current_report so there is no redundant data being stored#50
Merged
Conversation
Contributor
Author
|
OK, so I went ahead and did that big refactor. Fun. I like it better now |
Contributor
|
Oops, conflicts now @tgolen |
hayata-suenaga
pushed a commit
that referenced
this pull request
Feb 1, 2024
…ixes Ideal nav/rbr gbr fixes
Deploying helpdot with
|
| Latest commit: |
88acdd4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://19c41935.helpdot.pages.dev |
4 tasks
rlinoz
pushed a commit
that referenced
this pull request
May 5, 2026
…osting Fix reviewer inline comments not posting due to missing allowed-rules.txt
73 tasks
|
@tgolen @coleaeason No QA steps, OK to checkoff this one? |
Contributor
|
🚀 Deployed to staging by https://github.com/coleaeason in version: 9.3.68-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
|
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.3.68-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the improvement we spoke of. This will remove the redundant data in localStorage and bind to the data properly in the header. Ultimately I'm not super excited about the boilerplate required here, so I might take this a step further to make it even easier for other components to do.