Skip to content

Add feedback to IOU on Max participants selection#4992

Merged
Julesssss merged 1 commit into
Expensify:mainfrom
parasharrajat:feedback
Sep 3, 2021
Merged

Add feedback to IOU on Max participants selection#4992
Julesssss merged 1 commit into
Expensify:mainfrom
parasharrajat:feedback

Conversation

@parasharrajat

@parasharrajat parasharrajat commented Sep 1, 2021

Copy link
Copy Markdown
Member

Details

Fixed Issues

$ #4616

Tests | QA Steps

  1. Open newDot on Mobile.
  2. Click FAB button>split Bill.
  3. Now enter the amount and continue.
  4. On the participant page start selecting participants.
  5. Ensure that you cannot select more than 8 participants and that the message is displayed

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

fg

iOS

Android

gg

@parasharrajat parasharrajat requested a review from a team as a code owner September 1, 2021 18:23
@MelvinBot MelvinBot requested review from marcaaron and removed request for a team September 1, 2021 18:23
@marcaaron marcaaron requested a review from Julesssss September 1, 2021 18:50
@marcaaron

Copy link
Copy Markdown
Contributor

Gonna let @Julesssss take this one. Can jump in if need.

@marcaaron marcaaron removed their request for review September 1, 2021 18:51
@Julesssss

Copy link
Copy Markdown
Contributor

Is this ready for review @parasharrajat? It's not clear to me as some platforms are missing.

@parasharrajat

Copy link
Copy Markdown
Member Author

@Julesssss Ready for review.

@Julesssss

Copy link
Copy Markdown
Contributor

Great work as always, thanks @parasharrajat.

BTW, I added a 5th step to your test just to make it absolutely clear for QA

@Julesssss

Copy link
Copy Markdown
Contributor

Tested iOS and Web.

@Julesssss Julesssss merged commit 504bb08 into Expensify:main Sep 3, 2021
@OSBotify

OSBotify commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.0.92-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@botify

botify commented Sep 3, 2021

Copy link
Copy Markdown

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-10. 🎊

@OSBotify

OSBotify commented Sep 4, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants