[HybridApp] Add shortcut support in HybridApp by staszekscp · Pull Request #48780 · Expensify/App

staszekscp · 2024-09-09T11:14:35Z

cc: @AndrewGable

Details

The PR fixes shortcuts on HybridApp

Fixed Issues

$ #47469
PROPOSAL: N/A

Tests

Long press app icon
Choose one of the shortcut options

Offline tests

QA Steps

Long press app icon
Choose one of the shortcut options

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

w_7885f0c3711c0af5eada7f0a4285608f992a8ff8-2024-09-09.12_28_52.432.mp4

Android: mWeb Chrome

N/A

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-09.at.14.26.10.mp4

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

N/A

MacOS: Desktop

N/A

war-in · 2024-09-09T12:55:16Z

-    const {initialURL} = useContext(InitialURLContext);
-
-    useEffect(() => {
-        if (!NativeModules.HybridAppModule || !initialURL || !initialURL.includes(ROUTES.TRANSITION_BETWEEN_APPS)) {
-            return;
-        }
-
-        Navigation.isNavigationReady().then(() => {
-            Navigation.navigate(initialURL);
-        });
-    }, [initialURL]);
-


melvin-bot · 2024-09-09T13:50:37Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2024-09-10T08:13:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

aimane-chnaif

Code looks good.
I am not able to test correctly since this requires HybridApp access.

aimane-chnaif · 2024-09-10T08:22:26Z

@@ -1425,6 +1425,8 @@ const ROUTES = {
 const HYBRID_APP_ROUTES = {
    MONEY_REQUEST_CREATE: '/request/new/scan',
    MONEY_REQUEST_SUBMIT_CREATE: '/submit/new/scan',


NAB: Isn't it better to rename this to MONEY_REQUEST_CREATE_TAB_SCAN?

Yeah, agree with this minor improvement.

Updated! 😄

melvin-bot · 2024-09-10T08:48:57Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #47469 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

trjExpensify · 2024-09-10T09:24:01Z

@staszekscp looking at the video at the OP, did you action on this one? I can still see Start GPS as the menu label name.

Replace Start GPS with Log distance.

when set to boot NewDot, open Submit expense > Distance

when set to boot OldDot, open Start GPS page like today.

Julesssss · 2024-09-10T09:47:03Z

@staszekscp looking at the video at the OP, did you action on this one? I can still see Start GPS as the menu label name.

Replace Start GPS with Log distance.

when set to boot NewDot, open Submit expense > Distance

when set to boot OldDot, open Start GPS page like today.

Just holding on this.

Julesssss

Nice work, just holding on two comments above

github-actions · 2024-09-10T10:21:35Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48780/NewExpensify.dmg	https://48780.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

staszekscp · 2024-09-10T12:31:33Z

@trjExpensify @Julesssss Yeah, I've tested the Start GPS also, just didn't include it into the recording!

Just FYI, because I've noticed you've fired an ad-hoc build: The shortcuts work only on HybridApp, since there is no support in ND yet (it requires some additional native changes)

w_5c033b370f343327a18046afe597cc6e3b2a7d27-2024-09-10.12_29_48.834.mp4

w_02412833f2192bece42b2429357b5fb5feb90fba-2024-09-10.12_29_41.456.mp4

trjExpensify · 2024-09-10T12:37:59Z

@trjExpensify @Julesssss Yeah, I've tested the Start GPS also, just didn't include it into the recording!

Right, but the button label is still showing as Start GPS when we're saying to change it to Log distance because a GPS feature doesn't exist on NewDot.

staszekscp · 2024-09-10T12:46:29Z

Right, but the button label is still showing as Start GPS when we're saying to change it to Log distance because a GPS feature doesn't exist on NewDot.

Oh, sorry! I've missed that! In that case, we'll have to change it in the Mobile-Expensify repo, I'll do it in a minute

staszekscp · 2024-09-10T13:13:13Z

@trjExpensify The PR fixing the label is opened!

trjExpensify · 2024-09-10T13:32:20Z

@trjExpensify The PR fixing the label https://github.com/Expensify/Mobile-Expensify/pull/13086!

Excellent, thanks!

Julesssss

Perfect

Julesssss · 2024-09-10T13:39:16Z

Linked PR mentioned above is also merged 👍

OSBotify · 2024-09-10T13:50:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

add shortcut support in hybridapp

2e82d3c

war-in approved these changes Sep 9, 2024

View reviewed changes

staszekscp marked this pull request as ready for review September 9, 2024 13:50

staszekscp requested a review from a team as a code owner September 9, 2024 13:50

melvin-bot Bot requested review from aimane-chnaif and removed request for a team September 9, 2024 13:50

trjExpensify mentioned this pull request Sep 9, 2024

[HybridApp] [$250] Update 3DTouch/ForceTouch menu so it's not broken when set to boot the NewDot experience on Hybrid #47469

Closed

6 tasks

AndrewGable previously approved these changes Sep 10, 2024

View reviewed changes

aimane-chnaif approved these changes Sep 10, 2024

View reviewed changes

Julesssss self-requested a review September 10, 2024 09:09

Julesssss reviewed Sep 10, 2024

View reviewed changes

Julesssss added the Ready To Build label Sep 10, 2024

update route name

8ee9f53

staszekscp dismissed AndrewGable’s stale review via 8ee9f53 September 10, 2024 12:33

Julesssss approved these changes Sep 10, 2024

View reviewed changes

Julesssss merged commit 286b945 into Expensify:main Sep 10, 2024

github-actions Bot mentioned this pull request Sep 11, 2024

Deploy Checklist: New Expensify 2024-09-11 #48954

Closed

58 tasks

Uh oh!

Conversation

staszekscp commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

war-in Sep 9, 2024

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Sep 9, 2024

Uh oh!

aimane-chnaif commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

Julesssss Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

staszekscp Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

Julesssss Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Sep 10, 2024

Uh oh!

trjExpensify commented Sep 10, 2024

Uh oh!

Julesssss commented Sep 10, 2024

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 10, 2024

Uh oh!

staszekscp commented Sep 10, 2024

Uh oh!

trjExpensify commented Sep 10, 2024

Uh oh!

staszekscp commented Sep 10, 2024

Uh oh!

staszekscp commented Sep 10, 2024

Uh oh!

trjExpensify commented Sep 10, 2024

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Sep 10, 2024

Uh oh!

OSBotify commented Sep 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

staszekscp commented Sep 9, 2024 •

edited

Loading

aimane-chnaif commented Sep 10, 2024 •

edited

Loading