Added new flow for missing personal details by shubham1206agra · Pull Request #48775 · Expensify/App

shubham1206agra · 2024-09-09T08:56:49Z

Details

Fixed Issues

$ #48487

Tests

Issue a card where personal details are missing.
Observe you see a Add personal details button in Workspace chat.
Click on Add personal details, and fill the details.
Observe that your private personal details got filled, and you no longer see Add personal details button.

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screen.Recording.2024-09-11.at.7.10.11.PM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

allgandalf · 2024-09-09T20:00:25Z

@shubham1206agra when do you think you can open it up for review

mountiny · 2024-09-09T20:47:52Z

@shubham1206agra This is the API requirement:

command name: SetMissingPersonalDetailsAndShipExpensifyCard
required params:

            'legalFirstName' => $_REQUEST['legalFirstName'] ?? '',
            'legalLastName' => $_REQUEST['legalLastName'] ?? '',
            'phoneNumber' => $_REQUEST['phoneNumber'] ?? '',
            'addressCity' => $_REQUEST['addressCity'] ?? '',
            'addressStreet' => $_REQUEST['addressStreet'] ?? '',
            'addressStreet2' => $_REQUEST['addressStreet2'] ?? '',
            'addressZip' => $_REQUEST['addressZip'] ?? '',
            'addressCountry' => $_REQUEST['addressCountry'] ?? '',
            'addressState' => $_REQUEST['addressState'] ?? '',
            'dob' => $_REQUEST['dob'] ?? '',
            'cardID' => $_REQUEST['cardID'] ?? 0,

The important part is that we will only ship one card provided the cardID. We need to make some larger changes to enable shipping more cards in one call.

So to pass the cardID, find a first card in the NOT_ISSUED state on this card feed (get the workspace chat policyID -> find the workspace feed card list and get the first card you find there)

This will be fine for now and we will update the backend to handle shipping all the not issued cards at once.

shubham1206agra · 2024-09-10T09:57:39Z

    const policyID = policy?.id;
    const workspaceAccountID = policy?.workspaceAccountID ?? -1;
-    const [cardsList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${workspaceAccountID.toString()}${CONST.EXPENSIFY_CARD.BANK}`);
+    const [cardsList] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${workspaceAccountID.toString()}_${CONST.EXPENSIFY_CARD.BANK}`);


@mountiny This was causing a minor bug where the toggle of Expensify card is not disabled even after card was added in More features page.

@mountiny i am not sure about this change, i faintly remember we skipped the _ on purpose

bump @mountiny on the ^

This is correct, there should be _

App/src/libs/actions/Card.ts

Line 335 in 4e0a193

key: `${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${workspaceAccountID}_${CONST.EXPENSIFY_CARD.BANK}`,

melvin-bot · 2024-09-10T10:50:54Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2024-09-10T10:50:59Z

@dubielzyk-expensify @mountiny One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2024-09-10T10:51:27Z

Screen.Recording.2024-09-10.at.4.10.07.PM.mov

@Expensify/design Video for your reference.

allgandalf · 2024-09-11T11:47:23Z

I added address for one member, then i added another user who doesn't have personal details, but this time i directly get the message that the card has been shipped (note that the new user doesn't have personal details) @shubham1206agra

allgandalf · 2024-09-11T11:49:22Z

@shubham1206agra i guess we should check state of every individual member here

allgandalf · 2024-09-11T12:03:48Z

Oh and also, should the workspace admin be able to see the add shipping address button ? currently if i issue card to a member and if my own personal details are missing then i am able to see the button meant for another user, and if i go on to add address then my personal details are filled when i complete the form and not the member who we are supposed to ship the card

allgandalf · 2024-09-11T12:08:39Z

can you also fix lint @shubham1206agra

allgandalf · 2024-09-11T12:12:47Z

Bug:

If i login in a member account which has pending action to add details to ship the card, and then i manually update the address, legal name, dob from profile and go back to chat, i still see the add address button

Screen.Recording.2024-09-11.at.5.41.22.PM.mov

shubham1206agra · 2024-09-11T12:14:18Z

Bug:

If i login in a member account which has pending action to add details to ship the card, and then i manually update the address, legal name, dob from profile and go back to chat, i still see the add address button

This is expected as you have not added phone number 😆

mountiny · 2024-09-11T12:17:47Z

If i login in a member account which has pending action to add details to ship the card, and then i manually update the address, legal name, dob from profile and go back to chat, i still see the add address button

There is still a phone number that they need to add

allgandalf · 2024-09-11T12:55:14Z

@shubham1206agra On admin side I still see the card has been shipped message for new members who do not have their personal details filled

allgandalf · 2024-09-11T19:19:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-09-12.at.3.11.46.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-09-12.at.3.09.08.AM.mov

iOS: Native

Screen.Recording.2024-09-12.at.3.05.27.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-09-12.at.3.02.49.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-12.at.2.54.57.AM.mov

MacOS: Desktop

Screen.Recording.2024-09-12.at.2.59.58.AM.mov

allgandalf · 2024-09-11T21:10:43Z

Bug:

Add new member
Issue them physical card
Login with the new member
click on add shipping details
Observe that in api response we get that Expensify card not found

Also signout and signin again with the member account after submitting the address first ime, we again get add shipping details button

Screen.Recording.2024-09-12.at.2.41.33.AM.mov

allgandalf

After a lot of back and forth, lets get this one shipped and come up with a follow up to clean few things from this PR slack here

mountiny

We will need to make some changes to this flow for sure but its great to have it in place. Thanks @shubham1206agra for stepping up and to @allgandalf for a great review too

We will follow up with improvements soon

mountiny · 2024-09-11T23:11:24Z

        getRoute: (policyID: string) => `restricted-action/workspace/${policyID}` as const,
    },
+    MISSING_PERSONAL_DETAILS: {
+        route: 'missing-personal-details/workspace/:policyID',


I think we could remove the missing from this url and just leave it as personal details

OSBotify · 2024-09-12T02:45:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-12T21:37:36Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-13T22:45:18Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.34-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

shubham1206agra added 2 commits September 9, 2024 14:26

Added new flow for missing personal details

7479936

Style fixes

3c732d8

mountiny self-requested a review September 9, 2024 09:31

mountiny assigned shubham1206agra Sep 9, 2024

mountiny requested review from DylanDylann and allgandalf September 9, 2024 09:32

shubham1206agra added 3 commits September 9, 2024 15:34

Added CountryPicker and StatePicker

840a3dc

Fixes styling issue

9aa228d

Fixes page not scrolling

41237f0

shubham1206agra commented Sep 10, 2024

View reviewed changes

Comment thread src/components/ReportActionItem/IssueCardMessage.tsx

shubham1206agra and others added 3 commits September 10, 2024 10:55

Added date of birth step

70c4609

Merge branch 'Expensify:main' into missing-personal-details

038b9e5

Fix button condition

6a3101c

mountiny reviewed Sep 10, 2024

View reviewed changes

Comment thread src/components/ReportActionItem/IssueCardMessage.tsx

shubham1206agra added 4 commits September 10, 2024 13:11

Fix date range

baaa455

Added policyID as a parameter in route

98d277c

Added withPolicyAndFullscreenLoading hook to the page

745adf1

Fixed minor bug

68dbc64

shubham1206agra commented Sep 10, 2024

View reviewed changes

Added API command

265376e

shubham1206agra marked this pull request as ready for review September 10, 2024 10:50

shubham1206agra requested a review from a team as a code owner September 10, 2024 10:50

melvin-bot Bot requested review from dubielzyk-expensify and mountiny September 10, 2024 10:50

melvin-bot Bot removed the request for review from a team September 10, 2024 10:50

allgandalf reviewed Sep 11, 2024

View reviewed changes

Comment thread src/pages/MissingPersonalDetails/substeps/Address.tsx

shubham1206agra commented Sep 11, 2024

View reviewed changes

Comment thread src/pages/MissingPersonalDetails/index.tsx Outdated

shubham1206agra commented Sep 11, 2024

View reviewed changes

Comment thread src/pages/MissingPersonalDetails/index.tsx Outdated

Apply suggestions from code review

358e154

shubham1206agra commented Sep 11, 2024

View reviewed changes

Comment thread src/pages/MissingPersonalDetails/index.tsx Outdated

shubham1206agra commented Sep 11, 2024

View reviewed changes

Comment thread src/pages/MissingPersonalDetails/index.tsx Outdated

Apply suggestions from code review

9f3e94b

Fix condition

826096c

shubham1206agra and others added 3 commits September 11, 2024 18:32

Merge branch 'Expensify:main' into missing-personal-details

bee65db

Fix conditions

040813e

Fix phone number parameter

72b265f

allgandalf approved these changes Sep 11, 2024

View reviewed changes

mountiny approved these changes Sep 12, 2024

View reviewed changes

mountiny merged commit 336e478 into Expensify:main Sep 12, 2024

github-actions Bot mentioned this pull request Sep 12, 2024

Deploy Checklist: New Expensify 2024-09-12 #49139

Closed

30 tasks

IuliiaHerets mentioned this pull request Sep 13, 2024

[$250] [Workspace Feeds] Copied content & LHN preview do not follow "x added shipping details" message #49149

Closed

6 tasks

shubham1206agra deleted the missing-personal-details branch February 3, 2025 17:49

Uh oh!

Conversation

shubham1206agra commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

allgandalf commented Sep 9, 2024

Uh oh!

mountiny commented Sep 9, 2024

Uh oh!

Uh oh!

Uh oh!

shubham1206agra Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allgandalf Sep 10, 2024

Choose a reason for hiding this comment

Uh oh!

allgandalf Sep 11, 2024

Choose a reason for hiding this comment

Uh oh!

mountiny Sep 11, 2024

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Sep 10, 2024

Uh oh!

melvin-bot Bot commented Sep 10, 2024

Uh oh!

shubham1206agra commented Sep 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

allgandalf commented Sep 11, 2024

Uh oh!

allgandalf commented Sep 11, 2024

Uh oh!

allgandalf commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allgandalf commented Sep 11, 2024

Uh oh!

Uh oh!

Uh oh!

allgandalf commented Sep 11, 2024

Uh oh!

shubham1206agra commented Sep 11, 2024

Uh oh!

mountiny commented Sep 11, 2024

Uh oh!

allgandalf commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allgandalf commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allgandalf left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Sep 11, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Sep 12, 2024

Uh oh!

shubham1206agra commented Sep 9, 2024 •

edited

Loading

shubham1206agra Sep 10, 2024 •

edited

Loading

allgandalf commented Sep 11, 2024 •

edited

Loading

allgandalf commented Sep 11, 2024 •

edited

Loading

allgandalf commented Sep 11, 2024 •

edited

Loading

allgandalf commented Sep 11, 2024 •

edited

Loading

allgandalf left a comment •

edited

Loading