Skip to content

Revert PR 47418#47998

Merged
tgolen merged 1 commit into
mainfrom
cristi_revert-PR47418
Aug 26, 2024
Merged

Revert PR 47418#47998
tgolen merged 1 commit into
mainfrom
cristi_revert-PR47418

Conversation

@cristipaval

@cristipaval cristipaval commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

Reverts #47418

Fixes
$ #47897

@cristipaval cristipaval self-assigned this Aug 26, 2024
@cristipaval cristipaval requested a review from a team as a code owner August 26, 2024 12:52
@melvin-bot melvin-bot Bot requested review from tgolen and removed request for a team August 26, 2024 12:53
@melvin-bot

melvin-bot Bot commented Aug 26, 2024

Copy link
Copy Markdown

@tgolen Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@tgolen

tgolen commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

This is a straight revert so tests and checklist is not necessary.

@tgolen tgolen merged commit f89cb0f into main Aug 26, 2024
@tgolen tgolen deleted the cristi_revert-PR47418 branch August 26, 2024 15:04
@melvin-bot

melvin-bot Bot commented Aug 26, 2024

Copy link
Copy Markdown

@tgolen looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Aug 26, 2024
@tgolen tgolen removed the Emergency label Aug 26, 2024
@tgolen

tgolen commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

@cristipaval I assume you want to CP this?

@cristipaval

cristipaval commented Aug 26, 2024

Copy link
Copy Markdown
Contributor Author

@cristipaval I assume you want to CP this?

yes, I'll do it

@cristipaval cristipaval mentioned this pull request Aug 26, 2024
Merged
50 tasks
OSBotify pushed a commit that referenced this pull request Aug 26, 2024
@tgolen @OSBotify
Merge pull request #47998 from Expensify/cristi_revert-PR47418
fd431b8 
Revert PR 47418

(cherry picked from commit f89cb0f)

(CP triggered by puneetlath)
@os-botify os-botify Bot mentioned this pull request Aug 26, 2024
Merged
@github-actions github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Aug 26, 2024
@OSBotify

OSBotify commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

puneetlath added a commit that referenced this pull request Aug 26, 2024
@puneetlath
Merge pull request #48009 from Expensify/puneetlath-cherry-pick-stagi…
f54f9f1 
…ng-47998-1

🍒 Cherry pick PR #47998 to staging 🍒
OSBotify pushed a commit that referenced this pull request Aug 26, 2024
@puneetlath @OSBotify
Merge pull request #48009 from Expensify/puneetlath-cherry-pick-stagi…
3a61e15 
…ng-47998-1

🍒 Cherry pick PR #47998 to staging 🍒

(cherry picked from commit f54f9f1)

(CP triggered by puneetlath)
@github-actions github-actions Bot mentioned this pull request Aug 26, 2024
Closed
50 tasks
@OSBotify

OSBotify commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.24-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify

OSBotify commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.24-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgolen tgolen tgolen approved these changes

Assignees

@cristipaval cristipaval

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cristipaval @tgolen @OSBotify