Popover for remove copilot and change access level

[rushatgabhane]

Details

Fixed Issues

$ #46921
$ #46925
PROPOSAL:

Tests

Pre-req: be on copilot beta.

Add copilot

1. Go to settings > security
2. Add copilot
3. Set access level as limited

Change access level

1. Go to settings > security
2. Click on an existing copilot
3. Verify you see a popover menu
4. Click change access level
5. Change access level to full
6. Enter magic code
7. Verify access level has changed.

Remove copilot

1. Go to settings > security
2. Click on an existing copilot
3. Verify you see a popover menu
4. Click remove copilot
5. Verify you see a modal
6. Confirm
7. Verify that copilot is removed.

• Verify that no errors appear in the JS console

Offline tests

QA Steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-09.at.12.38.57.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-10-09.at.12.19.24.mov

iOS: mWeb Safari

Screen.Recording.2024-10-09.at.12.34.53.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-29.at.12.56.22.mov

MacOS: Desktop

Screen.Recording.2024-10-09.at.11.51.56.mov

[rushatgabhane]

hmmm, tried Modal.close but it didn't work

trying other ideas

[dangrous]

How's the investigation going?

[rushatgabhane]

@allgandalf @dangrous all resolved and screenshots updated.

[allgandalf]

Lets merge this 🚀

[dangrous]

looking now! @allgandalf can you check off the checklist (iOS native test) if that's all good? The bot is sad.

[dangrous]

Okay so in my testing, updating a role works great but removing a delegate doesn't work at all. It looks like selectedDelegate is undefined, and so nothing is getting passed to removeDelegate so it's returning early. Can you take a look at that? I don't think it's something in my setup, I made a fresh account, validated it, and added a copilot. I added a console.log to confirm that setSelectedDelegate is running on the pop up menu and it looks like it is... but for some reason it's not working right. Is it just me?

[allgandalf]

looking now! @allgandalf can you check off the checklist (iOS native test) if that's all good? The bot is sad.

Didn't check off on purpose!

[allgandalf]

Okay so in my testing, updating a role works great but removing a delegate doesn't work at all. It looks like selectedDelegate is undefined, and so nothing is getting passed to removeDelegate so it's returning early. Can you take a look at that? I don't think it's something in my setup, I made a fresh account, validated it, and added a copilot. I added a console.log to confirm that setSelectedDelegate is running on the pop up menu and it looks like it is... but for some reason it's not working right. Is it just me?

Yeah i didn't check off the checklist for the same reason, wanted your 👀 as well! @rushatgabhane can you please look into this

[rushatgabhane]

interestingg

[rushatgabhane]

ahh when i merged main in b69cca3, it broke it.

There is a race condition between setSelectedDelegate(undefined) in popover onClose and remove modal having the delegate

[rushatgabhane]

Fixed @allgandalf @dangrous

Screen.Recording.2024-10-10.at.08.04.08.mov

[allgandalf]

I will test the flow again later today and approve

[dangrous]

Awesome! Thanks for sussing that out

[allgandalf]

Tested on iOS native, works great

[dangrous]

Okay let's do it! I found a very edge case bug where the popover shows up in a weird place if you have changed your screen size on web since loading the page / opening it last, but we have a number of edge case bugs that exist about changing screen size so I don't think it's a blocker, not really a thing we specifically support.

Thank you both for all your hard work on this!

I'm going to merge, and let's just keep an eye out for any additional bugs

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.49-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[alitoshmatov]

When the option is selected user is required to authenticate using magic code, which means this option is not selected yet. Thus when user just goes back without authenticating this option will be selected even though user did not complete required steps. https://github.com/Expensify/App/pull/53677/files

[FitseTLT]

We should have cleared pending fields on failureData as the above code caused #72381