Skip to content

fix Final confirmation is displayed in the review duplicates flow #47513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nkuoch merged 1 commit into from
Aug 19, 2024
Merged

fix Final confirmation is displayed in the review duplicates flow #47513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/libs/TransactionUtils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,11 +954,6 @@ function compareDuplicateTransactionFields(transactionID: string): {keep: Partia
return items.every((item) => lodashIsEqual(item?.comment, firstTransaction?.comment));
}

// Helper function to check if all comments exist
function doAllCommentsExist(items: Array<OnyxEntry<Transaction>>, firstTransaction: OnyxEntry<Transaction>) {
return items.every((item) => !!item?.comment?.comment === !!firstTransaction?.comment?.comment);
}

// Helper function to check if all fields are equal for a given key
function areAllFieldsEqual(items: Array<OnyxEntry<Transaction>>, keyExtractor: (item: OnyxEntry<Transaction>) => string) {
const firstTransaction = transactions[0];
Expand All @@ -981,10 +976,9 @@ function compareDuplicateTransactionFields(transactionID: string): {keep: Partia

if (fieldName === 'description') {
const allCommentsAreEqual = areAllCommentsEqual(transactions, firstTransaction);
const allCommentsExist = doAllCommentsExist(transactions, firstTransaction);
const allCommentsAreEmpty = isFirstTransactionCommentEmptyObject && transactions.every((item) => item?.comment === undefined);

if (allCommentsAreEqual || allCommentsExist || allCommentsAreEmpty) {
if (allCommentsAreEqual || allCommentsAreEmpty) {
keep[fieldName] = firstTransaction?.comment?.comment ?? firstTransaction?.comment;
} else {
processChanges(fieldName, transactions, keys);
Expand Down