-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add personalDetails and report length to fb trace metadata #46888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marcaaron
merged 17 commits into
Expensify:main
from
callstack-internal:details-metadata-in-fb-trace
Aug 12, 2024
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ad45153
feat: add personalDetails and report length to fb trace metadata
rinej 7ac2f1e
remove reports
rinej 3458e75
add reports
rinej cdaa9ce
move logic to ReportUtils
rinej c56dba5
add mock for Timing in jest tests, cleanup
rinej dc28083
cleanup
rinej ed66b75
fix tests
rinej ad9c247
fix unit tests
rinej 1a9f3a0
add custom metadata to fb trace
rinej 0a28b44
Merge branch 'main' into details-metadata-in-fb-trace
rinej 0a84ffb
cleanup
rinej 34d6279
refactor: changes after pr comments
rinej 38e12d6
Merge branch 'main' into details-metadata-in-fb-trace
rinej caab39b
move getAttributes to firebase module, add mocks for tests
rinej f7cf4ea
types refactor
rinej 26b1791
move get report length to reportConnection
rinej 7b50958
add Timing mock to global scope
rinej File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -323,6 +323,10 @@ function isPersonalDetailsEmpty() { | |
| return !personalDetails.length; | ||
| } | ||
|
|
||
| function getPersonalDetailsLength() { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NAB - probably we don't need a new method if we only use this one time. |
||
| return personalDetails.length; | ||
| } | ||
|
|
||
| export { | ||
| isPersonalDetailsEmpty, | ||
| getDisplayNameOrDefault, | ||
|
|
@@ -339,4 +343,5 @@ export { | |
| createDisplayName, | ||
| extractFirstAndLastNameFromAvailableDetails, | ||
| getNewAccountIDsAndLogins, | ||
| getPersonalDetailsLength, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,4 +44,8 @@ function getAllReportsNameMap() { | |
| return reportIDToNameMap; | ||
| } | ||
|
|
||
| export {getAllReports, getAllReportsNameMap}; | ||
| function getAllReportsLength() { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. |
||
| return Object.keys(allReports ?? {}).length; | ||
| } | ||
|
|
||
| export {getAllReports, getAllReportsNameMap, getAllReportsLength}; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB