fix: Design updates to Search rows on mobile by dominictb · Pull Request #44677 · Expensify/App

dominictb · 2024-07-01T11:37:45Z

Details

Fixed Issues

$ #44563
PROPOSAL: #44563 (comment)

Tests

Small screen device:

Open app
Go to /search/all?sortBy=date&sortOrder=desc
Verify these below behavior:

There is no tag from the bottom line under the merchant, and only show a Category if one is available
There is no Fold icon in front of Category
If no category exists, the Merchant line is vertically centered in the available space
If no Merchant exists, the description is displayed.

Large screen device:

Open app
Go to /search/all?sortBy=date&sortOrder=desc
Verify it works as it is

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-01.at.21.24.00.mov

Android: mWeb Chrome

output.mp4

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-07-01.at.19.02.58.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-01.at.21.18.59.mov

MacOS: Desktop

Screen.Recording.2024-07-01.at.21.17.16.mov

melvin-bot · 2024-07-01T14:50:15Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-07-01T16:44:05Z

The category should still be styled in the same gray text that it was before, looks like it's dark from the screenshots:

shawnborton · 2024-07-01T21:54:59Z

I think we need to make sure we are truncating Merchants/Descriptions after 1 line, looks like the descriptions can get quite long here:

dukenv0307 · 2024-07-02T03:43:31Z

                        transactionItem={item}
                        showTooltip={showTooltip}
-                        isLargeScreenWidth={false}
+                        isLargeScreenWidth={isLargeScreenWidth}


is it always true?

yes, in this case it's always false since we're still inside the if block

@dominictb Pls resolve this comments and other places as well

luacmartins · 2024-07-02T19:18:24Z

                        transactionItem={item}
                        showTooltip={showTooltip}
-                        isLargeScreenWidth={false}
+                        isLargeScreenWidth={isLargeScreenWidth}


yes, in this case it's always false since we're still inside the if block

dukenv0307 · 2024-07-03T07:43:43Z

@dominictb Pls resolve the comments above. Thanks

dominictb · 2024-07-03T07:45:26Z

Will take a look in a bit.

dominictb · 2024-07-04T03:55:27Z

@shawnborton @dukenv0307 I updated PR. Below are the changes:

Make sure the category should still be styled in the same gray text that it was before.
Make sure we are truncating Merchants/Descriptions after 1 line.

dukenv0307 · 2024-07-04T04:22:23Z

Seems good to me. @shawnborton can you take a look at the result above? Thanks

dukenv0307 · 2024-07-04T04:23:05Z

shawnborton · 2024-07-04T06:33:58Z

Looking good! Going to run a test build for easier testing, but thanks for making the changes!

github-actions · 2024-07-04T07:11:28Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/44677/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/44677/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/44677/NewExpensify.dmg	https://44677.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2024-07-04T07:25:41Z

Looking really great!

One small thing: I still see multiple lines for a super long description where I am purposely using line breaks to test...

Can you make sure that truncates after 1 line as well?

shawnborton · 2024-07-04T10:13:09Z

Oh and another thing we chatted about - the idea that the "View" buttons on mobile felt quite superfluous and we could just omit them entirely. It would look something more like this:

Thoughts @Expensify/design @luacmartins? Feels like we could make that change in this same PR while we are here.

luacmartins · 2024-07-04T16:16:18Z

I'm down to removing the button on mobile since they dont really do much and less components on screen means higher performance.

shawnborton · 2024-07-04T18:12:27Z

Works for me - let's see if @dubielzyk-expensify has any strong feelings too, though I do tend to agree that it will make the page feel a bit lighter.

dubielzyk-expensify · 2024-07-04T22:53:25Z

I like it 👍

shawnborton · 2024-07-05T07:36:43Z

Okay, let's remove the View button from mobile expenses then. @dominictb can you handle that one too please? Thanks!

dominictb · 2024-07-05T09:25:13Z

PR is updated to fix:

multiple lines for a super long description where I am purposely using line breaks to test.
let's remove the View button from mobile expenses then.

Result:

Screen.Recording.2024-07-05.at.16.23.29.mov

shawnborton · 2024-07-05T12:08:32Z

Lovely! Will also spin up a test build here, but we should be ready for final review. Thanks!

github-actions · 2024-07-05T12:46:05Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/44677/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/44677/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/44677/NewExpensify.dmg	https://44677.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2024-07-05T15:06:47Z

Looks great, let's get it into final review!

dukenv0307 · 2024-07-08T03:33:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

dukenv0307 · 2024-07-08T03:53:28Z

LGTM

luacmartins

LGTM

OSBotify · 2024-07-08T15:47:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-10T11:20:05Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:37:19Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

shawnborton · 2024-07-11T07:16:28Z

Hmm not sure what's going on but I just tested this on our latest TestFlight app and it looks like the View button still shows for all mobile rows. Any idea what happened there?

It also looks like the "Paid" button isn't aligned to the right edge of the top header area of the row either:

Can we do a quick follow up to address those issues? Thanks!

dominictb · 2024-07-11T09:13:59Z

View button still shows for all mobile rows

"Paid" button isn't aligned to the right

@shawnborton I am not sure about which PR caused that behavior, but I fixed this bug in PR.

Here is the result:

Screen.Recording.2024-07-11.at.16.11.41.mov

shawnborton · 2024-07-11T09:37:53Z

Perfect, thanks!

OSBotify · 2024-07-11T10:17:34Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-11T10:37:10Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-15T20:23:44Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Kicu · 2024-07-16T12:27:13Z

-                                isLargeScreenWidth={isLargeScreenWidth}
-                            />
-                        </View>
+                        {item.category && (


If category would be an empty string, then this code will result in lots of errors, because we would try to render a raw string inside a View.

I can fix it while doing my PR for Search advancedFilters, but wanted to mention it here since it's a bit surprising that this passed through both reviews.
CC @luacmartins

(Perhaps the return values of api changed after this was merged and in the past category would be undefined? )

Oh nice catch @Kicu. I can fix it now since it might lead to a crash on native. PR here

OSBotify · 2024-07-17T00:19:37Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

dominictb added 2 commits July 1, 2024 18:36

fix: Design updates to Search rows on mobile

4b55bd9

fix: lint

814baa7

dominictb mentioned this pull request Jul 1, 2024

[HOLD for payment 2024-07-23] [$250] [Search v1] Design updates to Search rows on mobile #44563

Closed

dominictb marked this pull request as ready for review July 1, 2024 14:50

dominictb requested a review from a team as a code owner July 1, 2024 14:50

melvin-bot Bot removed the request for review from a team July 1, 2024 14:50

melvin-bot Bot requested a review from dukenv0307 July 1, 2024 14:50

luacmartins self-requested a review July 1, 2024 16:20

shawnborton assigned shawnborton and unassigned shawnborton Jul 1, 2024

shawnborton self-requested a review July 1, 2024 16:42

shawnborton added the Ready To Build label Jul 1, 2024

This comment has been minimized.

Sign in to view

dukenv0307 reviewed Jul 2, 2024

View reviewed changes

luacmartins requested changes Jul 2, 2024

View reviewed changes

dominictb added 2 commits July 4, 2024 10:40

Fix: Merge main

6bc5b48

Fix: Category styles

c1b0ddb

Fix: Update passing isLargeScreenWidth logic

aba4a1b

dominictb added 3 commits July 5, 2024 15:18

merge main

d47954a

remove view button in mobile and display one line merchant

d6f9056

fix lint

f8df4cf

dukenv0307 approved these changes Jul 8, 2024

View reviewed changes

melvin-bot Bot requested a review from luacmartins July 8, 2024 03:53

luacmartins approved these changes Jul 8, 2024

View reviewed changes

luacmartins merged commit 8540bcf into Expensify:main Jul 8, 2024

github-actions Bot mentioned this pull request Jul 10, 2024

Deploy Checklist: New Expensify 2024-07-10 #45144

Closed

Kicu reviewed Jul 16, 2024

View reviewed changes

luacmartins mentioned this pull request Jul 16, 2024

Fix text in view error #45490

Merged

50 tasks

Uh oh!

Conversation

dominictb commented Jul 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Small screen device:

Large screen device:

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 1, 2024

Uh oh!

shawnborton commented Jul 1, 2024

Uh oh!

This comment has been minimized.

shawnborton commented Jul 1, 2024

Uh oh!

dukenv0307 Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

luacmartins Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Jul 4, 2024

Choose a reason for hiding this comment

Uh oh!

dominictb Jul 4, 2024

Choose a reason for hiding this comment

Uh oh!

luacmartins Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Jul 3, 2024

Uh oh!

dominictb commented Jul 3, 2024

Uh oh!

dominictb commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Jul 4, 2024

Uh oh!

dukenv0307 commented Jul 4, 2024

Uh oh!

shawnborton commented Jul 4, 2024

Uh oh!

github-actions Bot commented Jul 4, 2024

Uh oh!

shawnborton commented Jul 4, 2024

Uh oh!

shawnborton commented Jul 4, 2024

Uh oh!

luacmartins commented Jul 4, 2024

Uh oh!

shawnborton commented Jul 4, 2024

Uh oh!

dubielzyk-expensify commented Jul 4, 2024

Uh oh!

shawnborton commented Jul 5, 2024

Uh oh!

dominictb commented Jul 5, 2024

Uh oh!

shawnborton commented Jul 5, 2024

Uh oh!

github-actions Bot commented Jul 5, 2024

Uh oh!

shawnborton commented Jul 5, 2024

Uh oh!

dukenv0307 commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Jul 8, 2024

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

dominictb commented Jul 1, 2024 •

edited

Loading

dominictb commented Jul 4, 2024 •

edited

Loading

dukenv0307 commented Jul 8, 2024 •

edited

Loading

Kicu Jul 16, 2024 •

edited

Loading