Fix: Blue dot is not displayed over current user location by fedirjh · Pull Request #44023 · Expensify/App

fedirjh · 2024-06-19T17:05:57Z

Details

Fixed Issues

$ #43113
PROPOSAL: #43113 (comment)

Tests

Precondition: location access is disabled

Open the app and log in
Tap the FAB -> Submit expense -> Distance
Select do not allow on the pop-up and wait for the map to load
Tap the start point and select Use current location
Allow location access
Verify blue dot is displayed as the user's current location

Verify that no errors appear in the JS console

Offline tests

Same steps

QA Steps

Same steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

CleanShot.2024-06-20.at.12.47.20.mp4

Android: mWeb Chrome

CleanShot.2024-06-20.at.12.56.12.mp4

iOS: Native

CleanShot.2024-06-20.at.11.38.04.mp4

iOS: mWeb Safari

CleanShot.2024-06-20.at.11.42.44.mp4

MacOS: Chrome / Safari

CleanShot.2024-06-20.at.10.26.01.mp4

MacOS: Desktop

N/A

…ssSearch component

melvin-bot · 2024-06-19T17:06:02Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2024-06-20T12:16:33Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-06-20T16:17:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

web_3OCLQ1Cc.mp4

MacOS: Desktop

NA

ZhenjaHorbach · 2024-06-20T16:23:41Z

LGTM and everything works well 💪

dangrous · 2024-06-20T16:58:33Z

I'm seeing a bit of weird behavior if you move back to the first screen before turning on location services - the map moves to a different location temporarily, and then recenters on the blue dot. Is there another place we need to update the current location? It looks like the location it jumps to is the same as the apple default, maybe?

2024-06-20_12-55-36.mp4

fedirjh · 2024-06-21T12:25:39Z

the map moves to a different location temporarily, and then recenters on the blue dot. Is there another place we need to update the current location? It looks like the location it jumps to is the same as the apple default, maybe?

@dangrous When you press back, the map moves to the same location again here. This strange behavior is because the map adds animation when it moves to the user's location. We can fix this by avoiding the animation by passing a specific parameter animate: false,. However, I suggest that we also avoid moving to the same location altogether. I have already made this change and pushed it. Please let me know if you have a different opinion.

            mapRef.flyTo({
                center: [currentPosition.longitude, currentPosition.latitude],
                zoom: CONST.MAPBOX.DEFAULT_ZOOM,
+               animate: false,
            });

ZhenjaHorbach · 2024-06-21T12:40:00Z

I'm checking now
And the bug is partially reproducible

When we choose current location without permission and press go back
The map position will change slightly

But it doesn't look critical

2024-06-21.14.33.55.mov

fedirjh · 2024-06-22T14:27:37Z

And the bug is partially reproducible

@ZhenjaHorbach I was able to replicate that bug in staging as well. I have pushed a fix for it, could you please retest.

ZhenjaHorbach · 2024-06-23T21:05:53Z

And the bug is partially reproducible

@ZhenjaHorbach I was able to replicate that bug in staging as well. I have pushed a fix for it, could you please retest.

Thanks a lot for the fix !
Yes, now I can't reproduce this bug

LGTM

dangrous

This looks good and thanks for fixing that bug! I just have one question about the dependencies but if that's intentional then we're good to go!

OSBotify · 2024-06-24T20:24:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-25T20:09:46Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.2-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-03T19:39:03Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T10:57:35Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[Chore]: Update user location when fetching current location in Addre…

f31abe9

…ssSearch component

fedirjh marked this pull request as ready for review June 20, 2024 12:16

fedirjh requested a review from a team as a code owner June 20, 2024 12:16

melvin-bot Bot requested review from ZhenjaHorbach and removed request for a team June 20, 2024 12:16

ZhenjaHorbach approved these changes Jun 20, 2024

View reviewed changes

melvin-bot Bot requested a review from dangrous June 20, 2024 16:23

chore: Avoid nagivating to same location

6d1973b

chore: fix prettier

414f596

chore: Improve MapView navigation animation

8d1ae21

fedirjh requested a review from ZhenjaHorbach June 22, 2024 14:27

ZhenjaHorbach approved these changes Jun 23, 2024

View reviewed changes

dangrous approved these changes Jun 24, 2024

View reviewed changes

Comment thread src/components/MapView/MapView.website.tsx

dangrous merged commit 7489847 into Expensify:main Jun 24, 2024

github-actions Bot mentioned this pull request Jun 25, 2024

Deploy Checklist: New Expensify 2024-06-25 #44406

Closed

92 tasks

fedirjh deleted the fix-blue-dot-location branch July 2, 2024 16:29

melvin-bot Bot mentioned this pull request Jul 3, 2024

[HOLD for payment 2024-07-10] [$250] Distance - Blue dot does not set to current location after enabling location access #43113

Closed

6 tasks

Uh oh!

Conversation

fedirjh commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 19, 2024

Uh oh!

melvin-bot Bot commented Jun 20, 2024

Uh oh!

ZhenjaHorbach commented Jun 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jun 20, 2024

Uh oh!

dangrous commented Jun 20, 2024

Uh oh!

fedirjh commented Jun 21, 2024

Uh oh!

ZhenjaHorbach commented Jun 21, 2024

Uh oh!

fedirjh commented Jun 22, 2024

Uh oh!

ZhenjaHorbach commented Jun 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 24, 2024

Uh oh!

OSBotify commented Jun 25, 2024

Uh oh!

OSBotify commented Jul 3, 2024

Uh oh!

OSBotify commented Jul 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fedirjh commented Jun 19, 2024 •

edited

Loading

ZhenjaHorbach commented Jun 20, 2024 •

edited

Loading

ZhenjaHorbach commented Jun 23, 2024 •

edited

Loading