Add HybridApp deploy to platform deploy#43046
Merged
Merged
Conversation
|
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
Testing: Let's CP this to staging once it's merged to give it a full test before we run a staging deploy just incase we need to revert this again. |
roryabraham
approved these changes
Jun 4, 2024
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
OSBotify
pushed a commit
that referenced
this pull request
Jun 4, 2024
Add HybridApp deploy to platform deploy (cherry picked from commit 87efc85)
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
Author
|
This didn't work, we are reverting it. |
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adds the HybridApp deploy workflow call when we are deploying to staging, round two. This time I understand the tests a bit better and they are being correctly mocked. Additionally, we are now following the GitHub documentation on how to call this re-usable workflow.
Fixed Issues
Related #37858
Tests
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
-[ ] I linked the correct issue in the
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A - Deploy only
Android: mWeb Chrome
N/A - Deploy only
iOS: Native
N/A - Deploy only
iOS: mWeb Safari
N/A - Deploy only
MacOS: Chrome / Safari
N/A - Deploy only
MacOS: Desktop
N/A - Deploy only