Skip to content

Revert "fix: Taxes - App allows deleted tax rate to be selected as currency default in offline mode."#42953

Closed
iwiznia wants to merge 1 commit into
mainfrom
revert-42620-krishna2323/issue/41066
Closed

Revert "fix: Taxes - App allows deleted tax rate to be selected as currency default in offline mode."#42953
iwiznia wants to merge 1 commit into
mainfrom
revert-42620-krishna2323/issue/41066

Conversation

@iwiznia

@iwiznia iwiznia commented May 31, 2024

Copy link
Copy Markdown
Contributor

@iwiznia iwiznia self-assigned this May 31, 2024
@iwiznia iwiznia requested a review from a team as a code owner May 31, 2024 21:58
@melvin-bot melvin-bot Bot requested review from youssef-lr and removed request for a team May 31, 2024 21:59
@melvin-bot

melvin-bot Bot commented May 31, 2024

Copy link
Copy Markdown

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Krishna2323

Krishna2323 commented May 31, 2024

Copy link
Copy Markdown
Contributor

@iwiznia, do we need a revert? I was waiting for response on #42620 (comment).

@iwiznia

iwiznia commented May 31, 2024

Copy link
Copy Markdown
Contributor Author

We don't need it but seems like the simplest option. You can work on re-sending the PR with the needed changes without us having to decide between blocking a deploy or deploying "broken" code or having to do a CP to staging.
As for the answer, I think you'll find it in the issue that was open due to it.

@iwiznia

iwiznia commented May 31, 2024

Copy link
Copy Markdown
Contributor Author

Oh wait, I guess we will have to CP the code either way (or deploy the broken code). Anyway, we can close this revert if the PR you send is ready to go in the next deploy.

@Krishna2323

Copy link
Copy Markdown
Contributor

@iwiznia, ok, can you pls confirm this #42620 (comment) for me? After that I will raise the PR within an hour or two.

@iwiznia

iwiznia commented May 31, 2024

Copy link
Copy Markdown
Contributor Author

k, can you pls confirm this #42620 (comment) for me?

I think you'll find the answer to it in the issue that was open here #42918

@MonilBhavsar

Copy link
Copy Markdown
Contributor

Followup PR #42974 is made, so I think we can close this. Thanks @Krishna2323!

@youssef-lr

Copy link
Copy Markdown
Contributor

Can we close this?

@youssef-lr

Copy link
Copy Markdown
Contributor

I think we can close 😀

@youssef-lr youssef-lr closed this Aug 20, 2024
@coleaeason coleaeason deleted the revert-42620-krishna2323/issue/41066 branch May 19, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants